find_package(PkgConfig} respects the PKG_CONFIG environment variable
when trying to find pkg-config. This is helpful with a differently
named pkg-config executable, for example an arch-prefixed one.
The composer splits addresses on "," and later joins them on ", ". This means
that separating spaces are doubled after every autocomplete. This patch fixes
that by stripping whitespace after splitting. We do this in a separate loop at
the end of the function as opposed to directly after splitting in order not to
upset the cursor positioning logic.
This does not fix the problem that an address like
"Kluck, Timo" <tkluck@infty.nl>
are split on the comma. Before this patch, the space would be doubled. After
this patch, it will always be reduced to a single space. A better solution
would ideally leave the quoted part as-is. I think this will also lead to
better auto-complete behaviour when the cursor is in the quoted part. Better
parsing of the quoted part is beyond the scope of this patch.
Check for both lower-case names and Outlook-specific Sent and Deleted
folder names. Don't require translations to also include the English
names in the translated strings.
* src/engine/imap-engine/imap-engine-generic-account.vala (Account):
Compile the special name list only once, in the constructor. Cache the
names in new special_search_names property.
(::compile_special_search_names): Replace the compilation
::get_mailbox_search_names, compile both upper case and lower case
versions of each name. Check for empty names.
(::get_special_search_names): Replace the translation part of
::get_mailbox_search_names. Include both localised and unlocalised
versions of the names so translators don't need to keep the english
versions. Add Outlook names for sent and deleted separately so as to
not break existing translations.
(::ensure_special_folder_async): Use new pre-compiled
special_search_names property to guess names.
This fixes regular crashes from incorrect lengths on i686 arches - see
Vala Bug 767839.
Fixes Geary Bug 758621
* src/engine/imap-engine/imap-engine-minimal-folder.vala: Use "%lld" when
printing int64 values.
* src/client/conversation-viewer/conversation-viewer.vala
(ConversationViewer::highlight_search_terms): Only do the highlight if
the current folder is a search folder and it has a query. Cache the
fetch cancellable so we can avoid setting the highlight on the web view
if cancelled. Import ::add_literal_matches method impl and remove that
method since it only gets used here.
Since the search folder will cause a re-fetch on search when the search
query has changed such that the results have also changed, the fetch will
launch a highlight search and we don't also need to launch it again when
the search terms have changed. This saves potentially a lot of DB query
time.
* src/client/conversation-viewer/conversation-viewer.vala
(ConversationViewer): Remove on_search_text_changed and its callers.
When Geary.RFC822.Message::construct_body_from_mime_parts is looking to
build a message body to display, during the first pass that looks for
HTML content the plain text part is ignored but the inline image gets
converted to a HTML IMG element and returned as the body. This makes it
look like an HTML part was found, and hence the second pass looking for
plain text never takes place.
Fix this by not taking a wild stab at the body type - check to see if it
has HTML parts and if so just het them, if not then get plain text parts.
Bug 767438.
* src/engine/rfc822/rfc822-message.vala (Message): Add ::has_html_body
and ::has_plain_body to allow callers to query available body content
types before attempting to get them. Remove ::get_body since it's
making a policy decision that callers should be making instead, fix
call sites.
* src/engine/util/util-ascii.vala (Geary.Ascii): Remove functions that
are now supported by Vala 0.26, that are simple statements, or are only
used once elsewhere. Update call sites.
* debian/control Add build dependency on libenchant-dev and
runtime dependency on libenchant1c2a, to reflect latest
changes introduced for the spell-checker.
Bug 720335
* src/client/composer/spell-check-popover.vala
Implemented a GtkPopover allowing the user to select a
subset of the currently installed dictionaries for the spell
checking in the composer widget.
* src/client/util/util-international-vala
Added detection of installed dictionaries and proper
translation of the available languages. This requires
Enchant as an additional dependency.
* src/client/application/geary-config.vala
Added keys spell-check-visible-languages and
spell-check-languages in GSettings.
Outlook.com's IMAP servers are buggy and will return a bogus BAD if too
many STATUS commands are sent at once. Limit this to 25 since there is at
least one known case of it falling over when ~50 are sent.
Bug 766552.
* src/engine/api/geary-endpoint.vala (Endpoint): Add
max_pipeline_batch_size property and doc comment.
* src/engine/imap-engine/outlook/imap-engine-outlook-account.vala
(OutlookAccount): Set max_pipeline_batch_size for IMAP connection to 25.
* src/engine/imap/transport/imap-client-session.vala
(ClientSession::send_multiple_commands_async): Check
Endpoint.max_pipeline_batch_size and if non-zero, use multiple batches
and limite them to that value in size.
