In my previous commit assigning Yorba's copyright lines to the Software Freedom
Conservancy I even changed translated strings in .po files. I believe that
was the wrong thing to do; translators will sort this out. This change reverts
the .po file changes.
Bug 765515.
* src/engine/imap-db/imap-db-account.vala
(Geary.ImapDB.Account::do_get_search_matches): Check the query actually
returned valid FTS offsets before attempting to use them.
Bug 763203.
This enables the two-arg form of fts3_tokenizer in SQLite for the Geary
databases, used set the custom unicodesn tokeniser for full-text message
search. The two-arg form was disabled by default in 3.11 for secuity
reasons, but can be programmatically enabled in 3.12.
Note that this does not fix SQLite 3.11, to do that it must be recompiled
with -DSQLITE_ENABLE_FTS3_TOKENIZER.
* src/sqlite3-unicodesn/static.c (registerTokenizer): Enable two-arg form
of fts3_tokenizer if SQLite >= 3.12 is detected.
* src/sqlite3-unicodesn/CMakeLists.txt: Set SQLITE_3_12 define as needed.
* CMakeLists.txt: Check for both SQLite 3.12 and 3.11, print a warning if
the latter is found.
When implementing bug 765359, it appears that Geary is doing too much
work to load icons. Simplify it a bit.
* src/client/components/icon-factory.vala (IconFactory): Don't bother
loading an application icon, it's easier and works better to just use
an icon name where needed. Don't bother adding all of the icons/*x*
directories to the icon theme search path, just make the icon's
directory hierarchy follow the XDG/hicolor spec and add the base
directory. Remove now-redundant code.
* src/client/application/geary-controller.vala: Set the default icon name
for all geary windows.
(GearyController:on_about()): Set the name for the icon in the About
dialog.
* src/client/components/main-window.vala (ApplicationWindow): Don't
bother loading icons for the window, just use the new default.
* src/client/notification/libnotify.vala: Don't bother passing the
application icon through for error notifications, an icon name has
already been set.
* icons/*x*/geary.png: Move to a new directory hierarchy that follows the
hicolor spec.
* icons/CMakeLists.txt: Updated to use new paths to the icons.
Since we can't get the delim from the FolderPath's root any more, we need
to ensure it is always passed in.
* src/engine/imap/message/imap-mailbox-specifier.vala (from_folder_path):
Made delim param non-nullable. Updated call sites.
* src/engine/imap/api/imap-folder.vala: Use existing MailboxInformation
property to get the delim since we don't have access to the account.
* src/engine/imap/api/imap-account.vala: Use the account's existing
knowedge of the INBOX's delim as the delim.
* src/engine/imap-db/imap-db-folder.vala: Hardcode ">" as the delim since
it's a local folder and we don't care, but on the bright side it also
makes it obvious when to_string()'ed what we are looking at.
* src/engine/api/geary-folder-path.vala (get_fullpath): Make return value
non-nullable, since it is now.
* src/engine/api/geary-folder-path.vala (FolderRoot): Remove
default_separator property and param from the ctor. Updated subclasses,
uses of the property.
(Geary.FolderPath.has_default_separator): Removed, since it never has a
default_separator any more. Updated call sites.
* src/engine/imap-db/imap-db-folder.vala (set_path): Removed, no longer
useful since folder paths do not need to have their delim updated.
* src/engine/imap/api/imap-account.vala: Use the account's
hierarchy_delimiter instead of the root folder's.
* src/engine/imap/api/imap-account.vala (Geary.Imap.Account): Add
hierarchy_delimiter.
(claim_session_async): Always do an (X)LIST so hierarchy_delimiter gets set.
(list_inbox): Renamed from determine_xlist_inbox, do a LIST or XLIST as
appropriate, set the account's INBOX's specifier and
hierarchy_delimiter from the result.
Geary.Imap.ClientConnection::disconnect_async is causing its TLS
connection to be disposed of, before closing the instance's
Serialiser. When the Serialiser is closed and displosed of, the
underlying stream attempts a flush, but since s connection has already
been displosed of, triggers an assertion failure instead.
* src/engine/imap/transport/imap-client-connection.vala
(::disconnect_async): Ensure the serialiser is closed and disposed of
before closing the TLS connection.
Since both IMAP and SMTP implement graceful disconnect at the application
protocol level, doing it again at the TCP level is redundant.
The use of graceful disconnect was introduced as part of the fix for Bug
713736, but it is not clear why it was included. Removing it also fixes
Bug 757088, which can cause the UI to freeze if the connection is
lost (e.g. on wifi drop out).
* src/engine/api/geary-endpoint.vala (Flags): Remove GRACEFUL_DISCONNECT
and all references to it in other code.
(SocketConnection::connect_async): Remove the conditional enabling
TcpConnection::set_graceful_disconnect.
If a message body also uses class="body" on an element containing a
remote image, then the IMG element wil be processed more than once and
the allow_prefix added more than once, breaking remote image load.
Bug 764919
* src/client/conversation-viewer/conversation-viewer.vala
(show_images_email): Use Util.DOM.select to ensure we only get the
Geary .body element, and not any in the HTML of the message body. Do
the same for the remote_images DIV.
Namely, the "Use three pan view" and "Always watch for new mail"
options. Also update the text about notifications to reflect changes to
GNOME Shell.
https://bugzilla.gnome.org/show_bug.cgi?id=749925
* src/CMakeLists.txt: Bump target GLib to min required for
GtkTemplate. Pass resources XML file to valac.
* ui/CMakeLists.txt: Copy both the generated resources XML file and the
resources themselves to the CMake binary directory, since valac expects
the UI files to be in the same directory as the resource XML.
* debian/control: Chase GLib version bump.
* src/client/conversation-viewer/conversation-viewer.vala
(ConversationViewer::show_images_email): Crash happens when setting
value for an existing SRC attr on existing IMG element, so remove it
before setting it.
Signed-off-by: Michael James Gratton <mike@vee.net>
