Commit graph

4254 commits

Author SHA1 Message Date
Michael Gratton
744cde0c2f Don't update a folder's unread email count during normalisation
Updating the unread count after opening a folder and finding email that
has an unexpected unread status messes up the count obtained from the
server, which has already taken these messages into account.

Here, both the main normalisation process and the email flag updater are
prevented from adjusting the unread count for a folder when they
encounter email that are new and unread, or have an unread status
different from what was last seen by the engine.

See #213
2019-02-15 13:40:04 +11:00
Michael Gratton
272d95e36a Add Email.Field.FIELDS to ImapDb.Folder.REQUIRED_FIELDS
This is especially needed since when moving a message from one folder to
another, the copy's flags are will un-flag it as deleted, so it actually
shows up again in conversations after the MoveEmailCommit op deletes the
original in the source folder.

This also has the extra benefit however of makig sure the engine knows
up-front what the uread state of all new mail is, and hence might
actaully get unread counts correct.
2019-02-15 01:57:35 +11:00
Michael Gratton
0d3733b025 Reduce email prefetcher debug verbosity a bit 2019-02-15 01:57:35 +11:00
Michael Gratton
75d35ab76d Tweak FetchEmail::describe_state() 2019-02-15 01:57:35 +11:00
Michael Gratton
c8fa350e1e Document what actually happens when MoveEmailCommit is executed 2019-02-15 01:57:35 +11:00
Michael Gratton
e490905b21 Merge branch 'wip/composer-shortcuts' into 'master'
Refine composer shortcuts

See merge request GNOME/geary!106
2019-02-13 14:31:21 +00:00
Michael Gratton
d188397592 Merge branch 'wip/email-flag-refinement' into 'master'
Email flags not always updated

See merge request GNOME/geary!105
2019-02-13 14:30:41 +00:00
Michael Gratton
1c36b57860 Don't override Ctrl+W to close the composer
This should be handled at a per-window level.
2019-02-13 23:25:58 +11:00
Michael Gratton
8a979ff8e8 Fix ComposerWebView::is_empty sense
This prevents losing a message if only a message body has been entered
and there is nothing has ever been undone.
2019-02-13 23:25:58 +11:00
Michael Gratton
e8dc1af45e Scope composer editor shortcuts to the toolbar and web view only
This prevents something like Ctrl+I being typed in the subject line
triggering italic in the editor.
2019-02-13 23:25:58 +11:00
Michael Gratton
9eead5d145 Replace composer keyboard shortcut with standard widget action scoping
Rather than adding and removing shortcuts when the composer's web view
gains and loses focus to avoid invoking main window shortcuts, just
rely on standard GTK action scoping rules.

This fixes editing shortcuts like Ctrl+I breaking when clicking on
toolbar buttons, a crasher because the composer left the undo button
enabled after it was closed, and allows Escape to close the composer
from anywherre.

Fixes https://bugzilla.gnome.org/show_bug.cgi?id=774651,
https://bugzilla.gnome.org/show_bug.cgi?id=785187, and
https://bugzilla.gnome.org/show_bug.cgi?id=741741
2019-02-13 23:25:58 +11:00
Marek Cernocky
2f48326bd3 Updated Czech translation 2019-02-13 10:01:36 +01:00
Michael Gratton
8098f42cb2 Merge branch 'master' into 'master'
Issue #45 Fix

See merge request GNOME/geary!103
2019-02-13 08:36:01 +00:00
Michael Gratton
7c05f5d390 Throw the correct error when email id is not valid for create_or_merge 2019-02-13 18:53:51 +11:00
Michael Gratton
438f74dc37 Pass a email id with a position when setting flags during a merge
This ensures that flag updates actually happen when doing a merge
with remote email instances obtained from the IMAP stack.
2019-02-13 18:53:51 +11:00
Michael Gratton
4575f68af1 Ensure ImapDb.Folder.set_email_flag_async also works on deleted email
Even deleted email can have its flag updated, e.g. if undeleted from
another client. Especially important now we are observing the \Deleted
flag from the server.
2019-02-13 18:53:51 +11:00
Michael Gratton
fa48f989f7 Explicity throw an error when requirements aren't met for setting flags
It's probably a programmign error if an error is thrown, but bugs will
never be caught if they errors aren't thrown.
2019-02-13 18:44:01 +11:00
Michael Gratton
539893fb72 Add some unit tests for setting email flags 2019-02-13 18:41:49 +11:00
Ryuta Fujii
9b09cdef91 Update Japanese translation 2019-02-12 11:07:44 +00:00
Anders Jonsson
559871510e Update Swedish translation 2019-02-12 10:02:51 +00:00
john
7a37a4650b Fix serveral things for the MR 2019-02-12 14:49:44 +08:00
Michael Gratton
fb6e6383ea Treat ConnectivityManager errors as failure rather than unreachable
This lets the errors get reported to the user.
2019-02-12 12:05:59 +11:00
Michael Gratton
68f31e0e59 Revert changes from last two commits that introduced fuzzy translations
See commit 9aefdf36, commit 430609c3 and #210
2019-02-12 11:23:33 +11:00
Michael Gratton
430609c364 Unify translations for RFC-822 header labels
See #210
2019-02-12 11:01:20 +11:00
Michael Gratton
9aefdf3673 Better distinguish connection and network problems in MainWindowInfoBar
See #210
2019-02-12 11:01:20 +11:00
Michael Gratton
1807a187bd Unify three variants of "try reconnecting" strings
See #210
2019-02-11 08:19:43 +11:00
john
15f50cf5d9 Change all adj.value variable into int 2019-02-10 23:47:49 +08:00
Ryuta Fujii
bfbc18b680 Update Japanese translation 2019-02-10 14:31:02 +00:00
john
07d69956d2 Merge branch 'master' of gitlab.gnome.org:799433746/geary 2019-02-10 21:51:27 +08:00
john
e3f1c364f8 Merge remote-tracking branch 'upstream/master' 2019-02-10 21:49:15 +08:00
Michael Gratton
5f769ca3e2 Fix leaking inline composer widgets 2019-02-10 22:47:32 +11:00
Michael Gratton
61799fe030 Make ComposerWidget implement BaseInterface to track refcounting 2019-02-10 22:47:32 +11:00
Michael Gratton
a08cecad7b Make public I/O methods in Imap.Client require cancellables
Explicit is better than implcit. Fix a few places where it wasn't being
passed in, resulting in some criticals when accounts have gone away.
2019-02-10 22:47:32 +11:00
Emin Tufan Çetin
f89f8f55ea Update Turkish translation 2019-02-10 08:55:51 +00:00
Sabri Ünal
1d94a1b4ea Update Turkish translation 2019-02-10 08:35:38 +00:00
799433746
fca31abcd2 Update client-web-view.js minimal change 2019-02-10 04:50:51 +00:00
john
6c53e003bc A small typo... 2019-02-10 12:37:19 +08:00
john
46cd8baed1 Avoiding add signal into the EmailRow, but translate seems hard to do since the webview is in the inside of message. 2019-02-10 12:19:05 +08:00
Michael Gratton
3c4695ef85 Merge branch 'plaintext-markdown' into 'master'
Don't add Geary-flavored markdown to plain text messages

Closes #201

See merge request GNOME/geary!102
2019-02-10 02:44:44 +00:00
john
720fa65e6a Reconsrtuct some redudant function 2019-02-09 17:54:00 +08:00
john
9039b57d49 Issue#45 repaired 2019-02-09 17:18:44 +08:00
Alex Henrie
67d819565e Don't add Geary-flavored markdown to plain text messages
Fixes #201
2019-02-08 23:16:01 -07:00
john
cb01fafe3f 成功定位坐标 2019-02-09 11:09:56 +08:00
Michael Gratton
fc8f0b6f16 Fix Composer not correctly handling multiple account sender mailboxes 2019-02-08 16:59:20 +11:00
Michael Gratton
215e594dd5 Merge branch 'wip/limit-replay-op-retries' into 'master'
Replay queue and IMAP IDLE cleanup

See merge request GNOME/geary!99
2019-02-08 00:34:50 +00:00
Michael Gratton
3a120f1130 Fix a few warnings when switching between folders quickly 2019-02-08 11:26:39 +11:00
Michael Gratton
d320d33b84 Update hidden ConversationMonitor error debug logging to warnings
This will make them a bit more visible if they actually happen.
2019-02-08 11:26:39 +11:00
Michael Gratton
f1ca4bb435 Reduce the default amount of conversation logging substantially 2019-02-08 11:26:39 +11:00
Michael Gratton
00d381d6a9 Trivial test case cleanup 2019-02-08 11:26:39 +11:00
Michael Gratton
cf6f0b1897 Merge branch 'wip/flatpak-goa-perms' into 'master'
Allow access to the ControlCenter and GOA daemon from Flatpak sandbox

Closes #202

See merge request GNOME/geary!100
2019-02-07 23:40:12 +00:00