Commit graph

6063 commits

Author SHA1 Message Date
Michael Gratton
e2f2b6cdab Geary.RFC822.Message: Add accessors for message headers and raw body
Allow accessing Header and Text representations of the message.
2020-07-30 12:53:11 +10:00
Michael Gratton
0b8bf7375f Geary.Imap.EnvelopeDecoder: Suppress message id errors
Even if the a message has an invalid message id or message id list
header value, we need to keep parsing the message to ensure we can
do *something* useful with it.
2020-07-30 12:53:11 +10:00
Michael Gratton
26f5fdef38 Geary.RFC822.Message: Suppress message id errors in ctors
Even if the a message has an invalid message id or message id list
header value, we need to keep parsing the message to ensure we can
do *something* useful with it.
2020-07-30 12:53:11 +10:00
Michael Gratton
537410f76e Geary.RFC822.{MessageID,MessageIdList}: Throw error parsing empty rfc822
An empty string is not a valid RFC822 message id or message id list, so
don't treat it as such.
2020-07-30 12:53:11 +10:00
Michael Gratton
b78dfe7cb8 Composer.Widget: Convert references to a MessageIdList instance
Using the high-level representation avoids having to re-parse and
re-format the list.

Update the util method Geary.RFC822.Utils.reply_references to support
this.
2020-07-30 12:53:11 +10:00
Rafael Fontenelle
7f632703b7 Update Brazilian Portuguese translation 2020-07-18 12:19:51 +00:00
Jordi Mas
7a0b4fb3f1 Update Catalan translations 2020-07-11 22:35:17 +02:00
Jordi Mas
1f24530e57 Update Catalan translation 2020-07-09 23:05:35 +02:00
Andre Klapper
49f3f17ddc Fix broken markup in Italian help translation 2020-07-07 18:51:05 +02:00
Andre Klapper
897722f784 Fix Mallard validation errors by changing section IDs 2020-07-06 19:19:11 +02:00
Michael Gratton
42b13b827d Merge branch 'ricotz/vala' into 'mainline'
Don't use unsupported vala syntax

See merge request GNOME/geary!527
2020-07-03 10:48:47 +00:00
Rico Tzschichholz
0c57eed50b Don't use unsupported vala syntax 2020-07-02 15:32:22 +02:00
Michael James Gratton
03af13cbf1 Geary.RFC822.Message: Fix criticals from missing parameter nullable annotation 2020-07-02 11:05:55 +10:00
Michael James Gratton
64a7f8d3a9 Application.ContactStore: Fix criticals from missing param nullable annotation 2020-07-02 10:49:17 +10:00
Michael Gratton
f6af688623 Geary.ImapDb.Database: Fix criticals when ::run_gc to_pause is null 2020-07-01 11:50:55 +10:00
Michael Gratton
ec7a970743 Geary.ImapDb.Database: Fix free after use when GC'ing
Passing arrays to async methods will cause use-after-free segfaults
after yielding (see GNOME/vala#751), so pass services in to `run_gc()`
via a Gee Collection.
2020-07-01 11:38:39 +10:00
Michael Gratton
16efce0514 Fix build failure 2020-06-30 18:25:51 +10:00
Michael Gratton
cfbac77fa4 Merge branch 'mjog/unit-test-subproject' into 'mainline'
Unit test subproject and cleanup

See merge request GNOME/geary!517
2020-06-30 08:08:54 +00:00
Michael Gratton
3550c69723 Merge branch 'mjog/server-quirks' into 'mainline'
Server quirks

See merge request GNOME/geary!508
2020-06-30 07:50:05 +00:00
Michael Gratton
4d6dad1cfa Merge branch 'mjog/746-gmail-flag-quote-bug' into 'mainline'
GMail flag quote bug

Closes #746

See merge request GNOME/geary!507
2020-06-30 07:46:17 +00:00
Michael Gratton
7c48589550 vala-unit: Skip gee collection in older valac
It will fail without current vala head, so just skip under 0.48 or less.

See GNOME/vala#992
2020-06-30 17:31:07 +10:00
Michael Gratton
0ae633d88f Update existing tests to work with ValaUnit 2020-06-30 17:31:07 +10:00
Michael Gratton
6b1bad28b9 Move generic unit test classes to a new basically-standalone subproject
Break out the generic testing code into something easily re-used, and
improve the API substantially:

 * Use generics to reduce the number of equality tests to effectively
   a single one
 * Make all assert args consistent in that the actual value is always
   listed first.
 * Add convenience API for common string/array/collection assertions
2020-06-30 17:20:12 +10:00
Michael Gratton
e4edf28e0c Merge branch 'remove-old-msgs-beyond-storage-pref' into 'mainline'
Remove old messages beyond storage preference

See merge request GNOME/geary!388
2020-06-30 07:07:12 +00:00
Piotr Drąg
855eab580c Update Polish translation 2020-06-28 12:51:54 +02:00
Michael Gratton
c4a3ab64a9 Merge branch 'mjog/misc-fixes' into 'mainline'
Misc fixes

See merge request GNOME/geary!526
2020-06-27 06:35:54 +00:00
Michael Gratton
d0efd00386 Composer.Widget: API doc comment updates 2020-06-27 13:49:09 +10:00
Michael Gratton
3daeade46f Application.Controller: Fix composer not appearing inline for replies 2020-06-27 13:48:24 +10:00
Michael Gratton
97ba8be7cd Merge branch 'mjog/misc-criticals' into 'mainline'
Misc criticals

Closes #802, #865, #875, and #886

See merge request GNOME/geary!525
2020-06-27 02:54:47 +00:00
Michael Gratton
b519143d63 Geary.Imap.Deserialiser: Log literal values when logging enabled
Not much point logging deser without being able to see actual literals
being pulled down over the wire.
2020-06-27 12:36:14 +10:00
Michael Gratton
fdef83d6fb Geary.ImapEngine.EmailPrefetcher: Bump up prefetch chunk size
Increases chunk size from 32KB to 512KB to speed up background sync
when downloading large mailboxes.
2020-06-27 12:34:37 +10:00
Michael Gratton
7e05b99db5 Application.MainWindow: Fix hidden auth and cert infobars buttons 2020-06-27 12:34:00 +10:00
Michael Gratton
576d3a7811 Engine: Handle errors when constructing email objects from wire or db
Now that the RFC822 objects throw errors in any ctors that require
parsing, check for those and handle appropriately. Also ensure the
correct ctor is being used, and that the data being passed to them
is in the correct format (i.e. typically RFC822-formatted).

Fixes #886
2020-06-27 12:18:12 +10:00
Baurzhan Muftakhidinov
65adddc0e7 Update Kazakh translation 2020-06-26 12:46:23 +00:00
Michael Gratton
cdf92b06b2 Geary.RFC822: Use a singlton GMime.ParserOptions object
Maintain a ref to a singleton options object, be explicit in what
options are being used.
2020-06-26 17:35:39 +10:00
Michael Gratton
52fdf3677c Geary.RFC822.MailboxAddresses: Use RFC822 GMime parser options
Ensure the RFC822 package's parser options are used when parsing RFC822
strings.
2020-06-26 17:22:45 +10:00
Michael Gratton
8125ab8c3b Geary.RFC822.Header: Add get_raw_header
Add header accessor to enable getting raw header values when needed.
2020-06-26 17:20:02 +10:00
Michael Gratton
be0ce29a1b Geary.ImapEngine.AccountSynchronizer: Avoid a critical in the destructor
Use a weak ref in the dtor when disconnecting from the folders signals
to avoid reffing the folder, which may be destroyed already when the
object is destroyed.
2020-06-26 17:17:58 +10:00
Michael Gratton
997e8e2c4d Geary.Util.Logging: Respect standard G_DEBUG breakpoint semantics
Check the value of G_DEBUG and ensure we trip gdb breakpoint as
appropriate for warnings and criticals.
2020-06-26 17:15:12 +10:00
Michael Gratton
16a25870f4 Geary.Util.Logging: Avoid logging any destroyed loggable objects
Extends the fix for commit 8c43288b to all logging parents as well. Use
a weak ref so we don't try to ref loggable objects that are already
destroyed.

Fixes #875
2020-06-26 17:14:12 +10:00
Michael Gratton
b7076188a0 Geary.Imap.FolderSession: Fix critical with empty preview buffers
Check preview header and body buffers are not empty before attempting
to extract a preview from them.

Fixes #865 (or at least replaces the crit with a warning)
2020-06-25 20:39:13 +10:00
Yuri Chornoivan
2d1ed8df09 Update Ukrainian translation 2020-06-25 06:11:10 +00:00
Michael Gratton
164c34e32a ConversationListView: Fix critical updating selection without a model
Fixes #802
2020-06-25 15:52:55 +10:00
Michael Gratton
e3cd1ca64c Merge branch 'cherry-pick-b6907da0' into 'mainline'
Merge branch 'Vanadiae-gnome-3-36-patch-73276' into 'mainline'

See merge request GNOME/geary!524
2020-06-25 02:39:26 +00:00
Michael Gratton
bd0f154fa3 Merge branch 'mjog/discourse-migration' into 'mainline'
Discourse migration

See merge request GNOME/geary!522
2020-06-25 02:08:58 +00:00
Michael Gratton
afcefc32b4 Merge branch 'Vanadiae-gnome-3-36-patch-73276' into 'gnome-3-36'
help: stop making geary icon translatable

See merge request GNOME/geary!519

(cherry picked from commit b6907da0d42778584ba92c413631e65f8badb66b)

62499bdf help: stop making geary icon translatable
2020-06-25 02:06:27 +00:00
Michael Gratton
18993401af Merge branch 'mjog/vala-async-param-assert-fixes' into 'mainline'
Geary.RFC822.Message: Fix some missing nullable annotations

See merge request GNOME/geary!523
2020-06-25 01:15:38 +00:00
Michael Gratton
ea8778cf62 Geary.RFC822.Message: Fix some missing nullable annotations
Now that vala is assert-checking params on async methods
(GNOME/vala#1005), fix a few places where they turn up problems in the
engine.
2020-06-25 10:32:02 +10:00
Michael Gratton
00f355648d help: Rework support and bug reporting text
Prefer referring to getting support rather than bug reporting. Add a
section describing how to get support vs reporting bugs. Streamline the
contributing page.
2020-06-24 23:06:16 +10:00
Michael Gratton
cae09a0138 README.md, CONTRIBUTING.md: Mention discourse & update for consistency 2020-06-24 23:02:46 +10:00