nettika/geary
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Geary.RFC822.Message: Suppress message id errors in ctors

Browse source 
Even if the a message has an invalid message id or message id list
header value, we need to keep parsing the message to ensure we can
do *something* useful with it.
This commit is contained in:
Michael Gratton 2020-06-30 14:26:31 +10:00 • committed by Michael James Gratton
parent 537410f76e
commit 26f5fdef38
1 changed files with 15 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/engine/rfc822/rfc822-message.vala
View file

@ -961,11 +961,21 @@ public class Geary.RFC822.Message : BaseObject, EmailHeaderSet {
return addresses;
}
private MessageIDList append_message_id(MessageIDList? existing,
string header_value) {
MessageIDList ids = new MessageIDList.from_rfc822_string(header_value);
if (existing != null) {
ids = existing.append(ids);
private MessageIDList? append_message_id(MessageIDList? existing,
string header_value)
throws Error {
MessageIDList? ids = existing;
if (!String.is_empty_or_whitespace(header_value)) {
try {
ids = new MessageIDList.from_rfc822_string(header_value);
if (existing != null) {
ids = existing.append(ids);
}
} catch (Error err) {
// Can't simply throw this since we need to be as lax as
// possible when decoding messages. Hence just log it.
debug("Error parsing message id list: %s", err.message);
}
}
return ids;
}