Commit graph

4201 commits

Author SHA1 Message Date
Michael Gratton
00d381d6a9 Trivial test case cleanup 2019-02-08 11:26:39 +11:00
Michael Gratton
cf6f0b1897 Merge branch 'wip/flatpak-goa-perms' into 'master'
Allow access to the ControlCenter and GOA daemon from Flatpak sandbox

Closes #202

See merge request GNOME/geary!100
2019-02-07 23:40:12 +00:00
Michael Gratton
988c3ab051 Allow access to the ControlCenter and GOA daemon from Flatpak sandbox
Fixes #202
2019-02-08 09:56:38 +11:00
Balázs Úr
117c77767a Update Hungarian translation 2019-02-07 18:35:21 +00:00
Michael Gratton
82c1e640a7 Merge branch 'wip/search-cleanup' into 'master'
Search cleanup

See merge request GNOME/geary!97
2019-02-07 10:50:33 +00:00
Michael Gratton
55a6d79f41 Fix conversation message placholders being duplicated/not hidden 2019-02-07 17:09:48 +11:00
Ryuta Fujii
2e37779163 Update Japanese translation 2019-02-06 10:45:00 +00:00
Ryuta Fujii
8ba4f8f656 Update Japanese translation 2019-02-05 22:58:37 +00:00
Ryuta Fujii
314fefd386 Update Japanese translation 2019-02-04 23:02:01 +00:00
Ryuta Fujii
61845b5443 Update Japanese translation 2019-02-04 17:57:10 +00:00
Ryuta Fujii
03ca6cdbf4 Update Japanese translation 2019-02-04 17:46:09 +00:00
Ryuta Fujii
aba10fc4f0 Update Japanese translation 2019-02-04 15:17:14 +00:00
Michael Gratton
beccdd49df Make ImapDB.Account.get_search_matches_async greedy stripping consistent
Only strips greey matches if implied by the search query, to make its
results consistent with ::search_async.
2019-02-04 23:19:08 +11:00
Michael Gratton
cc4bcdcd1c Clean up ImapDB.Account.search_async and related methods
Make result stripping methods operate on the same collection so it's
easier to follow what is happening, and less objects need to be created
(especially when not stripping greedy stemming results).
2019-02-04 23:19:08 +11:00
Michael Gratton
74ac2f68dd Fix critical from loader timer when conversation email load cancelled 2019-02-04 23:19:08 +11:00
Michael Gratton
699594711d Ensure conversation find entry focused when visble and shortcut invoked 2019-02-04 23:19:08 +11:00
Michael Gratton
6be12937f2 Fix default value for ConversationOperation::allow_duplicates
Make the default true, which is required for most operations. In
particular, this was preventing conversations from being removed from
a search when two remove ops were queued in quick succession.
Make InsertOperation use the default since if we don't want to ignore
email inserted if it happens twice in quick succession, for the same
reason.
2019-02-04 23:18:34 +11:00
Michael Gratton
710f99df35 Fix critical trying to load a conversation with 0 email
This can happen when the search is changing and a number of
conversations are evaporating.
2019-02-04 00:16:22 +11:00
Michael Gratton
f3ef34531c Clean up client search term highlighting code
Move all highlighing code from ConversationListBox into a seperate
class, ensure existing any existing highlighting process is cancelled
before launching a new one or clearing highlighting. Don't attempt to do
any highlighting when there are no search terms.
2019-02-03 22:37:12 +11:00
Michael Gratton
c54cb05793 Fix critical when email body load is cancelled
This was happening when a search query was changing rapidly as it was
being typed, hence conversations being quickly loaded and cancelled.
2019-02-03 22:37:12 +11:00
Michael Gratton
0ab313d829 Merge branch 'wip/flatpak-remove-custom-build-flags' into 'master'
Remove redundant build-options from the Flatpak manifest

See merge request GNOME/geary!96
2019-02-03 00:48:28 +00:00
Ryuta Fujii
651050555e Update Japanese translation 2019-02-02 14:23:04 +00:00
Ryuta Fujii
3b12fe9738 Update Japanese translation 2019-02-02 13:57:32 +00:00
Ryuta Fujii
bb27d04591 Update Japanese translation 2019-02-02 13:14:20 +00:00
Ryuta Fujii
d8ca56fb8d Update Japanese translation
(cherry picked from commit b090c52a2bba87467247124d835de1b579d48ae1)
2019-02-02 10:51:10 +00:00
Juraj Fiala
6b5f34eb87 Remove redundant build-options from the Flatpak manifest
Since fd.o 18.08, i.e. GNOME 3.30, the runtime provides a comprehensive list of build flags, surmounting the current one.
2019-02-02 10:11:32 +00:00
Michael Gratton
5de971cc77 Merge branch 'wip/34-yahoo-fixes' into 'master'
Misc fixes for Yahoo accounts

See merge request GNOME/geary!95
2019-02-02 06:37:11 +00:00
Michael Gratton
36b8615347 Include account id in problem report details
This lets us know what account to look for in debug output and if it
is a GOA account.
2019-02-02 16:46:19 +11:00
Michael Gratton
cd050baa03 Don't hard-code special-use mailbox names for Yahoo accounts
Desipte Yahoo's IMAP CAPABILITIES not claiming to support SPECIAL-USE,
its LIST results actually include the appropriate flags, so just use
those.
2019-02-02 16:37:12 +11:00
Michael Gratton
2f9ca91a63 Bump agressive keep-alive interval down to 2 minutes
This makes the Inbox poll for new messages for services that do not
support IMAP IDLE (like Yahoo) much more often, so new mail shows up
quicker.
2019-02-02 16:35:46 +11:00
Michael Gratton
0160cd00ce Merge branch 'wip/geary-is-descendant-of' into 'master'
Fix whitespace not being preserved sometimes when select-quote-relying to a plain text message

See merge request GNOME/geary!94
2019-02-02 04:26:46 +00:00
Michael Gratton
0f554d2371 Fix select-quoting not preserving newlines in some cases
If the common ancestor of the quoted text is the plain-text-message DIV
itself, the isDescendant test fails and the style to preserve new lines
is not maintained. This adds a non-strict check to isDescendant and
enables that when checking the common ancestor node and a test case for
it.
2019-02-02 15:07:41 +11:00
Michael Gratton
c83f07a9f1 Minor tweaks for ConversationPageState.isDescendantOf
Use uppercase since that is what the DOM for HTML defaults to, use
nodeName rather than tagName for cases when there the check is false and
ancestor is the document element, add unit tests.
2019-02-02 15:07:41 +11:00
Michael Gratton
44d871f6f1 Merge branch 'is-descendant-of' into 'master'
Check class name in ConversationPageState.isDescendantOf

See merge request GNOME/geary!77
2019-02-02 04:00:56 +00:00
Michael Gratton
35150701e3 Merge branch 'buzzert/deleted_flags' into 'master'
Fixes bug where messages marked for deletion still appear in message list

See merge request GNOME/geary!54
2019-02-02 02:47:46 +00:00
Michael Gratton
4b3c167689 Merge branch 'wip/conversation-polish' into 'master'
More conversation polish

Closes #80

See merge request GNOME/geary!92
2019-02-02 02:26:38 +00:00
Michael Gratton
8d17354740 Tidy up placeholder style when it has no text 2019-02-02 13:03:45 +11:00
Michael Gratton
c64eb72e69 Display a placeholder when email body loading is taking a long time 2019-02-02 13:03:10 +11:00
Michael Gratton
f223564829 Show a problem report when an error occurs loading a message body 2019-02-02 12:41:01 +11:00
Michael Gratton
2725d3d438 Trivial code formatting cleanup 2019-02-02 12:39:31 +11:00
Michael Gratton
8e4cfdbdea Tidy up ConversationListStore's preview flags
Per Bug 714317, we really just need to the message body, so just require
that as a workaround for now.
2019-02-02 12:39:31 +11:00
Michael Gratton
4c55e79e4e Include preview in Geary.Email.MUTABLE_FIELDS
This means that once the full message body has been retreived, the
possibly partial or poor preview will be updated on merge into the DB.

See Bug 714317 for historical context.
2019-02-02 12:39:31 +11:00
Michael Gratton
4c7d98a1e3 Unb0rk use of iterator API
Fixes inline parts occasionally showing up as attachments.
2019-02-02 12:39:31 +11:00
Michael Gratton
f0418d0477 Rework sending ClientWebView sending preferred height from JS, again
Don't allow any preferred heigh updates to be sent until DOM has been
fully loaded and manupliated (in particular by ConversaionWebView) so
it is vaugely correct when first resized and takes a collapsed quote
heights into account.
2019-02-02 12:39:31 +11:00
Michael Gratton
eef1e0954f Don't bother queuing resizs for conversation messages when expanding
They won't have had their bodies loaded, so it's pointless.
2019-02-02 12:39:31 +11:00
Michael Gratton
7bc878e6cf Remove obsolete comment 2019-02-02 12:39:31 +11:00
Michael Gratton
b5e5a22728 Remove uused ClientWebView.has_valid_height property 2019-02-02 12:39:31 +11:00
Michael Gratton
9420334bee Don't try re-downloading email bodies on time-out
Replay queue handles that automatically (although it probably
shouldn't).
2019-02-02 12:39:31 +11:00
Michael Gratton
4a9baaa51b Further refine email body loading progress feedback 2019-02-02 12:39:31 +11:00
Michael Gratton
32602ba8f4 Refine auto-mark-read to only happen as a direct result of user action
This makes email automatically marked as read if the user performs an
action (select or scroll), and not if e.g. a message is simply appended
to the visible conversation.

Fixes #80
2019-02-02 12:39:31 +11:00