Commit graph

4333 commits

Author SHA1 Message Date
Jakub Steiner
b4255c7124 icon: update app icon
- GNOME 3.32 redesign of app icons.
  See https://gitlab.gnome.org/GNOME/Initiatives/issues/2
  for more info.

/label ~"9. Initiative: AppIconRedesign"
2019-02-21 11:12:33 +01:00
Jiri Grönroos
be9f976ef6 Update Finnish translation 2019-02-21 08:26:04 +00:00
Michael Gratton
fbf2f3072f Merge branch 'wip/fix-not-prompting-for-missing-password' into 'master'
Fix not refreshing missing credential tokens

Closes #249

See merge request GNOME/geary!128
2019-02-21 03:51:01 +00:00
Michael Gratton
c552633adb Prompt when loading a libsecret token but it could not be found
Fixes #249 for local accounts.
2019-02-21 14:35:21 +11:00
Michael Gratton
f59fdd050a Ensure AccountInformation load credentials methods always (re)load them
This prevents exising-but-expired tokens preventing new tokens from
being loaded.

Fixes #249 for GOA accounts
2019-02-21 14:35:05 +11:00
Michael Gratton
7e868dd06b Minor API doc update 2019-02-21 14:26:51 +11:00
Michael Gratton
eb1aa4c31f Ensure IMAP and SMTP services notify of auth failure if creds incomplete
This avoids attemting to connect and login when we know it is going to
fail.
2019-02-21 14:26:29 +11:00
Michael Gratton
e6a5563bee Flip the sense of the libunwind build option
Updates !109, see also #238
2019-02-21 14:26:29 +11:00
Michael Gratton
b0133b611a Merge branch 'wip/update-libunwind-build-option' into 'master'
Flip the sense of the libunwind build option

See merge request GNOME/geary!127
2019-02-21 01:14:54 +00:00
Michael Gratton
8a3649952e Merge branch 'wip/225-gmime-charset-crash' into 'master'
Fix crash in Geary.RFC822.init()

Closes #225

See merge request GNOME/geary!125
2019-02-21 01:14:46 +00:00
Michael Gratton
288178b581 Merge branch 'wip/248-no-compiser-from-without-aliases' into 'master'
Show From field in paned composer when other accounts exist

Closes #248

See merge request GNOME/geary!126
2019-02-21 01:12:24 +00:00
Michael Gratton
ee86739373 Flip the sense of the libunwind build option
Updates !109, see also #238
2019-02-21 12:03:11 +11:00
Michael Gratton
064e926ba4 Show From field in paned composer when other accounts exist
If an account was selected that did not have any aliases and a new
composer was opened, the From field would be missing, even if there was
another account.

Fixes #248
2019-02-21 11:39:20 +11:00
Michael Gratton
e06ec5e73e Fix crash in Geary.RFC822.init()
Due to an undocumented expectation in GMime.set_user_charsets(), the
array passed in must be null-terminated.

Fixes #225
2019-02-21 11:07:30 +11:00
Michael Gratton
c62a22abe8 Fix incorrect string format causing crashes on 32-bit systems
Fixes #252
2019-02-21 10:38:23 +11:00
Michael Gratton
579c6d3b5e Merge branch 'compose-message' into 'master'
Add missing tooltip for compose message button

See merge request GNOME/geary!124
2019-02-20 23:30:45 +00:00
Michael Gratton
22ed4a5fd0 Merge branch 'issue-226' into 'master'
Fix problems editing sender names in account editor

Closes #226

See merge request GNOME/geary!123
2019-02-20 23:28:15 +00:00
Rafael Fontenelle
6d7c1657ca Update Brazilian Portuguese translation
(cherry picked from commit d6ddc21ae1d1c5ce321fc0a0a118ebb30de1d366)
2019-02-20 23:06:40 +00:00
Balázs Úr
973bc04f73 Update Hungarian translation 2019-02-20 21:38:58 +00:00
Balázs Úr
6b4f2d4bb5 Update Hungarian translation
(cherry picked from commit 12afc9cb867f7dcabf4a102b6aa2e5fc91405b62)
2019-02-20 21:33:49 +00:00
Piotr Drąg
98606a77d0 Update Polish translation 2019-02-20 21:15:50 +01:00
Kristian Klausen
843c31db74 Fix UpdateMailboxCommand to work correctly when there is only a single mailbox
This commit update UpdateMailboxCommand to use a new function
("replace_sender") to replace a existing mailbox, instead of
remove/insert, which doesn't work if the number of mailboxes is 1.

This fix two bugs (if number of mailboxes is 1):
1. The "name" couldn't be updated.
2. If you did change the address, the old mailbox wasn't removed.

See also #226
2019-02-20 17:39:29 +01:00
Kristian Klausen
cb6611ea70 Fix "Sender name" couldn't be changed without editing the address
Fix #226
2019-02-20 17:37:45 +01:00
Kristian Klausen
31919cb4ca Add missing tooltip for compose message button 2019-02-20 16:39:37 +01:00
Michael Gratton
02692466cd Fix inifinite loop removing folders that have disappeared
Brown paper bag misuse of BidiIterator 🙄
2019-02-20 21:43:48 +11:00
Michael Gratton
6a8f8a1594 Merge branch 'wip/219-unbreak-sroll-vector-expansion' into 'master'
Unbreak folder vector expansion on scrolling the conversation list to the bottom

Closes #219

See merge request GNOME/geary!122
2019-02-20 10:14:21 +00:00
Michael Gratton
2b2f99d117 Fix FillWindowOperation not expanding vector when at end of it
This ensure that if a call to MinimalFolder.list_email_by_id() includes
a non-null initial_id, that its UID is always looked up. This fixes a
bug where if it is called with an initial ID, going newest to oldest,
and the id is the earliest email in the vector, no expansion will take
place.

This was occurring when scrolling the conversation list to the bottom,
and the ConversationMonitor had already reached the bottom of the
vector, so the fill op was trying to expand it. Since the last message
in the vector was given as the initial_id, but the fill op does not set
INCLUDE_ID, the UID for that email was never found. That caused the
vector expansion to use the end of the vector as the upper UID instead
of the this email at the start of the vector, and hence the lower UID
of the expansion was usually after the start of the vector, since
there's usally more messages in the vector than the fill op was
requesting. Thus no vector expansion actually took place, since the
lower and upper bounds were already included within the vector, and
hence no new messages were loaded by the fill op.

Fixes #219
2019-02-20 20:00:20 +11:00
Michael Gratton
9378795d4d Trivial code cleanup 2019-02-20 19:59:59 +11:00
Michael Gratton
f7f69e9e41 Fix one very wrong word in a comment
Per the Geary.Folder.list_email_by_id API docs, if the initial UID is a
vector expansion is wrong, it defaults to the end of the *vector*, not
the remote.
2019-02-20 19:57:34 +11:00
Michael Gratton
5e886534b1 Merge branch 'wip/244-save-sent-ui-missing' into 'master'
Add save sent email account pref UI back

Closes #244

See merge request GNOME/geary!120
2019-02-20 03:31:44 +00:00
Michael Gratton
45f53ef312 Add save sent email account option when needed
Save sent email was sadly forgotten during the account editor rewrite.
This adds it back.

Fixes #244
2019-02-20 14:07:13 +11:00
Michael Gratton
4d57ab9b62 Default Outlook accounts to not save sent mail
See #65
2019-02-20 14:06:02 +11:00
Michael Gratton
5475290272 Allow both accounts and services to have provider-specific defaults
This updates both AccountInformation and ServiceInformation to
implicitly apply provide-specific defaults, allowing the same
mechanism to provide defaults for accounts, and meaning that API
clients do not need to do this themselves any more. Add unit tests.
2019-02-20 13:55:17 +11:00
Michael Gratton
8081f46621 Merge branch 'optional_libunwind' into 'master'
Allow to opt-out from using libunwind.

See merge request GNOME/geary!109
2019-02-20 01:43:47 +00:00
Michael Gratton
ac6c369d23 Merge branch 'wip/ubuntu-1804-network-unreachable' into 'master'
Ubuntu 18.04 network unreachable

Closes #217

See merge request GNOME/geary!112
2019-02-20 00:46:18 +00:00
Michael Gratton
3914593360 Fix "Peer sent fatal TLS alert: Decode error" on Ubuntu 18.04
Setting an explicit TLS server identity seems to be broken on the
version of GLib shipped by Ubutnu 18.04, so disable for now.
2019-02-20 10:35:37 +11:00
Daniel Mustieles
3106db7414 Updated Spanish translation 2019-02-19 16:02:59 +01:00
Thomas Moschny
b120525fd6 Turn the 'libunwind' build option into a boolean. 2019-02-19 15:40:10 +01:00
Daniel Mustieles
7f0807073d Update Spanish translation
(cherry picked from commit 8d4016499630ea0e25dbe369c8556954564328c6)
2019-02-19 14:06:35 +00:00
Michael Gratton
25887e5350 Merge branch 'wip/224-subfolders-missing' into 'master'
Subfolders missing

Closes #224

See merge request GNOME/geary!118
2019-02-19 11:07:42 +00:00
Michael Gratton
b7739634ac Merge branch 'wip/227-validation-timeout' into 'master'
Use a substantially lower socket timeout when validating services

Closes #227

See merge request GNOME/geary!119
2019-02-19 07:20:18 +00:00
Michael Gratton
a268615df1 Use a substantially lower socket timeout when validating services
This avoids leaving the user hanging too long when adding/updating
accounts.

Fixes #227
2019-02-19 18:10:43 +11:00
Michael Gratton
af676e0572 Fix FolderPath mis-sorting doubly-disjoint paths
E.g. a>d should be less than b>c, not the other way around.

Fixes #224
2019-02-19 17:31:11 +11:00
Michael Gratton
3aebb98c9c Tidy up how accounts pass sorted sets of folders around
If the collection of folders is sorted, require it be stored in a sorted
collection.
2019-02-19 17:31:11 +11:00
Michael Gratton
087a088809 Merge branch 'wip/workaround-gcc150-b0rkedness' into 'master'
Work around DB tests always failing on gcc150.osuosl.org CI runner

See merge request GNOME/geary!114
2019-02-19 06:30:26 +00:00
Michael Gratton
b3b44ccd42 Work around DB tests always failing on gcc150.osuosl.org CI runner
See Infrastructure/Infrastructure#97
2019-02-19 17:12:26 +11:00
Michael Gratton
22c09e8bb5 Merge branch 'wip/228-signature-not-enabled' into 'master'
Fix new signatures added via the account editor not being used

Closes #228

See merge request GNOME/geary!113
2019-02-19 03:19:03 +00:00
Michael Gratton
963882d816 Merge branch 'wip/236-return-of-the-menubar' into 'master'
Fix the MainWindow's menu bar showing up again

Closes #236

See merge request GNOME/geary!115
2019-02-19 03:18:25 +00:00
Michael James Gratton
6e5d85a32b Revert "Fix main window showing a menubar under earlier GTK versions."
This reverts commit 062f8205a2.
2019-02-19 14:07:52 +11:00
Michael Gratton
b69fec8608 Fix the MainWindow's menu bar showing up again.
Hiding it regardless of the GtkSetting now seems to need to happen in
the GtkWindow constructor.

Fixes #236
2019-02-19 14:06:22 +11:00