Previously, we were taking folder names as they came off the wire.
Turns out IMAP specifies that folder names with 8 bit code points are
encoded in a crazy scheme unique to IMAP. Now, we properly decode that
scheme to the correct UTF-8 folder names to be displayed to the user.
There's also now a database upgrade path that converts all existing
mailboxes to the decoded version, so your existing database should just
keep working.
This doesn't solve #6205, as other unknown responses can cause this
problem as well, but it does fix this for the most-commonly reported
cause of this issue, MYRIGHTS.
We were presenting the main window with an erroneous timestamp, which
was causing composer windows to be created with an incorrect z order.
This presents the window without a timestamp, so there's no room for
error.
In some window managers, windows that display dialogs aren't
automatically presented. This manually presents the window before it
pops up the dialog, to keep behavior consistent.
* "Reply To" now labelled "Reply"
* Toolbar overflow menu labels no longer say "translated"
* .desktop file contains keywords
* For generic servers, "Remember password" now says "Remember passwords"
Ticket #6227 looks like a single problem, but in fact Tiago identified
it as two. Before this patch, the ComposerWindow assumed all prefilled
messages were either replies or forwards and prepended whitespace to
separate the user's message from the replied-to/forwarded one. This
is not the case with mailto: body's, which should be entered as-is to
a newly composed message.
There still exists #6227's issue with newlines not being inserted from
a mailto: link. That's enough of a side case we're committing this
now, as it's more common.
There's now a list of inboxes at the top of the sidebar if you have more
than one account. It gets the default selection if possible, so you
never have to see all the folders of your accounts if you work entirely
out of your inbox.
Some of the less-frequently used special folders have moved into a new
"More" grouping above "Labels". This keeps down the clutter for people
with lots of accounts.
Squashed commit of the following:
commit 647795e03e8b4d88df0f629b15416ff574fcda4a
Merge: 72515c2 4d2d304
Author: Charles Lindsay <chaz@yorba.org>
Date: Tue Feb 12 18:13:10 2013 -0800
Merge branch 'master' into special-subfolders
commit 72515c29ad8e1b1cc0bd653292fc9cf7a8665b27
Author: Charles Lindsay <chaz@yorba.org>
Date: Tue Feb 12 18:11:17 2013 -0800
Clean up
commit 8549a5d69b65969fc5d4d515f55f44cb98597b71
Author: Charles Lindsay <chaz@yorba.org>
Date: Tue Feb 12 12:02:49 2013 -0800
Add "More" grouping to sidebar
Squashed commit of the following:
commit d1f485ef349128ac33915e12622efb3d9d849659
Author: Eric Gregory <eric@yorba.org>
Date: Fri Feb 8 14:54:03 2013 -0800
Replaced AccountInformation.pretty_print() with AccountInformation.get_mailbox_address()
We now use a small timer when you click a folder before we actually kick
off a network connection. This effectively rate-limits how many
connections we make without significantly degrading the user experience.
Also we know that the folder selection function is not safely reentrant,
so that logic happens inside a mutex lock now.
The rate-limiting folder selection part is not an ideal solution, but
it's close to what we want (ideally, local results would be shown
immediately). However, the mutex lock is just a bandaid over the larger
problem of how much global state we juggle in the controller.
Squashed commit of the following:
commit 44e46663bb9b513970e11a62428834668987bf33
Author: Charles Lindsay <chaz@yorba.org>
Date: Wed Feb 6 17:29:22 2013 -0800
Comment our mutex lock
commit d951204aa163c73ed60b51368fa900ad6414046c
Author: Charles Lindsay <chaz@yorba.org>
Date: Wed Feb 6 16:59:32 2013 -0800
Select folders only after a small timeout
commit 012097139bfbaa76967667b8fcdd324634cc2506
Author: Charles Lindsay <chaz@yorba.org>
Date: Wed Feb 6 11:11:30 2013 -0800
Fix reentrancy issues using mutex
This adds an account property to the composer window. We had been using
the current account, which was problematic if you opened the window,
switched to a folder on a different account, then hit send.
This also adds a signal disconnection I had missed with my previous
commit.
Squashed commit of the following:
commit d874ef81011342081258ce7ad3a9e43df8bed1a7
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 31 17:58:35 2013 -0800
Simplify, from CR
commit f05f6f0e9ea86015f6ae1d6715340bb2fc8a4f87
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 31 17:44:37 2013 -0800
Add previously-missing signal disconnect
commit 72981633bc8b104215d64e802ed5de9a4860a320
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 31 17:45:34 2013 -0800
Change sidebar when nickname changes
commit fcc4d989a4a65d28e7e1d3c3df09075029430c5f
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 31 17:45:20 2013 -0800
Use nickname instead of email address in sidebar
Lots has been changed here. See the bug report
<http://redmine.yorba.org/issues/6230> for some of the discussion about
it.
This also fixes#6274. I'll cut the list of revisions off after a
while, because this branch has been outstanding for a couple weeks.
Squashed commit of the following:
commit ae505d89e87e63e0d8949bfd901913706a9d3b73
Merge: 81ef002 e18bef9
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 31 15:16:17 2013 -0800
Merge branch 'master' into multiple-accounts
commit 81ef002f5ff486b9c28f5663a0ba1e7392b8489c
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 31 15:15:51 2013 -0800
Fix final round of code review
commit 6935b1e7892b9b356bf5006b89e0b2a4e6a8ad16
Merge: c9ed434 a9dc52b
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 31 14:45:46 2013 -0800
Merge branch 'master' into multiple-accounts
commit c9ed434fe936e6aed735baef222ae615364c2513
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 31 14:31:02 2013 -0800
Simplify folder comparator
commit 28ac020cfd9135c6eb4ed05574c82b92f99c4a40
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 31 14:06:55 2013 -0800
Bump up declaration to conform to guidelines
commit 0a8167bdaebd5fac1c3ca791de5f2cc233c13cb9
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 31 13:54:03 2013 -0800
Rename back to list_*folders
commit 31457f60298052bdddba8e426db27f93d7c72529
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 31 12:36:15 2013 -0800
Fix spacing, brevity issues
commit ecd30c203d80c21c1ca1234b8911b57efcb68294
Author: Charles Lindsay <chaz@yorba.org>
Date: Wed Jan 30 17:56:29 2013 -0800
Fix nits before review
commit 85b51d71e83115991cd9a54d491b4d45b71f2f9b
Merge: b29abce d538bf0
Author: Charles Lindsay <chaz@yorba.org>
Date: Wed Jan 30 17:46:19 2013 -0800
Merge branch 'master' into multiple-accounts
commit b29abceeaea84f226ab9bcd22266a511691d8005
Author: Charles Lindsay <chaz@yorba.org>
Date: Wed Jan 30 17:22:28 2013 -0800
Fix notifications
commit c26d975fb0859d807ddb7f7c10632605c3b6fb1c
Author: Charles Lindsay <chaz@yorba.org>
Date: Wed Jan 30 13:01:03 2013 -0800
Only show current acct. folders in copy/move menus
commit 9a5b57db1229a079f11f518c53f5762a3670b83f
Author: Charles Lindsay <chaz@yorba.org>
Date: Wed Jan 30 11:48:05 2013 -0800
Fix issue where wrong mail would show in folders
commit 3b05d18843584c2aff7472708eea30ce24068043
Author: Charles Lindsay <chaz@yorba.org>
Date: Wed Jan 30 11:18:38 2013 -0800
Fix ordering of folders in side bar
commit b228967b6a74c16698d593e53e65d66c69ffb974
Author: Charles Lindsay <chaz@yorba.org>
Date: Wed Jan 30 11:07:32 2013 -0800
Add icon to accounts in sidebar
commit dd05d2c987a46f0b6699d743c339297e06829e4f
Author: Charles Lindsay <chaz@yorba.org>
Date: Tue Jan 29 19:04:52 2013 -0800
Fix Labels icon
commit b5254fe8f6ef37df48d41167d0f52f3cd88d1966
Author: Charles Lindsay <chaz@yorba.org>
Date: Tue Jan 29 18:43:45 2013 -0800
Initial stab at new FolderList; fix compile errors
commit ff591810ee4312acce208dfa36d993069bc4c7d2
Merge: 2b9dbb9 ff5f9fa
Author: Charles Lindsay <chaz@yorba.org>
Date: Mon Jan 28 17:42:34 2013 -0800
Merge branch 'master' into multiple-accounts
commit 2b9dbb9b6963b1d52b2b90300bcea277b01d2094
Merge: 7583241 fcfb460
Author: Charles Lindsay <chaz@yorba.org>
Date: Mon Jan 28 17:21:49 2013 -0800
Merge branch 'master' into multiple-accounts
Conflicts:
src/client/geary-controller.vala
commit 75832412cc806c956848e32ef20052af36d4f64d
Author: Charles Lindsay <chaz@yorba.org>
Date: Mon Jan 28 16:37:15 2013 -0800
Fix IMAP sess. mgr. to recover from bad passwords
commit 8868b4be5c3f5c97246d35c6170531c6f543abe1
Author: Charles Lindsay <chaz@yorba.org>
Date: Mon Jan 28 12:06:21 2013 -0800
Typo
commit 3f909054502d31ca48e11f7948fd22118afe7514
Author: Charles Lindsay <chaz@yorba.org>
Date: Mon Jan 28 10:54:51 2013 -0800
Clean up interface a little
commit 3bfb526fe8801f8234127944be8594a960ccf7e7
Merge: 5e84e93 e971275
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 25 16:23:52 2013 -0800
Merge branch 'master' into multiple-accounts
Conflicts:
src/client/geary-application.vala
src/engine/api/geary-engine.vala
commit 5e84e9375a655567a3bc4eb7ebaacab2d218be40
Merge: 35cc46b 9167aeb
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 25 16:17:00 2013 -0800
Merge branch 'pluggable-auth' into multiple-accounts
Conflicts:
src/engine/api/geary-engine.vala
commit 9167aeb56be6789d49a3e7cdba2a21d2b015e40d
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 25 16:11:20 2013 -0800
Fix for code guidelines
commit 35cc46bc99f44f1597c609bfeaa72dd503333a17
Merge: 9675f47 7612a7d
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 25 15:44:18 2013 -0800
Merge branch 'pluggable-auth' into multiple-accounts
Conflicts:
src/client/geary-application.vala
commit 7612a7ddc3df14ef207b9e74ee32fa23710e1ce9
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 25 15:26:48 2013 -0800
Fix code review issues
commit 46635544c98df7a8b6c76f028715814907274389
Merge: 30b611e 6de36ae
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 25 12:54:03 2013 -0800
Merge branch 'master' into pluggable-auth
commit 9675f473e77d0d581cf73a33012981e6a4f44943
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 25 12:53:18 2013 -0800
Try to make Folder know about its Account
commit 5d9af43e53199a616490cf6ff98bd3c613b4e5f2
Merge: 335480e 6de36ae
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 25 12:12:21 2013 -0800
Merge branch 'master' into multiple-accounts
commit 335480e2dd0261c8fb82f1c6296f5b8c76f3ac02
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 25 12:11:18 2013 -0800
Work on multiple accounts; fix compilation errors
commit 808e65d55798e3f08b4c70992718cc11befbb45c
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 24 19:28:12 2013 -0800
Fix application logic for multiple accounts
You get the idea.
Squashed commit of the following:
commit ffa4f1d611148ffc2a6a8f00b1d113b19870409c
Author: Eric Gregory <eric@yorba.org>
Date: Wed Jan 30 18:59:38 2013 -0800
Fix for spinner on welcome screen
This has been a problem in the past, and it usually has to do with
shutting down the ClientSession or ClientConnection while connecting.
That is true here too. (In this case, it's due to the request being
cancelled while connecting.) This uses the ClientSession's FSM's to
better deal with the case and move the ClientSession to a BROKEN
state where it belongs. There's also some code in ClientConnection
to ensure that if connect_async() fails, no resource leaks occur.
Squashed commit of the following:
commit 6ea008fef96bc5d4b141c4735dc90e629d04675d
Author: Eric Gregory <eric@yorba.org>
Date: Mon Jan 28 12:00:55 2013 -0800
Add missing glade files to install
Squashed commit of the following:
commit e7af3b721314513fc6ea2eb57d10086e4f1e148b
Author: Eric Gregory <eric@yorba.org>
Date: Mon Jan 28 16:53:56 2013 -0800
Account dialog is back to being modal
commit cdd214070e67dc735c819df06c46a1d128ef20d2
Author: Eric Gregory <eric@yorba.org>
Date: Fri Jan 25 18:14:17 2013 -0800
Fix for password issue
commit 847da391373357bbca90ef6d8028ea8ff85458f1
Author: Eric Gregory <eric@yorba.org>
Date: Fri Jan 25 17:20:12 2013 -0800
Merging in changes
commit 7745ac1426fb8560624fed752de0ee162f97bd9e
Author: Eric Gregory <eric@yorba.org>
Date: Fri Jan 25 15:53:49 2013 -0800
Changes from code review
commit d7727544aaeacceb5c9b0ac3444a6db0311929db
Author: Eric Gregory <eric@yorba.org>
Date: Thu Jan 24 17:10:18 2013 -0800
Account editing, various account management bug fixes
Squashed commit of the following:
commit 9167aeb56be6789d49a3e7cdba2a21d2b015e40d
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 25 16:11:20 2013 -0800
Fix for code guidelines
commit 7612a7ddc3df14ef207b9e74ee32fa23710e1ce9
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 25 15:26:48 2013 -0800
Fix code review issues
commit 46635544c98df7a8b6c76f028715814907274389
Merge: 30b611e 6de36ae
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 25 12:54:03 2013 -0800
Merge branch 'master' into pluggable-auth
commit 30b611ed415fe7a2c1d62746f94620132ec86623
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 24 17:12:24 2013 -0800
Only prompt for IMAP password on startup
commit ca2953b4b33cb367c060164df9f2258217e94046
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 24 16:34:39 2013 -0800
Fix compile errors; cleanup
commit 545764a6a914ff36a1ca187444d0830a28502bab
Merge: 0460a68 e498354
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 24 16:31:43 2013 -0800
Merge branch 'master' into pluggable-auth
Conflicts:
src/client/geary-application.vala
commit 0460a68af4de3e762522fd641c16675cfc7d2241
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 24 16:20:31 2013 -0800
Use Engine's mediator implicitly
commit 22cbb8740e711ca3151b0389aef9cbb8c21928c7
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 24 16:19:55 2013 -0800
Use flags on things that are supposed to be flags
commit 4dc0eb15d2fe23c92d8cc6cff8a3138b6cb1baf4
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 24 15:49:50 2013 -0800
Fix prompting in certain cases
commit 56bb2265a6635a754b9a00b469ec457105390896
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 24 14:37:12 2013 -0800
Fix typo
commit 926f47024f1280271bc36cd8c60eb948bed4a432
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 24 11:43:05 2013 -0800
Cleanup, compile, smoke test
commit 9ff4257d125e67828f0c813e0806d3d34c114550
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 18 10:41:17 2013 -0800
First stab at new pluggable auth API
