Commit graph

4686 commits

Author SHA1 Message Date
Michael Gratton
204bf19e63 Merge branch 'menu-icon-fix' into 'mainline'
Change conversation menu icon to view-more

See merge request GNOME/geary!211
2019-04-19 03:14:26 +00:00
Christopher Davis
d4436fa372 main-toolbar: Use a full-height, splitting separator
Previously we used a separator in the middle of the main toolbar and extended the width of the HeaderBar in order to
special case for Ambiance.

Ambiance is no longer the default Ubuntu theme, and sticking
with GNOME design patterns should be prioritized over
special casing with a theme.

Fixes https://gitlab.gnome.org/GNOME/geary/issues/389
2019-04-18 16:31:41 -04:00
Tobias Bernard
de5df79184 ui: change conversation menu icon to view-more 2019-04-18 13:51:44 +02:00
Michael Gratton
4238994694 Merge branch 'wip/nielsdg/folks-meson' into 'mainline'
flatpak: Build folks with meson

See merge request GNOME/geary!210
2019-04-17 22:48:15 +00:00
Michael Gratton
58f652671a Merge branch 'service-typo' into 'mainline'
correct typo in the dbus service file

See merge request GNOME/geary!209
2019-04-17 22:38:49 +00:00
Niels De Graef
1eb5dd1076 flatpak: Build folks with meson
Folks recently gained support for the Meson build system, so use that
instead of autotools. This should make the build faster and more
future-proof (since the autotools build might not survive for long).
2019-04-18 00:22:15 +02:00
Jiří Černý
c208f35f80 correct typo in the dbus service file 2019-04-17 14:04:38 +02:00
Michael Gratton
0aea07f457 Merge branch 'wip/766133-gnotification' into 'mainline'
Switch from libnotify to GNotification

See merge request GNOME/geary!205
2019-04-16 23:29:07 +00:00
Michael Gratton
2e0ee8cae8 Ensure notifications are cleared on app activation
Clear both new mail and send mail error notifications on activate, since
in the case of the former the new mail will be selected, and in the
case of the latter an error info bar will be displayed in the main
window.
2019-04-17 09:06:24 +10:00
Michael Gratton
b80f6b0db4 Minor fix for MockObject 2019-04-17 09:06:24 +10:00
Michael Gratton
bb1fe538fd Implement application actions for notifications
Adds show-email and show-folder folder actions to allow default actions
for notifications to reveal new email in main windows.
2019-04-17 09:06:24 +10:00
Michael Gratton
f7488453d0 Make it easier to obtain folders from path objects from Geary.Account
Replace async folder accessors with sync versions, add a means of
obtaining a folder path from its serialised form.
2019-04-17 09:06:24 +10:00
Michael Gratton
01a154bc5f Make it possible to distinguish between different folder roots
Add a label to Geary.FolderRoot so it different instances can be
differenciated.
2019-04-17 09:06:24 +10:00
Michael James Gratton
dd3a7a1bc8 Add API for (de)serialising FolderPath and EmailIdentifier
Supports (de)serialising via GLib.Variant for use as GLib.Action targets
transmission via DBus, etc.
2019-04-17 09:06:24 +10:00
Michael Gratton
f269e552ae Don't play sounds when issuing a notifciation
We can't reliably play a sound when issuing a notification, since they
maybe disabled by the desktop. So let the desktop's notification system
handle that. As a result, move sound code to the controller since the
only place it is used now is when sending email.
2019-04-17 09:06:24 +10:00
Michael Gratton
3701aa0c30 Allow Notifications.Desktop to cancel its async tasks
Pass a cancellable when constructed and use that for async tasks.
2019-04-17 09:06:24 +10:00
Michael Gratton
ef21ad5611 Use app icon in notifications for consistency with other apps 2019-04-17 09:06:24 +10:00
Michael Gratton
c0f5be251b Clean up desktop notification code
Rename class to reflect what it does, rather than how it is implemented.
Modernise the code and make it fit with coding conventions better.
2019-04-17 09:06:24 +10:00
Niels De Graef
3d1032db01 Migrated from libnotify to GLib notifications. bug 766133
Signed-off-by: Niels De Graef <nielsdegraef@gmail.com>
2019-04-17 09:06:24 +10:00
Michael Gratton
49cd00fdc8 Minor code cleanup 2019-04-17 09:06:24 +10:00
Michael Gratton
8096555f63 Merge branch 'wip/fedora-ytnef' into 'mainline'
Disable ytnef in Fedora CI while the package there is too old

See merge request GNOME/geary!208
2019-04-16 14:12:45 +00:00
Michael Gratton
5c7c382ca5 Fix failing test when ytnef support disabled 2019-04-16 23:45:38 +10:00
Michael Gratton
25de4d3049 Disable ytnef in Fedora CI while the package there is too old 2019-04-16 23:11:19 +10:00
Michael Gratton
4497b1275a Merge branch 'tnef-support' into 'mainline'
TNEF (winmail.dat) parsing support via libytnef

See merge request GNOME/geary!10
2019-04-16 12:38:25 +00:00
Piotr Drąg
d6e6259f41 Update Polish translation
Fixes https://gitlab.gnome.org/Teams/Translation/pl/issues/2
2019-04-13 10:29:33 +02:00
Michael Gratton
ef71e4c4c2 Merge branch 'wip/775956-dbus-activation' into 'mainline'
Support DBus activation

See merge request GNOME/geary!204
2019-04-12 12:30:27 +00:00
Michael Gratton
40c98d5eb4 Fix handling of mailto command line args 2019-04-12 22:04:56 +10:00
Michael Gratton
3c1ae51e29 Minor code cleanup 2019-04-12 22:04:56 +10:00
Michael Gratton
6605682cc4 Add translation comments denoting command line option strings 2019-04-12 22:04:56 +10:00
Michael Gratton
2578c6c089 Re-implement --hidden as a deprecated command line option
When used, start hidden, but print a warning and update the autostart
file if needed so it doesn't get used again automatically.
2019-04-12 22:04:56 +10:00
Michael Gratton
5eb8d1452d Modernise autostart desktop file manager class a bit
Move it into the application namespace, give it a slightly more generic
name, move its instance from the controller to the application, and
modernise its source code.
2019-04-12 22:04:56 +10:00
Michael Gratton
bad2acec58 Fix some incorrect command line arg values, sort alphabetically 2019-04-12 22:04:56 +10:00
Michael Gratton
6f2187f5e2 Fully implement --quit
Ensure that -q also shuts down non-local instances.
2019-04-12 22:04:56 +10:00
Michael Gratton
d8e4c31256 Move command line processing into GearyApplication
Remove now-empty args namespace and source file.
2019-04-12 22:04:56 +10:00
Michael Gratton
7b861a224e Fix controller not being started when started as DBus service 2019-04-12 22:04:56 +10:00
Michael Gratton
548babc7bb Don't (necessarily) quit on Ctrl+W, just close the window 2019-04-12 22:04:56 +10:00
Michael Gratton
34e4b47396 Don't keep loading more conversations when started in background 2019-04-12 22:04:56 +10:00
Michael Gratton
3ae24d75b8 Update main window lifecycle management
Ensure main window is not shown when started as service, and is only hidden when closed
and the background startup pref is set.
2019-04-12 22:04:56 +10:00
Niels De Graef
9acf5d344d Make Geary DBus-activatable. Bug 775956.
* org.gnome.Geary.service.in: create, and let it be installed by CMake.

* org.gnome.Geary.desktop.in: add `DBusActivatable=true`.

* geary-autostart.desktop.in: use `--gapplication-service` instead of
hidden.

* Change the way arguments are parsed:
  * Use the _command-line_ and _handle-local-options_ signals instead
    of _local-command-line_.
  * Remove the `--hidden` option (replaced by `--gapplication-service`)
  * Use VariantDict (which is a little cleaner)
  * Don't use global variables in Arg, but set them in
  the config instead.
  * We can no longer set a global summary due to the new option handling
  in GApplication. On IRC, I got the feedback that info like this should
  be going into a manpage.

* Since the QUIT-action can now be called without ever activating the
app, make the necessary changes to the `GearyController`:
  * `main_window` and `current_conversations` can be null.
  * use `pending_mailtos()` for the compose action as well.
  * Don't update the UNDO action if we're closing down.

* More instance variables prefixed with this (we're changing the lines
anyway, might as well do it properly).

* `Environment.set_prgname()` is already executed in GApplication.run(),
so no more need for `GearyApplication.PRGNAME`.

Signed-off-by: Niels De Graef <nielsdegraef@gmail.com>
2019-04-12 22:04:56 +10:00
Michael Gratton
ddced6f6f4 Merge branch 'libm-dep' into 'mainline'
engine: add missing libm dependency

See merge request GNOME/geary!202
2019-04-11 23:18:38 +00:00
Kalev Lember
499eb22ef3 appdata: Keep the same app ID as in 0.13
Go back to using "org.gnome.Geary.desktop" as it was in 0.13. The
appdata spec is very clear that the app ID is not supposed to change and
should be a unique identifier for the app across distributions.
2019-04-12 01:09:03 +02:00
Greg V
6acddfd02c engine: add missing libm dependency
floor() is now used at rfc822-message-data.vala:213 via GLib.Math.floor
2019-04-11 19:36:19 +03:00
Oliver Giles
18fcf0e18f TNEF (winmail.dat) parsing support via libytnef 2019-04-11 12:24:52 +03:00
Michael Gratton
ef8f97628e Merge branch 'wip/remove-ci-test-workaround' into 'mainline'
Remove CI test workaround

See merge request GNOME/geary!198

(cherry picked from commit 8654c7ae136d2467f7b5b2e85a436d9039bd64bc)

4fc688de Revert "Work around DB tests always failing on gcc150.osuosl.org CI runner"
6b4b598a Add test runner multiplier to account for slow CI runners
2019-04-09 16:16:10 +00:00
Piotr Drąg
134eca3f7c Update POTFILES.in 2019-04-08 13:54:35 +02:00
Michael Gratton
6234405e4f Merge branch 'wip/geary-inspector' into 'mainline'
Add an Inspector to Geary

See merge request GNOME/geary!199
2019-04-08 09:26:05 +00:00
Michael Gratton
ae1e36e707 Fine tune Inspector filtering
Do a case-insensitive match, ignore empty strings, make matching words
conjunctive.
2019-04-08 18:05:03 +10:00
Michael Gratton
9c5dc14865 Use MainContext.invoke to handle appending new log messages
This ensures the correct approach is used, regardless of what thread
and context is currently executing.
2019-04-08 18:05:03 +10:00
Michael Gratton
e428d7b2cb Minor code tidy up 2019-04-08 18:05:03 +10:00
Michael Gratton
194ca0e273 Blacklist displaying certain annoying messages in the Inspector 2019-04-08 18:05:03 +10:00