John Lewin
|
b327b95e4a
|
Move settings dictionary into PrinterSettings
|
2019-01-06 13:19:01 -08:00 |
|
John Lewin
|
ae2da3b29c
|
Remove GetSettingsData method, use SettingsData dictionary
- Issue MatterHackers/MCCentral#4821
Consider removing SettingsOrganizer.Instance.GetSettingsData
|
2019-01-06 11:39:14 -08:00 |
|
John Lewin
|
c1c83a6641
|
Report correct validation field
- System should be revised to prevent this form of misreporting
|
2019-01-05 12:26:48 -08:00 |
|
John Lewin
|
14d9e98e52
|
Distinguish between error and value details
- Allow in context validation errors to skip redundant value reporting
|
2019-01-05 12:25:08 -08:00 |
|
John Lewin
|
6cd855b2e0
|
Inline temporary variables
|
2019-01-05 12:08:09 -08:00 |
|
John Lewin
|
220385d9ed
|
Always validate first_layer_height
|
2019-01-04 22:21:34 -08:00 |
|
John Lewin
|
fe49c138da
|
Simplify validation error reporting with conventions
- Add SettingsValidationError type with Location logic
|
2019-01-04 21:59:59 -08:00 |
|
John Lewin
|
e96f943cd0
|
Extract literal strings to SettingsKey
|
2019-01-04 21:46:22 -08:00 |
|
John Lewin
|
379e86c0e5
|
Inline local variable
|
2019-01-04 21:25:04 -08:00 |
|
John Lewin
|
b6767c6022
|
Revise naming
|
2019-01-04 21:24:35 -08:00 |
|
John Lewin
|
7fa590ffd6
|
Validate passed in field rather than hard-coded start_gcode
|
2019-01-04 21:23:36 -08:00 |
|
John Lewin
|
d6bcb515ce
|
Change SettingsValid to ValidateSettings extension method
|
2019-01-04 18:27:14 -08:00 |
|
John Lewin
|
b304519061
|
Simplify concatenation
|
2019-01-04 18:13:33 -08:00 |
|
John Lewin
|
a3cc4c8f96
|
Remove additional presentation data from validation errors
- Add location property
- Have caller concatenate Location with Details
|
2019-01-04 17:49:58 -08:00 |
|
John Lewin
|
063db01796
|
Reduce presentation data in validation errors
- Add ValidationError type to hold validation results
- Change validation to return lists of ValidationErrors
|
2019-01-04 17:09:42 -08:00 |
|
Lars Brubaker
|
34b57c43b0
|
Making error messages coming back as list
fixing regression with dialog window showing as markdown (there were
assumptions on it not being markdown)
|
2019-01-03 16:58:05 -08:00 |
|
Lars Brubaker
|
45b1a32e03
|
removing MS auto support generation
|
2019-01-03 16:05:02 -08:00 |
|
Lars Brubaker
|
5bdd81da1e
|
ensuring good slice settings
issue: MatterHackers/MCCentral#4641
Consider adding constraints to line lengths in gcode fields
|
2018-11-29 13:13:25 -08:00 |
|
John Lewin
|
2a2e052b53
|
Remove PrinterConfig reference from PrinterSettings
|
2018-11-25 09:07:44 -08:00 |
|
John Lewin
|
2abdf9484b
|
Extract settings validation from PrinterSettings
- Validation currently coupled to UI and MatterControl data
- Extracting to isolate dependencies
|
2018-11-25 09:07:43 -08:00 |
|