nettika/mattercontrol
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Concise queries, reduce to functionality

Browse source 
- Remove DataStorage qualifier, add using statements
 - Remove unnecessary query variables and string.formatting statements
 - Remove duplicate code, reuse .RecordCount method
This commit is contained in:
John Lewin 2016-02-23 11:15:03 -08:00
parent 473655c2ce
commit f8f70f46e6
16 changed files with 111 additions and 143 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Tests/MatterControl.Tests/MatterControl/LibraryProviderTests.cs
View file

@ -154,8 +154,7 @@ namespace MatterControl.Tests
private bool NamedCollectionExists(string nameToLookFor)
{
string query = string.Format("SELECT * FROM PrintItemCollection WHERE Name = '{0}' ORDER BY Name ASC;", nameToLookFor);
IEnumerable<PrintItemCollection> result = (IEnumerable<PrintItemCollection>)Datastore.Instance.dbSQLite.Query<PrintItemCollection>(query);
foreach (PrintItemCollection collection in result)
foreach (PrintItemCollection collection in Datastore.Instance.dbSQLite.Query<PrintItemCollection>(query))
{
if (collection.Name == nameToLookFor)
{
@ -169,8 +168,7 @@ namespace MatterControl.Tests
private bool NamedItemExists(string nameToLookFor)
{
string query = string.Format("SELECT * FROM PrintItem WHERE Name = '{0}' ORDER BY Name ASC;", nameToLookFor);
IEnumerable<PrintItem> result = (IEnumerable<PrintItem>)Datastore.Instance.dbSQLite.Query<PrintItem>(query);
foreach (PrintItem collection in result)
foreach (PrintItem collection in Datastore.Instance.dbSQLite.Query<PrintItem>(query))
{
if (collection.Name == nameToLookFor)
{