nettika/mattercontrol
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improving Package tool

Browse source 
Changing public property editor to be able to dynamically add new properties
This commit is contained in:
Lars Brubaker 2018-04-12 17:23:19 -07:00
parent fd713d5616
commit d6addaa45a
6 changed files with 450 additions and 385 deletions
Download patch file Download diff file Expand all files Collapse all files

12
DesignTools/Operations/Align3D.cs
View file

@ -423,12 +423,12 @@ namespace MatterHackers.MatterControl.DesignTools.Operations
public void UpdateControls(PublicPropertyEditor editor)
{
editor.GetEditRow(nameof(XAlignTo)).Visible = Advanced && XAlign != Align.Origin;
editor.GetEditRow(nameof(XOffset)).Visible = Advanced;
editor.GetEditRow(nameof(YAlignTo)).Visible = Advanced && YAlign != Align.Origin;
editor.GetEditRow(nameof(YOffset)).Visible = Advanced;
editor.GetEditRow(nameof(ZAlignTo)).Visible = Advanced && ZAlign != Align.Origin;
editor.GetEditRow(nameof(ZOffset)).Visible = Advanced;
editor.GetEditRow((this.ID, nameof(XAlignTo))).Visible = Advanced && XAlign != Align.Origin;
editor.GetEditRow((this.ID, nameof(XOffset))).Visible = Advanced;
editor.GetEditRow((this.ID, nameof(YAlignTo))).Visible = Advanced && YAlign != Align.Origin;
editor.GetEditRow((this.ID, nameof(YOffset))).Visible = Advanced;
editor.GetEditRow((this.ID, nameof(ZAlignTo))).Visible = Advanced && ZAlign != Align.Origin;
editor.GetEditRow((this.ID, nameof(ZOffset))).Visible = Advanced;
}
private static bool IsSet(Face variableToCheck, Face faceToCheckFor, Face faceToAssertNot)

89
DesignTools/Operations/Package3D.cs
View file

@ -1,33 +1,73 @@
using System;
using System.ComponentModel;
using System.Linq;
using System.Threading;
using MatterHackers.Agg.Font;
/*
Copyright (c) 2018, Lars Brubaker
All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
1. Redistributions of source code must retain the above copyright notice, this
list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
The views and conclusions contained in the software and documentation are those
of the authors and should not be interpreted as representing official policies,
either expressed or implied, of the FreeBSD Project.
*/
using MatterHackers.Agg.UI;
using MatterHackers.DataConverters3D;
using MatterHackers.VectorMath;
using MatterHackers.PolygonMesh;
using Newtonsoft.Json;
using System.Collections.Generic;
using System.Linq;
using System.Reflection;
namespace MatterHackers.MatterControl.DesignTools.Operations
{
public class Package3D : Object3D, IRebuildable
{
public string NameToWrite { get; set; }
public Package3D()
{
}
[JsonIgnore]
private SubProperties _subProperties = new SubProperties();
[JsonIgnore]
public SubProperties LiftedProperties
{
get
{
_subProperties.Items.Clear();
foreach (var child in this.Descendants<TextObject3D>())
{
PropertyInfo propertyToEdit = child.GetType().GetProperties().First();
_subProperties.Items.Add(new EditableProperty(propertyToEdit, child));
}
return _subProperties;
}
set
{
// only here so it will show up in PublicPropertyEditor
}
}
public static Package3D Create(IObject3D itemToPackage)
{
Package3D package = new Package3D();
var text = itemToPackage.Descendants<TextObject3D>().FirstOrDefault();
if (text != null)
{
package.NameToWrite = text.NameToWrite;
}
package.Children.Add(itemToPackage);
return package;
@ -35,23 +75,18 @@ namespace MatterHackers.MatterControl.DesignTools.Operations
public void Rebuild(UndoBuffer undoBuffer)
{
var text = this.Descendants<TextObject3D>().FirstOrDefault();
if (text != null)
foreach (var child in this.Descendants<TextObject3D>())
{
text.NameToWrite = this.NameToWrite;
text.Rebuild(null);
}
child.Rebuild(null);
var fit = this.Descendants<FitToBounds3D>().FirstOrDefault();
if (fit != null)
foreach (var parent in child.Parents<IObject3D>())
{
fit.Rebuild(null);
if (parent is IRebuildable rebuildable
&& parent != this)
{
rebuildable.Rebuild(null);
}
}
var align = this.Descendants<Align3D>().FirstOrDefault();
if (align != null)
{
align.Rebuild(null);
}
return;

226
DesignTools/PublicPropertyEditor.cs
View file

@ -46,6 +46,45 @@ using MatterHackers.VectorMath;
namespace MatterHackers.MatterControl.DesignTools
{
public class EditableProperty
{
public IObject3D Item { get; private set; }
public PropertyInfo PropertyInfo { get; private set; }
public EditableProperty(PropertyInfo p, IObject3D item)
{
this.Item = item;
this.PropertyInfo = p;
}
private string GetDescription(PropertyInfo prop)
{
var nameAttribute = prop.GetCustomAttributes(true).OfType<DescriptionAttribute>().FirstOrDefault();
return nameAttribute?.Description ?? null;
}
public static string GetDisplayName(PropertyInfo prop)
{
var nameAttribute = prop.GetCustomAttributes(true).OfType<DisplayNameAttribute>().FirstOrDefault();
return nameAttribute?.DisplayName ?? prop.Name.SplitCamelCase();
}
public object Value => PropertyInfo.GetGetMethod().Invoke(Item, null);
public string DisplayName => GetDisplayName(PropertyInfo);
public string Description => GetDescription(PropertyInfo);
public Type ptype => PropertyInfo.PropertyType;
}
public class SubProperties
{
public List<EditableProperty> Items = new List<EditableProperty>();
public virtual IEnumerable<EditableProperty> GetProperties()
{
foreach (var item in Items)
{
yield return item;
}
}
}
public class PublicPropertyEditor : IObject3DEditor
{
@ -57,14 +96,14 @@ namespace MatterHackers.MatterControl.DesignTools
public IEnumerable<Type> SupportedTypes() => new Type[] { typeof(IRebuildable) };
private Dictionary<string, GuiWidget> editRows = new Dictionary<string, GuiWidget>();
private Dictionary<(string id, string propertyName), GuiWidget> editRows = new Dictionary<(string id, string propertyName), GuiWidget>();
private static Type[] allowedTypes =
{
typeof(double), typeof(int), typeof(char), typeof(string), typeof(bool),
typeof(Vector2), typeof(Vector3),
typeof(DirectionVector), typeof(DirectionAxis),
typeof(ImageObject3D)
typeof(ImageObject3D), typeof(SubProperties)
};
private static Type IObject3DType = typeof(IObject3D);
@ -98,10 +137,10 @@ namespace MatterHackers.MatterControl.DesignTools
return mainContainer;
}
public GuiWidget GetEditRow(string propertyName)
public GuiWidget GetEditRow((string id, string propertyName) key)
{
GuiWidget value;
if (editRows.TryGetValue(propertyName, out value))
if (editRows.TryGetValue(key, out value))
{
return value;
}
@ -130,35 +169,7 @@ namespace MatterHackers.MatterControl.DesignTools
return rowContainer;
}
public static string GetDisplayName(PropertyInfo prop)
{
var nameAttribute = prop.GetCustomAttributes(true).OfType<DisplayNameAttribute>().FirstOrDefault();
return nameAttribute?.DisplayName ?? prop.Name.SplitCamelCase();
}
public class EditableProperty
{
public Object Item { get; private set; }
public PropertyInfo PropertyInfo { get; private set; }
public EditableProperty(PropertyInfo p, object item)
{
this.Item = item;
this.PropertyInfo = p;
}
private string GetDescription(PropertyInfo prop)
{
var nameAttribute = prop.GetCustomAttributes(true).OfType<DescriptionAttribute>().FirstOrDefault();
return nameAttribute?.Description ?? null;
}
public object Value => PropertyInfo.GetGetMethod().Invoke(Item, null);
public string DisplayName => GetDisplayName(PropertyInfo);
public string Description => GetDescription(PropertyInfo);
public Type ptype => PropertyInfo.PropertyType;
}
public static IEnumerable<EditableProperty> GetEditablePropreties(Object item)
public static IEnumerable<EditableProperty> GetEditablePropreties(IObject3D item)
{
return item.GetType().GetProperties(OwnedPropertiesOnly)
.Where(pi => (allowedTypes.Contains(pi.PropertyType) || pi.PropertyType.IsEnum)
@ -181,6 +192,31 @@ namespace MatterHackers.MatterControl.DesignTools
AddUnlockLinkIfRequired(editControlsContainer, theme);
foreach (var property in editableProperties)
{
AddPropertyEditor(this, view3DWidget, editControlsContainer, theme, undoBuffer, rebuildable, propertyGridModifier, property, editRows);
}
var hideUpdate = item.GetType().GetCustomAttributes(typeof(HideUpdateButtonAttribute), true).FirstOrDefault() as HideUpdateButtonAttribute;
if (hideUpdate == null)
{
var updateButton = theme.ButtonFactory.Generate("Update".Localize());
updateButton.Margin = new BorderDouble(5);
updateButton.HAnchor = HAnchor.Right;
updateButton.Click += (s, e) =>
{
rebuildable?.Rebuild(undoBuffer);
};
editControlsContainer.AddChild(updateButton);
}
// make sure the ui is set right to start
propertyGridModifier?.UpdateControls(this);
}
private static void AddPropertyEditor(PublicPropertyEditor publicPropertyEditor,
View3DWidget view3DWidget, FlowLayoutWidget editControlsContainer, ThemeConfig theme,
UndoBuffer undoBuffer, IRebuildable rebuildable, IPropertyGridModifier propertyGridModifier,
EditableProperty property, Dictionary<(string id, string propertyName), GuiWidget> editRows)
{
GuiWidget rowContainer = null;
@ -194,14 +230,24 @@ namespace MatterHackers.MatterControl.DesignTools
field.DoubleValue = doubleValue;
field.ValueChanged += (s, e) =>
{
property.PropertyInfo.GetSetMethod().Invoke(this.item, new Object[] { field.DoubleValue });
property.PropertyInfo.GetSetMethod().Invoke(property.Item, new Object[] { field.DoubleValue });
rebuildable?.Rebuild(undoBuffer);
propertyGridModifier?.UpdateControls(this);
propertyGridModifier?.UpdateControls(publicPropertyEditor);
};
rowContainer.AddChild(field.Content);
editControlsContainer.AddChild(rowContainer);
}
else if (property.Value is SubProperties subProperties)
{
foreach(var subProperty in subProperties.GetProperties())
{
AddPropertyEditor(publicPropertyEditor, view3DWidget, editControlsContainer, theme, undoBuffer,
rebuildable, propertyGridModifier, subProperty, editRows);
}
// don't add a row, they were added for the individual properties
return;
}
else if (property.Value is Vector2 vector2)
{
rowContainer = CreateSettingsRow(property.DisplayName.Localize());
@ -211,9 +257,9 @@ namespace MatterHackers.MatterControl.DesignTools
field.Vector2 = vector2;
field.ValueChanged += (s, e) =>
{
property.PropertyInfo.GetSetMethod().Invoke(this.item, new Object[] { field.Vector2 });
property.PropertyInfo.GetSetMethod().Invoke(property.Item, new Object[] { field.Vector2 });
rebuildable?.Rebuild(undoBuffer);
propertyGridModifier?.UpdateControls(this);
propertyGridModifier?.UpdateControls(publicPropertyEditor);
};
rowContainer.AddChild(field.Content);
@ -228,9 +274,9 @@ namespace MatterHackers.MatterControl.DesignTools
field.Vector3 = vector3;
field.ValueChanged += (s, e) =>
{
property.PropertyInfo.GetSetMethod().Invoke(this.item, new Object[] { field.Vector3 });
property.PropertyInfo.GetSetMethod().Invoke(property.Item, new Object[] { field.Vector3 });
rebuildable?.Rebuild(undoBuffer);
propertyGridModifier?.UpdateControls(this);
propertyGridModifier?.UpdateControls(publicPropertyEditor);
};
rowContainer.AddChild(field.Content);
@ -260,18 +306,18 @@ namespace MatterHackers.MatterControl.DesignTools
switch (dropDownList.SelectedValue)
{
case "Right":
property.PropertyInfo.GetSetMethod().Invoke(this.item, new Object[] { new DirectionVector() { Normal = Vector3.UnitX } });
property.PropertyInfo.GetSetMethod().Invoke(property.Item, new Object[] { new DirectionVector() { Normal = Vector3.UnitX } });
break;
case "Back":
property.PropertyInfo.GetSetMethod().Invoke(this.item, new Object[] { new DirectionVector() { Normal = Vector3.UnitY } });
property.PropertyInfo.GetSetMethod().Invoke(property.Item, new Object[] { new DirectionVector() { Normal = Vector3.UnitY } });
break;
case "Up":
property.PropertyInfo.GetSetMethod().Invoke(this.item, new Object[] { new DirectionVector() { Normal = Vector3.UnitZ } });
property.PropertyInfo.GetSetMethod().Invoke(property.Item, new Object[] { new DirectionVector() { Normal = Vector3.UnitZ } });
break;
}
rebuildable?.Rebuild(undoBuffer);
propertyGridModifier?.UpdateControls(this);
propertyGridModifier?.UpdateControls(publicPropertyEditor);
};
}
@ -288,9 +334,9 @@ namespace MatterHackers.MatterControl.DesignTools
field.Vector3 = directionVector.Normal;
field.ValueChanged += (s, e) =>
{
property.PropertyInfo.GetSetMethod().Invoke(this.item, new Object[] { new DirectionVector() { Normal = field.Vector3 } });
property.PropertyInfo.GetSetMethod().Invoke(property.Item, new Object[] { new DirectionVector() { Normal = field.Vector3 } });
rebuildable?.Rebuild(undoBuffer);
propertyGridModifier?.UpdateControls(this);
propertyGridModifier?.UpdateControls(publicPropertyEditor);
};
rowContainer.AddChild(field.Content);
@ -310,18 +356,18 @@ namespace MatterHackers.MatterControl.DesignTools
var field = new DoubleField();
field.Initialize(0);
field.DoubleValue = directionAxis.Origin.X - item.Children.First().GetAxisAlignedBoundingBox().Center.X;
field.DoubleValue = directionAxis.Origin.X - property.Item.Children.First().GetAxisAlignedBoundingBox().Center.X;
field.ValueChanged += (s, e) =>
{
property.PropertyInfo.GetSetMethod().Invoke(this.item, new Object[]
property.PropertyInfo.GetSetMethod().Invoke(property.Item, new Object[]
{
new DirectionAxis()
{
Normal = Vector3.UnitZ, Origin = item.Children.First().GetAxisAlignedBoundingBox().Center + new Vector3(field.DoubleValue, 0, 0)
Normal = Vector3.UnitZ, Origin = property.Item.Children.First().GetAxisAlignedBoundingBox().Center + new Vector3(field.DoubleValue, 0, 0)
}
});
rebuildable?.Rebuild(undoBuffer);
propertyGridModifier?.UpdateControls(this);
propertyGridModifier?.UpdateControls(publicPropertyEditor);
};
rowContainer.AddChild(field.Content);
@ -330,12 +376,12 @@ namespace MatterHackers.MatterControl.DesignTools
// update tihs when changed
EventHandler updateData = (object s, EventArgs e) =>
{
field.DoubleValue = ((DirectionAxis)property.PropertyInfo.GetGetMethod().Invoke(this.item, null)).Origin.X - item.Children.First().GetAxisAlignedBoundingBox().Center.X;
field.DoubleValue = ((DirectionAxis)property.PropertyInfo.GetGetMethod().Invoke(property.Item, null)).Origin.X - property.Item.Children.First().GetAxisAlignedBoundingBox().Center.X;
};
item.Invalidated += updateData;
property.Item.Invalidated += updateData;
editControlsContainer.Closed += (s, e) =>
{
item.Invalidated -= updateData;
property.Item.Invalidated -= updateData;
};
}
else
@ -353,9 +399,9 @@ namespace MatterHackers.MatterControl.DesignTools
originField.ValueChanged += (s, e) =>
{
property.PropertyInfo.GetSetMethod().Invoke(this.item, new Object[] { new DirectionAxis() { Origin = originField.Vector3, Normal = normalField.Vector3 } });
property.PropertyInfo.GetSetMethod().Invoke(property.Item, new Object[] { new DirectionAxis() { Origin = originField.Vector3, Normal = normalField.Vector3 } });
rebuildable?.Rebuild(undoBuffer);
propertyGridModifier?.UpdateControls(this);
propertyGridModifier?.UpdateControls(publicPropertyEditor);
};
originRowContainer.AddChild(originField.Content);
@ -366,9 +412,9 @@ namespace MatterHackers.MatterControl.DesignTools
normalField.ValueChanged += (s, e) =>
{
property.PropertyInfo.GetSetMethod().Invoke(this.item, new Object[] { new DirectionAxis() { Origin = originField.Vector3, Normal = normalField.Vector3 } });
property.PropertyInfo.GetSetMethod().Invoke(property.Item, new Object[] { new DirectionAxis() { Origin = originField.Vector3, Normal = normalField.Vector3 } });
rebuildable?.Rebuild(undoBuffer);
propertyGridModifier?.UpdateControls(this);
propertyGridModifier?.UpdateControls(publicPropertyEditor);
};
directionRowContainer.AddChild(normalField.Content);
@ -377,12 +423,12 @@ namespace MatterHackers.MatterControl.DesignTools
// update tihs when changed
EventHandler updateData = (object s, EventArgs e) =>
{
originField.Vector3 = ((DirectionAxis)property.PropertyInfo.GetGetMethod().Invoke(this.item, null)).Origin;
originField.Vector3 = ((DirectionAxis)property.PropertyInfo.GetGetMethod().Invoke(property.Item, null)).Origin;
};
item.Invalidated += updateData;
property.Item.Invalidated += updateData;
editControlsContainer.Closed += (s, e) =>
{
item.Invalidated -= updateData;
property.Item.Invalidated -= updateData;
};
}
}
@ -396,9 +442,9 @@ namespace MatterHackers.MatterControl.DesignTools
field.IntValue = intValue;
field.ValueChanged += (s, e) =>
{
property.PropertyInfo.GetSetMethod().Invoke(this.item, new Object[] { field.IntValue });
property.PropertyInfo.GetSetMethod().Invoke(property.Item, new Object[] { field.IntValue });
rebuildable?.Rebuild(undoBuffer);
propertyGridModifier?.UpdateControls(this);
propertyGridModifier?.UpdateControls(publicPropertyEditor);
};
rowContainer.AddChild(field.Content);
@ -409,14 +455,14 @@ namespace MatterHackers.MatterControl.DesignTools
{
rowContainer = CreateSettingsRow(property.DisplayName.Localize(), property.Description.Localize());
var field = new ToggleboxField(theme);
var field = new ToggleboxField(theme.Colors.PrimaryTextColor);
field.Initialize(0);
field.Checked = boolValue;
field.ValueChanged += (s, e) =>
{
property.PropertyInfo.GetSetMethod().Invoke(this.item, new Object[] { field.Checked });
property.PropertyInfo.GetSetMethod().Invoke(property.Item, new Object[] { field.Checked });
rebuildable?.Rebuild(undoBuffer);
propertyGridModifier?.UpdateControls(this);
propertyGridModifier?.UpdateControls(publicPropertyEditor);
};
rowContainer.AddChild(field.Content);
@ -433,9 +479,9 @@ namespace MatterHackers.MatterControl.DesignTools
};
textEditWidget.ActualTextEditWidget.EditComplete += (s, e) =>
{
property.PropertyInfo.GetSetMethod().Invoke(this.item, new Object[] { textEditWidget.Text });
property.PropertyInfo.GetSetMethod().Invoke(property.Item, new Object[] { textEditWidget.Text });
rebuildable?.Rebuild(undoBuffer);
propertyGridModifier?.UpdateControls(this);
propertyGridModifier?.UpdateControls(publicPropertyEditor);
};
rowContainer.AddChild(textEditWidget);
editControlsContainer.AddChild(rowContainer);
@ -459,9 +505,9 @@ namespace MatterHackers.MatterControl.DesignTools
{
textEditWidget.Text = textEditWidget.Text.Substring(0, 1);
}
property.PropertyInfo.GetSetMethod().Invoke(this.item, new Object[] { textEditWidget.Text[0] });
property.PropertyInfo.GetSetMethod().Invoke(property.Item, new Object[] { textEditWidget.Text[0] });
rebuildable?.Rebuild(undoBuffer);
propertyGridModifier?.UpdateControls(this);
propertyGridModifier?.UpdateControls(publicPropertyEditor);
};
rowContainer.AddChild(textEditWidget);
editControlsContainer.AddChild(rowContainer);
@ -469,8 +515,8 @@ namespace MatterHackers.MatterControl.DesignTools
// create an enum editor
else if (property.ptype.IsEnum)
{
rowContainer = CreateEnumEditor(rebuildable,
property.PropertyInfo, property.ptype, property.Value, property.DisplayName,
rowContainer = CreateEnumEditor(publicPropertyEditor, rebuildable,
property, property.ptype, property.Value, property.DisplayName,
theme, undoBuffer);
editControlsContainer.AddChild(rowContainer);
}
@ -478,28 +524,12 @@ namespace MatterHackers.MatterControl.DesignTools
else if (property.Value is IObject3D object3D
&& ApplicationController.Instance.GetEditorsForType(property.ptype)?.FirstOrDefault() is IObject3DEditor editor)
{
rowContainer = editor.Create( object3D, view3DWidget, theme);
rowContainer = editor.Create(object3D, view3DWidget, theme);
editControlsContainer.AddChild(rowContainer);
}
// remember the row name and widget
editRows.Add(property.PropertyInfo.Name, rowContainer);
}
var hideUpdate = item.GetType().GetCustomAttributes(typeof(HideUpdateButtonAttribute), true).FirstOrDefault() as HideUpdateButtonAttribute;
if (hideUpdate == null)
{
var updateButton = theme.ButtonFactory.Generate("Update".Localize());
updateButton.Margin = new BorderDouble(5);
updateButton.HAnchor = HAnchor.Right;
updateButton.Click += (s, e) =>
{
rebuildable?.Rebuild(undoBuffer);
};
editControlsContainer.AddChild(updateButton);
}
// make sure the ui is set right to start
propertyGridModifier?.UpdateControls(this);
editRows.Add((property.Item.ID, property.PropertyInfo.Name), rowContainer);
}
private void AddUnlockLinkIfRequired(FlowLayoutWidget editControlsContainer, ThemeConfig theme)
@ -541,8 +571,8 @@ namespace MatterHackers.MatterControl.DesignTools
}
}
private GuiWidget CreateEnumEditor(IRebuildable item,
PropertyInfo propertyInfo, Type propertyType, object value, string displayName,
private static GuiWidget CreateEnumEditor(PublicPropertyEditor publicPropertyEditor, IRebuildable item,
EditableProperty property, Type propertyType, object value, string displayName,
ThemeConfig theme,
UndoBuffer undoBuffer)
{
@ -560,7 +590,7 @@ namespace MatterHackers.MatterControl.DesignTools
FlowLayoutWidget rowContainer = CreateSettingsRow(displayName);
var iconsAttribute = propertyInfo.GetCustomAttributes(true).OfType<IconsAttribute>().FirstOrDefault();
var iconsAttribute = property.PropertyInfo.GetCustomAttributes(true).OfType<IconsAttribute>().FirstOrDefault();
if (iconsAttribute != null)
{
int index = 0;
@ -599,11 +629,11 @@ namespace MatterHackers.MatterControl.DesignTools
{
if (radioButton.Checked)
{
propertyInfo.GetSetMethod().Invoke(
this.item,
property.PropertyInfo.GetSetMethod().Invoke(
property.Item,
new Object[] { Enum.Parse(propertyType, localItem.Key) });
item?.Rebuild(undoBuffer);
propertyGridModifier?.UpdateControls(this);
propertyGridModifier?.UpdateControls(publicPropertyEditor);
if (localIndex != 0
|| !iconsAttribute.Item0IsNone)
{
@ -626,7 +656,7 @@ namespace MatterHackers.MatterControl.DesignTools
BorderColor = theme.GetBorderColor(75)
};
var sortableAttribute = propertyInfo.GetCustomAttributes(true).OfType<SortableAttribute>().FirstOrDefault();
var sortableAttribute = property.PropertyInfo.GetCustomAttributes(true).OfType<SortableAttribute>().FirstOrDefault();
var orderedItems = sortableAttribute != null ? enumItems.OrderBy(n => n.Value) : enumItems;
foreach (var orderItem in orderedItems)
@ -636,11 +666,11 @@ namespace MatterHackers.MatterControl.DesignTools
var localOrderedItem = orderItem;
newItem.Selected += (sender, e) =>
{
propertyInfo.GetSetMethod().Invoke(
this.item,
property.PropertyInfo.GetSetMethod().Invoke(
property.Item,
new Object[] { Enum.Parse(propertyType, localOrderedItem.Key) });
item?.Rebuild(undoBuffer);
propertyGridModifier?.UpdateControls(this);
propertyGridModifier?.UpdateControls(publicPropertyEditor);
};
}

4
PartPreviewWindow/SelectedObjectPanel.cs
View file

@ -290,7 +290,7 @@ namespace MatterHackers.MatterControl.PartPreviewWindow
{
Type = propertyType,
Value = item.GetValue(selectedItem, null) as IObject3D,
DisplayName = PublicPropertyEditor.GetDisplayName(item)
DisplayName = EditableProperty.GetDisplayName(item)
};
// Shown known editors for any matching properties
@ -311,7 +311,7 @@ namespace MatterHackers.MatterControl.PartPreviewWindow
{
Type = item.PropertyType,
Value = item.GetValue(selectedItem, null) as IObject3D,
DisplayName = PublicPropertyEditor.GetDisplayName(item)
DisplayName = EditableProperty.GetDisplayName(item)
};
// Shown known editors for any matching properties

2
Submodules/MatterSlice

@ -1 +1 @@
Subproject commit 5d49759ebee1bcb93be08c4319de4155382b5ed2
Subproject commit 8a12f59f45d02dfc21a62329d1e15a48e13956d1

2
Submodules/agg-sharp

@ -1 +1 @@
Subproject commit bcf6f08b3a27e3aeedf6229cb5a5cc0c9ddb4ae7
Subproject commit b80c97dafebed4d6566bce4e29897b417d2d9558