From 551a14c57adc147131e58e7cbdb9a5e664628742 Mon Sep 17 00:00:00 2001 From: Tyler Anderson Date: Wed, 14 Dec 2016 18:01:15 -0800 Subject: [PATCH 1/4] Added contribution guidelines --- CONTRIBUTING.md | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 000000000..56b0838f9 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,33 @@ +Contributing to MatterControl on Github +======================================= + +Github is a place for developer discussion. If you have a question or need help using MatterControl, please either post on the [MatterControl Forum](http://forums.matterhackers.com/category/20/mattercontrol) or send an email to support@matterhackers.com. If you are unsure if the problem you are having is really a bug, then send us an email. We will be happy to investigate and file a bug report if necessary. + +This is not the place for rants or abusive posts. We welcome constructive criticism, but if you feel the need to vent, please do it elsewhere. + +Bug Reports +----------- + +* If you have never filed a bug report for software before, [read this](http://www.chiark.greenend.org.uk/~sgtatham/bugs.html). +* Reports should only deal with a single bug at a time. Do not submit a laundry list of issues. +* Search for existing bugs before posting. Be sure to search for closed issues as well. If your issue is already known to us, it will be marked as a duplicate and closed. +* Use correct English and read your post aloud to yourself before submitting it. Avoid inflamatory language. +* Please use a clear descriptive title. + * Examples of good titles: + * "Can't close MC without stopping print from SD Card" + * "Add support for Monoprice Maker Select Mini firmware" + * Examples of bad titles: + * "This product is bad and you should feel bad" +* Include clear step by step instructions to reproduce the issue. Remember, **the developers cannot fix the bug if we cannot get it to happen ourselves**. +* Include a screenshot of the problem, if applicable. +* Please attach a .zip to your issue with any applicable diagnostic files. See the wiki article on [gathering diagnostic information](http://wiki.mattercontrol.com/Send_Debugging_Information). These might include... + * Crash Logs + * .stl files + * .gcode files + * Exported slice settings (.printer file) + * Print Logs + +Feature Requests +---------------- + +Feature requests are welcome. But take a moment to find out whether your idea fits with the scope and aims of the project. It's up to you to make a strong case to convince the project's developers of the merits of this feature. Please provide as much detail and context as possible. From 765350403a5ce3c31a0142f65aa291fe9d916521 Mon Sep 17 00:00:00 2001 From: Lars Brubaker Date: Thu, 15 Dec 2016 15:34:13 -0800 Subject: [PATCH 2/4] Latest agg --- Submodules/agg-sharp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Submodules/agg-sharp b/Submodules/agg-sharp index f7a23ccde..8b1df103a 160000 --- a/Submodules/agg-sharp +++ b/Submodules/agg-sharp @@ -1 +1 @@ -Subproject commit f7a23ccde5b894dc12bd1fdba867dcb1008013f5 +Subproject commit 8b1df103ab9850945d7755a0f095da7eb3036ed4 From 16b6b809223eaae297c651b798a65269104d7f22 Mon Sep 17 00:00:00 2001 From: Lars Brubaker Date: Thu, 15 Dec 2016 15:55:26 -0800 Subject: [PATCH 3/4] Make sure we always have valid selection. --- Queue/QueueData.cs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Queue/QueueData.cs b/Queue/QueueData.cs index 234f4f62e..139bcfbfd 100644 --- a/Queue/QueueData.cs +++ b/Queue/QueueData.cs @@ -569,6 +569,14 @@ namespace MatterHackers.MatterControl.PrintQueue { SelectedIndex = selectedIndices[selectedIndices.Count - 1]; } + + if(ItemCount > 0 + && SelectedIndex < 0) + { + SelectedIndex = 0; + } + else if(ItemCount > 0 + && SelectedIndex >= ItemCount) } public void Select(int index) From 11e92e20fca7d102018e06d6984854146502cd4c Mon Sep 17 00:00:00 2001 From: Lars Brubaker Date: Thu, 15 Dec 2016 16:26:20 -0800 Subject: [PATCH 4/4] Edit and compile missed saving. --- Queue/QueueData.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Queue/QueueData.cs b/Queue/QueueData.cs index 139bcfbfd..66fc9e522 100644 --- a/Queue/QueueData.cs +++ b/Queue/QueueData.cs @@ -577,6 +577,9 @@ namespace MatterHackers.MatterControl.PrintQueue } else if(ItemCount > 0 && SelectedIndex >= ItemCount) + { + SelectedIndex = ItemCount - 1; + } } public void Select(int index)