From 9d8ed3e6aadee0d1a496170d523c6ec97663eb6c Mon Sep 17 00:00:00 2001 From: Tyler Anderson Date: Mon, 12 Dec 2016 16:37:09 -0800 Subject: [PATCH 1/3] Added detection for Rostock hardware leveling errors --- PrinterCommunication/PrinterConnectionAndCommunication.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/PrinterCommunication/PrinterConnectionAndCommunication.cs b/PrinterCommunication/PrinterConnectionAndCommunication.cs index f71e4e2e7..3438d91ab 100644 --- a/PrinterCommunication/PrinterConnectionAndCommunication.cs +++ b/PrinterCommunication/PrinterConnectionAndCommunication.cs @@ -283,12 +283,16 @@ namespace MatterHackers.MatterControl.PrinterCommunication ReadLineContainsCallBacks.AddCallbackToKey("M999", PrinterReportsError); ReadLineContainsCallBacks.AddCallbackToKey("Error: Extruder switched off", PrinterReportsError); ReadLineContainsCallBacks.AddCallbackToKey("Heater decoupled", PrinterReportsError); - ReadLineContainsCallBacks.AddCallbackToKey("Bot is Shutdown due to Overheat", PrinterReportsError); ReadLineContainsCallBacks.AddCallbackToKey("cold extrusion prevented", PrinterReportsError); ReadLineContainsCallBacks.AddCallbackToKey("Error:Thermal Runaway, system stopped!", PrinterReportsError); // repetier temperature failures ReadLineContainsCallBacks.AddCallbackToKey("dry run mode", PrinterReportsError); + ReadLineContainsCallBacks.AddCallbackToKey("accelerometer send i2c error", PrinterReportsError); + ReadLineContainsCallBacks.AddCallbackToKey("accelerometer i2c recv error", PrinterReportsError); + + // s3g temperature failures + ReadLineContainsCallBacks.AddCallbackToKey("Bot is Shutdown due to Overheat", PrinterReportsError); #endregion WriteLineStartCallBacks.AddCallbackToKey("M104", ExtruderTemperatureWasWritenToPrinter); From f6037afa78ba0dfc5e3b1b68cb43cfea9b639984 Mon Sep 17 00:00:00 2001 From: Tyler Anderson Date: Wed, 14 Dec 2016 16:26:46 -0800 Subject: [PATCH 2/3] Switched to ReadLineStartCallBacks --- PrinterCommunication/PrinterConnectionAndCommunication.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PrinterCommunication/PrinterConnectionAndCommunication.cs b/PrinterCommunication/PrinterConnectionAndCommunication.cs index 3438d91ab..eae3d0a90 100644 --- a/PrinterCommunication/PrinterConnectionAndCommunication.cs +++ b/PrinterCommunication/PrinterConnectionAndCommunication.cs @@ -288,8 +288,8 @@ namespace MatterHackers.MatterControl.PrinterCommunication // repetier temperature failures ReadLineContainsCallBacks.AddCallbackToKey("dry run mode", PrinterReportsError); - ReadLineContainsCallBacks.AddCallbackToKey("accelerometer send i2c error", PrinterReportsError); - ReadLineContainsCallBacks.AddCallbackToKey("accelerometer i2c recv error", PrinterReportsError); + ReadLineStartCallBacks.AddCallbackToKey("accelerometer send i2c error", PrinterReportsError); + ReadLineStartCallBacks.AddCallbackToKey("accelerometer i2c recv error", PrinterReportsError); // s3g temperature failures ReadLineContainsCallBacks.AddCallbackToKey("Bot is Shutdown due to Overheat", PrinterReportsError); From 551a14c57adc147131e58e7cbdb9a5e664628742 Mon Sep 17 00:00:00 2001 From: Tyler Anderson Date: Wed, 14 Dec 2016 18:01:15 -0800 Subject: [PATCH 3/3] Added contribution guidelines --- CONTRIBUTING.md | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 000000000..56b0838f9 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,33 @@ +Contributing to MatterControl on Github +======================================= + +Github is a place for developer discussion. If you have a question or need help using MatterControl, please either post on the [MatterControl Forum](http://forums.matterhackers.com/category/20/mattercontrol) or send an email to support@matterhackers.com. If you are unsure if the problem you are having is really a bug, then send us an email. We will be happy to investigate and file a bug report if necessary. + +This is not the place for rants or abusive posts. We welcome constructive criticism, but if you feel the need to vent, please do it elsewhere. + +Bug Reports +----------- + +* If you have never filed a bug report for software before, [read this](http://www.chiark.greenend.org.uk/~sgtatham/bugs.html). +* Reports should only deal with a single bug at a time. Do not submit a laundry list of issues. +* Search for existing bugs before posting. Be sure to search for closed issues as well. If your issue is already known to us, it will be marked as a duplicate and closed. +* Use correct English and read your post aloud to yourself before submitting it. Avoid inflamatory language. +* Please use a clear descriptive title. + * Examples of good titles: + * "Can't close MC without stopping print from SD Card" + * "Add support for Monoprice Maker Select Mini firmware" + * Examples of bad titles: + * "This product is bad and you should feel bad" +* Include clear step by step instructions to reproduce the issue. Remember, **the developers cannot fix the bug if we cannot get it to happen ourselves**. +* Include a screenshot of the problem, if applicable. +* Please attach a .zip to your issue with any applicable diagnostic files. See the wiki article on [gathering diagnostic information](http://wiki.mattercontrol.com/Send_Debugging_Information). These might include... + * Crash Logs + * .stl files + * .gcode files + * Exported slice settings (.printer file) + * Print Logs + +Feature Requests +---------------- + +Feature requests are welcome. But take a moment to find out whether your idea fits with the scope and aims of the project. It's up to you to make a strong case to convince the project's developers of the merits of this feature. Please provide as much detail and context as possible.