nettika/mattercontrol
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Throw exceptions for missing functionality rather than Debug.Break

Browse source 
- Fix unexpected abort in NUnit testruns
- Tests should fail rather than crash, highlighting areas needing focus
This commit is contained in:
John Lewin 2017-05-21 22:37:30 -07:00
parent 9f6821305c
commit 4d84844f96
5 changed files with 19 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Library/Widgets/PrintLibraryWidget.cs
View file

@ -372,7 +372,11 @@ namespace MatterHackers.MatterControl.PrintLibrary
AllowMultiple = false,
AllowProtected = false,
AllowContainers = false,
Action = (selectedLibraryItems, listView) => System.Diagnostics.Debugger.Break() /* editButton_Click(s, null) */
Action = (selectedLibraryItems, listView) =>
{
throw new NotImplementedException();
/* editButton_Click(s, null) */
}
});
// rename menu item
@ -795,7 +799,7 @@ namespace MatterHackers.MatterControl.PrintLibrary
private void shareFromLibraryButton_Click(object sender, EventArgs e)
{
// TODO: Should be rewritten to Register from cloudlibrary, include logic to add to library as needed
System.Diagnostics.Debugger.Break();
throw new NotImplementedException();
if (libraryView.SelectedItems.Count == 1)
{