nettika/mattercontrol
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improved slicing error messages

Browse source 
Get the location from the settings organizer
Get the display name of the setting from the settings organizer
Moved more settings strings to SettingsKey

issue: MatterHackers/MCCentral#4231
setting layer thickness to 0 is not displaying an error message
This commit is contained in:
Lars Brubaker 2018-10-26 14:51:04 -07:00
parent cf76f788d3
commit 4ab0cf715d
7 changed files with 194 additions and 107 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Tests/MatterControl.Tests/MatterControl/OemProfileTests.cs
View file

@ -198,7 +198,7 @@ namespace MatterControl.Tests.MatterControl
{
ValidateOnAllPrinters((printer, settings) =>
{
string fanSpeedString = settings.GetValue("min_fan_speed");
string fanSpeedString = settings.GetValue(SettingsKey.min_fan_speed);
if (!string.IsNullOrEmpty(fanSpeedString))
{
// Must be valid int data
@ -246,7 +246,7 @@ namespace MatterControl.Tests.MatterControl
{
ValidateOnAllPrinters((printer, settings) =>
{
string fanSpeedString = settings.GetValue("max_fan_speed");
string fanSpeedString = settings.GetValue(SettingsKey.max_fan_speed);
if (!string.IsNullOrEmpty(fanSpeedString))
{
// Must be valid int data

4
Tests/MatterControl.Tests/MatterControl/PrinterConfigurationTests.cs
View file

@ -244,7 +244,7 @@ namespace MatterControl.Tests.MatterControl
public void minimumFanSpeedLessThanOrEqualToOneHundred(PrinterSettingsLayer layer, string sourceFile)
{
string settingValue;
if (!layer.TryGetValue("min_fan_speed", out settingValue))
if (!layer.TryGetValue(SettingsKey.min_fan_speed, out settingValue))
{
return;
}
@ -255,7 +255,7 @@ namespace MatterControl.Tests.MatterControl
public void maxFanSpeedNotGreaterThanOneHundred(PrinterSettingsLayer layer, string sourceFile)
{
string settingValue;
if (!layer.TryGetValue("max_fan_speed", out settingValue))
if (!layer.TryGetValue(SettingsKey.max_fan_speed, out settingValue))
{
return;
}