From 1b463ffaa7fb1327327bff6fc34679fb0a563214 Mon Sep 17 00:00:00 2001 From: John Lewin Date: Fri, 15 Feb 2019 20:09:48 -0800 Subject: [PATCH 1/6] Convert custom WizardPage actions/events to existing ones - Remove PageIsBecomingActive, prefer existing OnLoad - Remove PageIsBecomingInactive, prefer existing OnClosed - Rename BecomingActive action to PageLoad, used for inline defs - Rename BecomingInactive action to PageClose, used for inline defs - Fire PageLoad/PageClose from page base OnLoad/OnClosed --- .../PrintLeveling/LoadFilamentWizard.cs | 40 +++++++------------ .../PrintLeveling/PrinterSetupWizard.cs | 8 ---- .../PrintLeveling/PrinterSetupWizardPage.cs | 28 ++++++------- .../PrintLeveling/UnloadFilamentWizard.cs | 16 +++----- .../WizardPages/AutoProbeFeedback.cs | 10 ++--- .../CalibrateProbeLastPagelInstructions.cs | 4 +- .../WizardPages/FindBedHeight.cs | 19 ++------- .../WizardPages/GetCoarseBedHeight.cs | 13 ++---- .../WizardPages/GetUltraFineBedHeight.cs | 6 ++- .../GettingThirdPointFor2PointCalibration.cs | 6 +-- .../WizardPages/HomePrinterPage.cs | 11 +---- .../WizardPages/LastPageInstructions.cs | 4 +- .../WizardPages/SelectMaterialPage.cs | 5 --- .../WizardPages/WaitForTempPage.cs | 23 +++-------- MatterControlLib/SetupWizard/DialogPage.cs | 8 ---- 15 files changed, 65 insertions(+), 136 deletions(-) diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/LoadFilamentWizard.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/LoadFilamentWizard.cs index 0908a93ef..4b74878bd 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/LoadFilamentWizard.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/LoadFilamentWizard.cs @@ -104,12 +104,9 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling // show the trim filament message { PrinterSetupWizardPage trimFilamentPage = null; - trimFilamentPage = new PrinterSetupWizardPage( - this, - "Trim Filament".Localize(), - "") + trimFilamentPage = new PrinterSetupWizardPage(this, "Trim Filament".Localize(), "") { - BecomingActive = () => + PageLoad = () => { // start heating up the extruder printer.Connection.SetTargetHotendTemperature(extruderIndex, printer.Settings.GetValue(SettingsKey.temperature)); @@ -136,12 +133,9 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling { RunningInterval runningGCodeCommands = null; PrinterSetupWizardPage insertFilamentPage = null; - insertFilamentPage = new PrinterSetupWizardPage( - this, - "Insert Filament".Localize(), - "") + insertFilamentPage = new PrinterSetupWizardPage(this, "Insert Filament".Localize(), "") { - BecomingActive = () => + PageLoad = () => { var markdownText = printer.Settings.GetValue(SettingsKey.insert_filament_markdown2); if(extruderIndex == 1) @@ -175,7 +169,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling }, .1); }, - BecomingInactive = () => + PageClose = () => { if (runningGCodeCommands != null) { @@ -198,12 +192,9 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling { RunningInterval runningGCodeCommands = null; PrinterSetupWizardPage loadingFilamentPage = null; - loadingFilamentPage = new PrinterSetupWizardPage( - this, - "Loading Filament".Localize(), - "") + loadingFilamentPage = new PrinterSetupWizardPage(this, "Loading Filament".Localize(), "") { - BecomingActive = () => + PageLoad = () => { loadingFilamentPage.NextButton.Enabled = false; @@ -279,7 +270,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling }, .1); }, - BecomingInactive = () => + PageClose = () => { UiThread.ClearInterval(runningGCodeCommands); } @@ -313,12 +304,9 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling { RunningInterval runningGCodeCommands = null; PrinterSetupWizardPage runningCleanPage = null; - runningCleanPage = new PrinterSetupWizardPage( - this, - "Wait For Running Clean".Localize(), - "") + runningCleanPage = new PrinterSetupWizardPage(this, "Wait For Running Clean".Localize(), "") { - BecomingActive = () => + PageLoad = () => { var markdownText = printer.Settings.GetValue(SettingsKey.running_clean_markdown2); if(extruderIndex == 1) @@ -346,7 +334,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling }, .1); }, - BecomingInactive = () => + PageClose = () => { UiThread.ClearInterval(runningGCodeCommands); } @@ -413,11 +401,11 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling } } - public override void PageIsBecomingActive() + public override void OnLoad(EventArgs args) { - ShowWizardFinished(); + this.ShowWizardFinished(); - base.PageIsBecomingActive(); + base.OnLoad(args); } } } diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizard.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizard.cs index bde27aacd..bf97ede3c 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizard.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizard.cs @@ -27,13 +27,8 @@ of the authors and should not be interpreted as representing official policies, either expressed or implied, of the FreeBSD Project. */ -using System; using System.Collections.Generic; using MatterHackers.Agg.UI; -using MatterHackers.Localizations; -using MatterHackers.MatterControl.ConfigurationPage.PrintLeveling; -using MatterHackers.MatterControl.PrinterCommunication.Io; -using MatterHackers.MatterControl.SlicerConfiguration; namespace MatterHackers.MatterControl { @@ -60,14 +55,11 @@ namespace MatterHackers.MatterControl UiThread.RunOnIdle(() => { // Shutdown active page - pages.Current?.PageIsBecomingInactive(); pages.Current?.Close(); // Advance if (pages.MoveNext()) { - pages.Current?.PageIsBecomingActive(); - dialogWindow.ChangeToPage(pages.Current); } }); diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizardPage.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizardPage.cs index f8abffe5f..b3b35902a 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizardPage.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizardPage.cs @@ -40,8 +40,8 @@ namespace MatterHackers.MatterControl public TextButton NextButton { get; } protected PrinterConfig printer; - public Action BecomingActive; - public Action BecomingInactive; + public Action PageLoad; + public Action PageClose; protected PrinterSetupWizard wizardContext; public PrinterSetupWizardPage(PrinterSetupWizard wizardContext, string headerText, string instructionsText) @@ -72,18 +72,6 @@ namespace MatterHackers.MatterControl public GuiWidget ContentRow => contentRow; - public override void PageIsBecomingActive() - { - BecomingActive?.Invoke(); - base.PageIsBecomingActive(); - } - - public override void PageIsBecomingInactive() - { - BecomingInactive?.Invoke(); - base.PageIsBecomingInactive(); - } - protected GuiWidget CreateTextField(string text) { return new WrappedTextWidget(text) @@ -94,6 +82,18 @@ namespace MatterHackers.MatterControl }; } + public override void OnLoad(EventArgs args) + { + this.PageLoad?.Invoke(); + base.OnLoad(args); + } + + public override void OnClosed(EventArgs e) + { + this.PageClose?.Invoke(); + base.OnClosed(e); + } + public void ShowWizardFinished() { var doneButton = new TextButton("Done".Localize(), theme) diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/UnloadFilamentWizard.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/UnloadFilamentWizard.cs index 0f381df14..80c0f7a5e 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/UnloadFilamentWizard.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/UnloadFilamentWizard.cs @@ -110,12 +110,9 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling RunningInterval runningGCodeCommands = null; PrinterSetupWizardPage unloadingFilamentPage = null; - unloadingFilamentPage = new PrinterSetupWizardPage( - this, - "Unloading Filament".Localize(), - "") + unloadingFilamentPage = new PrinterSetupWizardPage(this, "Unloading Filament".Localize(), "") { - BecomingActive = () => + PageLoad = () => { unloadingFilamentPage.NextButton.Enabled = false; @@ -204,7 +201,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling }, .1); }, - BecomingInactive = () => + PageClose = () => { UiThread.ClearInterval(runningGCodeCommands); } @@ -248,11 +245,10 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling this.AddPageAction(loadFilamentButton); } - public override void PageIsBecomingActive() + public override void OnLoad(EventArgs args) { - ShowWizardFinished(); - - base.PageIsBecomingActive(); + this.ShowWizardFinished(); + base.OnLoad(args); } } } diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/AutoProbeFeedback.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/AutoProbeFeedback.cs index 0d3bed5b1..93570b3e5 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/AutoProbeFeedback.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/AutoProbeFeedback.cs @@ -119,13 +119,11 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling private Vector3 feedRates; private Vector3 adjustedProbePosition; - public override void PageIsBecomingActive() + public override void OnLoad(EventArgs args) { // always make sure we don't have print leveling turned on printer.Connection.AllowLeveling = false; - base.PageIsBecomingActive(); - if (printer.Settings.GetValue(SettingsKey.has_z_probe) && printer.Settings.GetValue(SettingsKey.use_z_probe) && printer.Settings.GetValue(SettingsKey.has_z_servo)) @@ -160,12 +158,14 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling { printer.Connection.LineReceived += GetZProbeHeight; } + + base.OnLoad(args); } - public override void PageIsBecomingInactive() + public override void OnClosed(EventArgs e) { printer.Connection.LineReceived -= GetZProbeHeight; - base.PageIsBecomingInactive(); + base.OnClosed(e); } } } \ No newline at end of file diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPagelInstructions.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPagelInstructions.cs index e688957e5..2dcc498f5 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPagelInstructions.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPagelInstructions.cs @@ -63,7 +63,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling this.ShowWizardFinished(); } - public override void PageIsBecomingActive() + public override void OnLoad(EventArgs args) { if (printer.Settings.GetValue(SettingsKey.z_homes_to_max)) { @@ -72,7 +72,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling pageWasActive = true; - base.PageIsBecomingActive(); + base.OnLoad(args); } public override void OnClosed(EventArgs e) diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/FindBedHeight.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/FindBedHeight.cs index 5523df7b7..53319f2f5 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/FindBedHeight.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/FindBedHeight.cs @@ -90,17 +90,15 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling this.CreateTextField(setZHeightCoarseInstruction2)); } - public override void PageIsBecomingActive() + public override void OnLoad(EventArgs args) { + this.Parents().First().KeyDown -= TopWindowKeyDown; + probePositions[probePositionsBeingEditedIndex].position = printer.Connection.LastReportedPosition; + // always make sure we don't have print leveling turned on printer.Connection.AllowLeveling = false; NextButton.ToolTipText = string.Format("[{0}]", "Right Arrow".Localize()); - base.PageIsBecomingActive(); - } - - public override void OnLoad(EventArgs args) - { this.DialogWindow.KeyDown += TopWindowKeyDown; base.OnLoad(args); } @@ -114,15 +112,6 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling base.OnClosed(e); } - public override void PageIsBecomingInactive() - { - this.Parents().First().KeyDown -= TopWindowKeyDown; - probePositions[probePositionsBeingEditedIndex].position = printer.Connection.LastReportedPosition; - base.PageIsBecomingInactive(); - - NextButton.ToolTipText = ""; - } - private FlowLayoutWidget CreateZButtons() { FlowLayoutWidget zButtons = JogControls.CreateZButtons(printer, 4, out zPlusControl, out zMinusControl, new PrinterControls.XYZColors(theme), theme, true); diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetCoarseBedHeight.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetCoarseBedHeight.cs index de51f2a16..7ec115383 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetCoarseBedHeight.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetCoarseBedHeight.cs @@ -48,10 +48,8 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling this.probeStartPosition = probeStartPosition; } - public override void PageIsBecomingActive() + public override void OnLoad(EventArgs args) { - base.PageIsBecomingActive(); - // make sure the probe is not deployed if (printer.Settings.GetValue(SettingsKey.has_z_probe) && printer.Settings.GetValue(SettingsKey.use_z_probe) @@ -72,18 +70,13 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling zPlusControl.Click += zControl_Click; zMinusControl.Click += zControl_Click; + + base.OnLoad(args); } protected void zControl_Click(object sender, EventArgs mouseEvent) { NextButton.Enabled = true; } - - public override void PageIsBecomingInactive() - { - NextButton.Enabled = true; - - base.PageIsBecomingInactive(); - } } } \ No newline at end of file diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetUltraFineBedHeight.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetUltraFineBedHeight.cs index 5b4ad75a5..1ae12a12b 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetUltraFineBedHeight.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetUltraFineBedHeight.cs @@ -27,6 +27,7 @@ of the authors and should not be interpreted as representing official policies, either expressed or implied, of the FreeBSD Project. */ +using System; using System.Collections.Generic; using MatterHackers.Agg; using MatterHackers.Localizations; @@ -57,14 +58,15 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling base.OnDraw(graphics2D); } - public override void PageIsBecomingInactive() + public override void OnLoad(EventArgs args) { // TODO: Why conditional on haveDrawn? if (haveDrawn) { printer.Connection.MoveRelative(PrinterConnection.Axis.Z, 2, printer.Settings.Helpers.ManualMovementSpeeds().Z); } - base.PageIsBecomingInactive(); + + base.OnLoad(args); } } } \ No newline at end of file diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GettingThirdPointFor2PointCalibration.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GettingThirdPointFor2PointCalibration.cs index 030e2b0d8..3adf80151 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GettingThirdPointFor2PointCalibration.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GettingThirdPointFor2PointCalibration.cs @@ -55,7 +55,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling base.OnClosed(e); } - public override void PageIsBecomingActive() + public override void OnLoad(EventArgs args) { // first make sure there is no leftover FinishedProbe event printer.Connection.LineReceived += FinishedProbe; @@ -67,9 +67,9 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling printer.Connection.QueueLine("G30"); printer.Connection.LineReceived += FinishedProbe; - base.PageIsBecomingActive(); - NextButton.Enabled = false; + + base.OnLoad(args); } private void FinishedProbe(object sender, string line) diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/HomePrinterPage.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/HomePrinterPage.cs index a4d1129e2..20dad259d 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/HomePrinterPage.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/HomePrinterPage.cs @@ -52,7 +52,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling base.OnClosed(e); } - public override void PageIsBecomingActive() + public override void OnLoad(EventArgs args) { printer.Connection.CommunicationStateChanged += CheckHomeFinished; @@ -69,7 +69,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling NextButton.Enabled = false; } - base.PageIsBecomingActive(); + base.OnLoad(args); } private void CheckHomeFinished(object sender, EventArgs e) @@ -84,12 +84,5 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling } } } - - public override void PageIsBecomingInactive() - { - NextButton.Enabled = true; - - base.PageIsBecomingInactive(); - } } } \ No newline at end of file diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/LastPageInstructions.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/LastPageInstructions.cs index f3a9737b0..77980a87d 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/LastPageInstructions.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/LastPageInstructions.cs @@ -66,7 +66,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling this.ShowWizardFinished(); } - public override void PageIsBecomingActive() + public override void OnLoad(EventArgs args) { PrintLevelingData levelingData = printer.Settings.Helpers.GetPrintLevelingData(); levelingData.SampledPositions.Clear(); @@ -105,7 +105,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling ApplicationController.Instance.RunAnyRequiredPrinterSetup(printer, theme); }; - base.PageIsBecomingActive(); + base.OnLoad(args); } } } \ No newline at end of file diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/SelectMaterialPage.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/SelectMaterialPage.cs index d01b4270c..1e4dc59c1 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/SelectMaterialPage.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/SelectMaterialPage.cs @@ -93,10 +93,5 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling this.AddPageAction(alreadyLoadedButton); } } - - public override void PageIsBecomingInactive() - { - base.PageIsBecomingInactive(); - } } } \ No newline at end of file diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/WaitForTempPage.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/WaitForTempPage.cs index cebe3902a..fcb440701 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/WaitForTempPage.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/WaitForTempPage.cs @@ -167,13 +167,6 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling } } - public override void OnLoad(EventArgs args) - { - // hook our parent so we can turn off the bed when we are done with leveling - this.DialogWindow.Closed += WizardWindow_Closed; - base.OnLoad(args); - } - private void WizardWindow_Closed(object sender, EventArgs e) { // Make sure when the wizard closes we turn off the bed heating @@ -181,8 +174,11 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling this.DialogWindow.Closed -= WizardWindow_Closed; } - public override void PageIsBecomingActive() + public override void OnLoad(EventArgs args) { + // hook our parent so we can turn off the bed when we are done with leveling + this.DialogWindow.Closed += WizardWindow_Closed; + bedStartingTemp = printer.Connection.ActualBedTemperature; runningInterval = UiThread.SetInterval(ShowTempChangeProgress, 1); @@ -205,21 +201,14 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling NextButton.Enabled = false; // if we are trying to go to a temp of 0 than just move on to next window - if(bedTargetTemp == 0 + if (bedTargetTemp == 0 && targetHotendTemps.All(i => i == 0)) { // advance to the next page UiThread.RunOnIdle(() => NextButton.InvokeClick()); } - base.PageIsBecomingActive(); - } - - public override void PageIsBecomingInactive() - { - NextButton.Enabled = true; - - base.PageIsBecomingInactive(); + base.OnLoad(args); } public override void OnClosed(EventArgs e) diff --git a/MatterControlLib/SetupWizard/DialogPage.cs b/MatterControlLib/SetupWizard/DialogPage.cs index 4016c48ed..b01f33194 100644 --- a/MatterControlLib/SetupWizard/DialogPage.cs +++ b/MatterControlLib/SetupWizard/DialogPage.cs @@ -223,13 +223,5 @@ namespace MatterHackers.MatterControl { abortCancel = false; } - - public virtual void PageIsBecomingActive() - { - } - - public virtual void PageIsBecomingInactive() - { - } } } \ No newline at end of file From 81678d9f8c8a98270546370fb649fdab4559de42 Mon Sep 17 00:00:00 2001 From: John Lewin Date: Fri, 15 Feb 2019 20:25:07 -0800 Subject: [PATCH 2/6] Simplify Page access, pass page instance reference to PageLoad --- .../PrintLeveling/LevelingStrings.cs | 2 +- .../PrintLeveling/LoadFilamentWizard.cs | 34 ++++++++----------- .../PrintLeveling/PrintLevelingWizard.cs | 2 +- .../PrintLeveling/PrinterSetupWizard.cs | 2 +- .../PrintLeveling/PrinterSetupWizardPage.cs | 12 +++---- .../PrintLeveling/ProbeCalibrationWizard.cs | 2 +- .../PrintLeveling/UnloadFilamentWizard.cs | 13 ++++--- .../WizardPages/AutoProbeFeedback.cs | 2 +- .../CalibrateProbeLastPagelInstructions.cs | 2 +- .../WizardPages/FindBedHeight.cs | 2 +- .../WizardPages/GetCoarseBedHeight.cs | 2 +- .../WizardPages/GetFineBedHeight.cs | 2 +- .../GettingThirdPointFor2PointCalibration.cs | 2 +- .../WizardPages/HomePrinterPage.cs | 2 +- .../WizardPages/WaitForTempPage.cs | 2 +- MatterControlLib/SetupWizard/DialogPage.cs | 2 +- 16 files changed, 40 insertions(+), 45 deletions(-) diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/LevelingStrings.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/LevelingStrings.cs index 5d009fdda..21574eb3f 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/LevelingStrings.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/LevelingStrings.cs @@ -1,5 +1,5 @@ /* -Copyright (c) 2018, Lars Brubaker, John Lewin +Copyright (c) 2019, Lars Brubaker, John Lewin All rights reserved. Redistribution and use in source and binary forms, with or without diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/LoadFilamentWizard.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/LoadFilamentWizard.cs index 4b74878bd..3e4840dae 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/LoadFilamentWizard.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/LoadFilamentWizard.cs @@ -1,5 +1,5 @@ /* -Copyright (c) 2018, Lars Brubaker, John Lewin +Copyright (c) 2019, Lars Brubaker, John Lewin All rights reserved. Redistribution and use in source and binary forms, with or without @@ -103,10 +103,9 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling // show the trim filament message { - PrinterSetupWizardPage trimFilamentPage = null; - trimFilamentPage = new PrinterSetupWizardPage(this, "Trim Filament".Localize(), "") + var trimFilamentPage = new PrinterSetupWizardPage(this, "Trim Filament".Localize(), "") { - PageLoad = () => + PageLoad = (page) => { // start heating up the extruder printer.Connection.SetTargetHotendTemperature(extruderIndex, printer.Settings.GetValue(SettingsKey.temperature)); @@ -114,7 +113,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling var markdownText = printer.Settings.GetValue(SettingsKey.trim_filament_markdown); var markdownWidget = new MarkdownWidget(theme); markdownWidget.Markdown = markdownText = markdownText.Replace("\\n", "\n"); - trimFilamentPage.ContentRow.AddChild(markdownWidget); + page.ContentRow.AddChild(markdownWidget); } }; yield return trimFilamentPage; @@ -132,10 +131,9 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling // show the insert filament page { RunningInterval runningGCodeCommands = null; - PrinterSetupWizardPage insertFilamentPage = null; - insertFilamentPage = new PrinterSetupWizardPage(this, "Insert Filament".Localize(), "") + var insertFilamentPage = new PrinterSetupWizardPage(this, "Insert Filament".Localize(), "") { - PageLoad = () => + PageLoad = (page) => { var markdownText = printer.Settings.GetValue(SettingsKey.insert_filament_markdown2); if(extruderIndex == 1) @@ -144,7 +142,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling } var markdownWidget = new MarkdownWidget(theme); markdownWidget.Markdown = markdownText = markdownText.Replace("\\n", "\n"); - insertFilamentPage.ContentRow.AddChild(markdownWidget); + page.ContentRow.AddChild(markdownWidget); // turn off the fan printer.Connection.FanSpeed0To255 = 0; @@ -191,12 +189,11 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling // show the loading filament progress bar { RunningInterval runningGCodeCommands = null; - PrinterSetupWizardPage loadingFilamentPage = null; - loadingFilamentPage = new PrinterSetupWizardPage(this, "Loading Filament".Localize(), "") + var loadingFilamentPage = new PrinterSetupWizardPage(this, "Loading Filament".Localize(), "") { - PageLoad = () => + PageLoad = (page) => { - loadingFilamentPage.NextButton.Enabled = false; + page.NextButton.Enabled = false; // add the progress bar var holder = new FlowLayoutWidget() @@ -218,7 +215,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling }; holder.AddChild(progressBar); holder.AddChild(progressBarText); - loadingFilamentPage.ContentRow.AddChild(holder); + page.ContentRow.AddChild(holder); // Allow extrusion at any temperature. S0 only works on Marlin S1 works on repetier and marlin printer.Connection.QueueLine("M302 S1"); @@ -265,7 +262,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling && remainingLengthMm <= .001) { UiThread.ClearInterval(runningGCodeCommands); - loadingFilamentPage.NextButton.InvokeClick(); + page.NextButton.InvokeClick(); } }, .1); @@ -303,10 +300,9 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling // extrude slowly so that we can prime the extruder { RunningInterval runningGCodeCommands = null; - PrinterSetupWizardPage runningCleanPage = null; - runningCleanPage = new PrinterSetupWizardPage(this, "Wait For Running Clean".Localize(), "") + var runningCleanPage = new PrinterSetupWizardPage(this, "Wait For Running Clean".Localize(), "") { - PageLoad = () => + PageLoad = (page) => { var markdownText = printer.Settings.GetValue(SettingsKey.running_clean_markdown2); if(extruderIndex == 1) @@ -315,7 +311,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling } var markdownWidget = new MarkdownWidget(theme); markdownWidget.Markdown = markdownText = markdownText.Replace("\\n", "\n"); - runningCleanPage.ContentRow.AddChild(markdownWidget); + page.ContentRow.AddChild(markdownWidget); var runningTime = Stopwatch.StartNew(); runningGCodeCommands = UiThread.SetInterval(() => diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/PrintLevelingWizard.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/PrintLevelingWizard.cs index 3cf0695c8..999c52a1c 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/PrintLevelingWizard.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/PrintLevelingWizard.cs @@ -1,5 +1,5 @@ /* -Copyright (c) 2018, Lars Brubaker, John Lewin +Copyright (c) 2019, Lars Brubaker, John Lewin All rights reserved. Redistribution and use in source and binary forms, with or without diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizard.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizard.cs index bf97ede3c..3d1dbc008 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizard.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizard.cs @@ -1,5 +1,5 @@ /* -Copyright (c) 2018, Lars Brubaker, John Lewin +Copyright (c) 2019, Lars Brubaker, John Lewin All rights reserved. Redistribution and use in source and binary forms, with or without diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizardPage.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizardPage.cs index b3b35902a..08597ab2b 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizardPage.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizardPage.cs @@ -1,5 +1,5 @@ /* -Copyright (c) 2018, Lars Brubaker, John Lewin +Copyright (c) 2019, Lars Brubaker, John Lewin All rights reserved. Redistribution and use in source and binary forms, with or without @@ -40,8 +40,10 @@ namespace MatterHackers.MatterControl public TextButton NextButton { get; } protected PrinterConfig printer; - public Action PageLoad; - public Action PageClose; + public Action PageLoad { get; set; } + + public Action PageClose { get; set; } + protected PrinterSetupWizard wizardContext; public PrinterSetupWizardPage(PrinterSetupWizard wizardContext, string headerText, string instructionsText) @@ -70,8 +72,6 @@ namespace MatterHackers.MatterControl this.AddPageAction(NextButton); } - public GuiWidget ContentRow => contentRow; - protected GuiWidget CreateTextField(string text) { return new WrappedTextWidget(text) @@ -84,7 +84,7 @@ namespace MatterHackers.MatterControl public override void OnLoad(EventArgs args) { - this.PageLoad?.Invoke(); + this.PageLoad?.Invoke(this); base.OnLoad(args); } diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/ProbeCalibrationWizard.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/ProbeCalibrationWizard.cs index 96d84b320..6a877cea8 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/ProbeCalibrationWizard.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/ProbeCalibrationWizard.cs @@ -1,5 +1,5 @@ /* -Copyright (c) 2018, Lars Brubaker, John Lewin +Copyright (c) 2019, Lars Brubaker, John Lewin All rights reserved. Redistribution and use in source and binary forms, with or without diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/UnloadFilamentWizard.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/UnloadFilamentWizard.cs index 80c0f7a5e..77aaed70f 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/UnloadFilamentWizard.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/UnloadFilamentWizard.cs @@ -1,5 +1,5 @@ /* -Copyright (c) 2018, Lars Brubaker, John Lewin +Copyright (c) 2019, Lars Brubaker, John Lewin All rights reserved. Redistribution and use in source and binary forms, with or without @@ -109,12 +109,11 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling int extruderPriorToUnload = printer.Connection.ActiveExtruderIndex; RunningInterval runningGCodeCommands = null; - PrinterSetupWizardPage unloadingFilamentPage = null; - unloadingFilamentPage = new PrinterSetupWizardPage(this, "Unloading Filament".Localize(), "") + var unloadingFilamentPage = new PrinterSetupWizardPage(this, "Unloading Filament".Localize(), "") { - PageLoad = () => + PageLoad = (page) => { - unloadingFilamentPage.NextButton.Enabled = false; + page.NextButton.Enabled = false; // add the progress bar var holder = new FlowLayoutWidget() @@ -136,7 +135,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling }; holder.AddChild(progressBar); holder.AddChild(progressBarText); - unloadingFilamentPage.ContentRow.AddChild(holder); + page.ContentRow.AddChild(holder); if (extruderCount > 1) { @@ -196,7 +195,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling && remainingLengthMm <= .001) { UiThread.ClearInterval(runningGCodeCommands); - unloadingFilamentPage.NextButton.InvokeClick(); + page.NextButton.InvokeClick(); } }, .1); diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/AutoProbeFeedback.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/AutoProbeFeedback.cs index 93570b3e5..38a3359f0 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/AutoProbeFeedback.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/AutoProbeFeedback.cs @@ -1,5 +1,5 @@ /* -Copyright (c) 2018, Lars Brubaker, John Lewin +Copyright (c) 2019, Lars Brubaker, John Lewin All rights reserved. Redistribution and use in source and binary forms, with or without diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPagelInstructions.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPagelInstructions.cs index 2dcc498f5..2554d9635 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPagelInstructions.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPagelInstructions.cs @@ -1,5 +1,5 @@ /* -Copyright (c) 2018, Lars Brubaker, John Lewin +Copyright (c) 2019, Lars Brubaker, John Lewin All rights reserved. Redistribution and use in source and binary forms, with or without diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/FindBedHeight.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/FindBedHeight.cs index 53319f2f5..9e7add7f6 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/FindBedHeight.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/FindBedHeight.cs @@ -1,5 +1,5 @@ /* -Copyright (c) 2018, Lars Brubaker, John Lewin +Copyright (c) 2019, Lars Brubaker, John Lewin All rights reserved. Redistribution and use in source and binary forms, with or without diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetCoarseBedHeight.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetCoarseBedHeight.cs index 7ec115383..84d18dc85 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetCoarseBedHeight.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetCoarseBedHeight.cs @@ -1,5 +1,5 @@ /* -Copyright (c) 2018, Lars Brubaker, John Lewin +Copyright (c) 2019, Lars Brubaker, John Lewin All rights reserved. Redistribution and use in source and binary forms, with or without diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetFineBedHeight.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetFineBedHeight.cs index 61ad81735..e19c80a63 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetFineBedHeight.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetFineBedHeight.cs @@ -1,5 +1,5 @@ /* -Copyright (c) 2018, Lars Brubaker, John Lewin +Copyright (c) 2019, Lars Brubaker, John Lewin All rights reserved. Redistribution and use in source and binary forms, with or without diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GettingThirdPointFor2PointCalibration.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GettingThirdPointFor2PointCalibration.cs index 3adf80151..90cfc8c62 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GettingThirdPointFor2PointCalibration.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GettingThirdPointFor2PointCalibration.cs @@ -1,5 +1,5 @@ /* -Copyright (c) 2018, Lars Brubaker, John Lewin +Copyright (c) 2019, Lars Brubaker, John Lewin All rights reserved. Redistribution and use in source and binary forms, with or without diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/HomePrinterPage.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/HomePrinterPage.cs index 20dad259d..805e98287 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/HomePrinterPage.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/HomePrinterPage.cs @@ -1,5 +1,5 @@ /* -Copyright (c) 2018, Lars Brubaker, John Lewin +Copyright (c) 2019, Lars Brubaker, John Lewin All rights reserved. Redistribution and use in source and binary forms, with or without diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/WaitForTempPage.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/WaitForTempPage.cs index fcb440701..f76f17746 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/WaitForTempPage.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/WaitForTempPage.cs @@ -1,5 +1,5 @@ /* -Copyright (c) 2018, Lars Brubaker, John Lewin +Copyright (c) 2019, Lars Brubaker, John Lewin All rights reserved. Redistribution and use in source and binary forms, with or without diff --git a/MatterControlLib/SetupWizard/DialogPage.cs b/MatterControlLib/SetupWizard/DialogPage.cs index b01f33194..db1a4a6bb 100644 --- a/MatterControlLib/SetupWizard/DialogPage.cs +++ b/MatterControlLib/SetupWizard/DialogPage.cs @@ -1,5 +1,5 @@ /* -Copyright (c) 2018, Lars Brubaker, John Lewin +Copyright (c) 2019, Lars Brubaker, John Lewin All rights reserved. Redistribution and use in source and binary forms, with or without From 76ceddeec0e2115b6f71c21e3c19c5b44cc085a7 Mon Sep 17 00:00:00 2001 From: John Lewin Date: Fri, 15 Feb 2019 20:26:01 -0800 Subject: [PATCH 3/6] Remove conditional MoveRelative call from old BecomingActive scope --- .../WizardPages/GetUltraFineBedHeight.cs | 24 +------------------ 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetUltraFineBedHeight.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetUltraFineBedHeight.cs index 1ae12a12b..1d73fa80c 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetUltraFineBedHeight.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GetUltraFineBedHeight.cs @@ -1,5 +1,5 @@ /* -Copyright (c) 2018, Lars Brubaker, John Lewin +Copyright (c) 2019, Lars Brubaker, John Lewin All rights reserved. Redistribution and use in source and binary forms, with or without @@ -27,18 +27,13 @@ of the authors and should not be interpreted as representing official policies, either expressed or implied, of the FreeBSD Project. */ -using System; using System.Collections.Generic; -using MatterHackers.Agg; using MatterHackers.Localizations; -using MatterHackers.MatterControl.PrinterCommunication; namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling { public class GetUltraFineBedHeight : FindBedHeight { - private bool haveDrawn = false; - public GetUltraFineBedHeight(PrinterSetupWizard context, string pageDescription, List probePositions, int probePositionsBeingEditedIndex, LevelingStrings levelingStrings) : base( @@ -51,22 +46,5 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling probePositionsBeingEditedIndex) { } - - public override void OnDraw(Graphics2D graphics2D) - { - haveDrawn = true; - base.OnDraw(graphics2D); - } - - public override void OnLoad(EventArgs args) - { - // TODO: Why conditional on haveDrawn? - if (haveDrawn) - { - printer.Connection.MoveRelative(PrinterConnection.Axis.Z, 2, printer.Settings.Helpers.ManualMovementSpeeds().Z); - } - - base.OnLoad(args); - } } } \ No newline at end of file From d035c58d106329f8daaaa29263cd26204f37da4b Mon Sep 17 00:00:00 2001 From: John Lewin Date: Fri, 15 Feb 2019 20:46:07 -0800 Subject: [PATCH 4/6] Simplify naming --- .../PrintLeveling/LoadFilamentWizard.cs | 13 ++++++------- .../PrintLeveling/PrintLevelingWizard.cs | 14 +++++++------- .../PrintLeveling/PrinterSetupWizard.cs | 4 ++-- .../PrintLeveling/ProbeCalibrationWizard.cs | 17 ++++++++--------- .../PrintLeveling/UnloadFilamentWizard.cs | 6 +++--- ...{PrinterSetupWizardPage.cs => WizardPage.cs} | 16 ++++++++-------- .../WizardPages/AutoProbeFeedback.cs | 4 +--- .../CalibrateProbeLastPagelInstructions.cs | 2 +- .../PrintLeveling/WizardPages/FindBedHeight.cs | 3 +-- .../GettingThirdPointFor2PointCalibration.cs | 2 +- .../WizardPages/HomePrinterPage.cs | 2 +- .../WizardPages/LastPageInstructions.cs | 3 +-- .../WizardPages/SelectMaterialPage.cs | 4 ++-- .../WizardPages/WaitForTempPage.cs | 2 +- 14 files changed, 43 insertions(+), 49 deletions(-) rename MatterControlLib/ConfigurationPage/PrintLeveling/{PrinterSetupWizardPage.cs => WizardPage.cs} (87%) diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/LoadFilamentWizard.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/LoadFilamentWizard.cs index 3e4840dae..ef62c6f9b 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/LoadFilamentWizard.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/LoadFilamentWizard.cs @@ -36,7 +36,6 @@ using MatterHackers.Agg; using MatterHackers.Agg.UI; using MatterHackers.Localizations; using MatterHackers.MatterControl.CustomWidgets; -using MatterHackers.MatterControl.PrinterCommunication; using MatterHackers.MatterControl.SlicerConfiguration; namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling @@ -83,7 +82,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling return extruderCount > 1 && !printer.Settings.GetValue(SettingsKey.filament_1_has_been_loaded); } - protected override IEnumerator GetWizardSteps() + protected override IEnumerator GetWizardSteps() { var extruderCount = printer.Settings.GetValue(SettingsKey.extruder_count); @@ -103,7 +102,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling // show the trim filament message { - var trimFilamentPage = new PrinterSetupWizardPage(this, "Trim Filament".Localize(), "") + var trimFilamentPage = new WizardPage(this, "Trim Filament".Localize(), "") { PageLoad = (page) => { @@ -131,7 +130,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling // show the insert filament page { RunningInterval runningGCodeCommands = null; - var insertFilamentPage = new PrinterSetupWizardPage(this, "Insert Filament".Localize(), "") + var insertFilamentPage = new WizardPage(this, "Insert Filament".Localize(), "") { PageLoad = (page) => { @@ -189,7 +188,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling // show the loading filament progress bar { RunningInterval runningGCodeCommands = null; - var loadingFilamentPage = new PrinterSetupWizardPage(this, "Loading Filament".Localize(), "") + var loadingFilamentPage = new WizardPage(this, "Loading Filament".Localize(), "") { PageLoad = (page) => { @@ -300,7 +299,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling // extrude slowly so that we can prime the extruder { RunningInterval runningGCodeCommands = null; - var runningCleanPage = new PrinterSetupWizardPage(this, "Wait For Running Clean".Localize(), "") + var runningCleanPage = new WizardPage(this, "Wait For Running Clean".Localize(), "") { PageLoad = (page) => { @@ -358,7 +357,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling } } - public class DoneLoadingPage : PrinterSetupWizardPage + public class DoneLoadingPage : WizardPage { public DoneLoadingPage(PrinterSetupWizard setupWizard, int extruderIndex) : base(setupWizard, "Success".Localize(), "Success!\n\nYour filament should now be loaded".Localize()) diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/PrintLevelingWizard.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/PrintLevelingWizard.cs index 999c52a1c..36286553d 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/PrintLevelingWizard.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/PrintLevelingWizard.cs @@ -27,14 +27,13 @@ of the authors and should not be interpreted as representing official policies, either expressed or implied, of the FreeBSD Project. */ +using System; +using System.Collections.Generic; using MatterHackers.Agg; using MatterHackers.Localizations; using MatterHackers.MatterControl.PrinterCommunication; -using MatterHackers.MatterControl.PrinterCommunication.Io; using MatterHackers.MatterControl.SlicerConfiguration; using MatterHackers.VectorMath; -using System; -using System.Collections.Generic; namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling { @@ -136,7 +135,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling }; } - protected override IEnumerator GetWizardSteps() + protected override IEnumerator GetWizardSteps() { var probePositions = new List(levelingPlan.ProbeCount); for (int j = 0; j < levelingPlan.ProbeCount; j++) @@ -152,7 +151,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling if (showWelcomeScreen) { - yield return new PrinterSetupWizardPage( + yield return new WizardPage( this, "Initial Printer Setup".Localize(), string.Format( @@ -200,7 +199,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling } } - yield return new PrinterSetupWizardPage( + yield return new WizardPage( this, "Print Leveling Overview".Localize(), buildWelcomeText()); @@ -259,7 +258,8 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling this, "Waiting For Printer To Heat".Localize(), heatingInstructions, - targetBedTemp, new double[] { targetHotendTemp }); + targetBedTemp, + new double[] { targetHotendTemp }); } double bedRadius = Math.Min(printer.Settings.GetValue(SettingsKey.bed_size).X, printer.Settings.GetValue(SettingsKey.bed_size).Y) / 2; diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizard.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizard.cs index 3d1dbc008..4499193d1 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizard.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizard.cs @@ -34,9 +34,9 @@ namespace MatterHackers.MatterControl { public abstract class PrinterSetupWizard { - private IEnumerator pages; + private IEnumerator pages; - protected abstract IEnumerator GetWizardSteps(); + protected abstract IEnumerator GetWizardSteps(); public string WindowTitle { get; internal set; } diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/ProbeCalibrationWizard.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/ProbeCalibrationWizard.cs index 6a877cea8..1f771ce34 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/ProbeCalibrationWizard.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/ProbeCalibrationWizard.cs @@ -27,13 +27,12 @@ of the authors and should not be interpreted as representing official policies, either expressed or implied, of the FreeBSD Project. */ -using MatterHackers.Agg; -using MatterHackers.Localizations; -using MatterHackers.MatterControl.PrinterCommunication.Io; -using MatterHackers.MatterControl.SlicerConfiguration; -using MatterHackers.VectorMath; using System; using System.Collections.Generic; +using MatterHackers.Agg; +using MatterHackers.Localizations; +using MatterHackers.MatterControl.SlicerConfiguration; +using MatterHackers.VectorMath; namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling { @@ -93,7 +92,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling && printer.Settings.GetValue(SettingsKey.use_z_probe); } - protected override IEnumerator GetWizardSteps() + protected override IEnumerator GetWizardSteps() { var levelingStrings = new LevelingStrings(); var autoProbePositions = new List(3); @@ -107,7 +106,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling // make a welcome page if this is the first time calibrating the probe if (!printer.Settings.GetValue(SettingsKey.probe_has_been_calibrated)) { - yield return new PrinterSetupWizardPage( + yield return new WizardPage( this, "Initial Printer Setup".Localize(), string.Format( @@ -117,7 +116,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling } // show what steps will be taken - yield return new PrinterSetupWizardPage( + yield return new WizardPage( this, "Probe Calibration Overview".Localize(), string.Format( @@ -188,7 +187,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling 0); // show what steps will be taken - yield return new PrinterSetupWizardPage( + yield return new WizardPage( this, "Measure the nozzle offset".Localize(), "{0}:\n\n\t• {1}\n\n{2}\n\n{3}".FormatWith( diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/UnloadFilamentWizard.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/UnloadFilamentWizard.cs index 77aaed70f..d1fed2514 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/UnloadFilamentWizard.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/UnloadFilamentWizard.cs @@ -69,7 +69,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling this.extruderIndex = extruderIndex; } - protected override IEnumerator GetWizardSteps() + protected override IEnumerator GetWizardSteps() { var extruderCount = printer.Settings.GetValue(SettingsKey.extruder_count); @@ -109,7 +109,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling int extruderPriorToUnload = printer.Connection.ActiveExtruderIndex; RunningInterval runningGCodeCommands = null; - var unloadingFilamentPage = new PrinterSetupWizardPage(this, "Unloading Filament".Localize(), "") + var unloadingFilamentPage = new WizardPage(this, "Unloading Filament".Localize(), "") { PageLoad = (page) => { @@ -224,7 +224,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling } } - public class DoneUnloadingPage : PrinterSetupWizardPage + public class DoneUnloadingPage : WizardPage { public DoneUnloadingPage(PrinterSetupWizard setupWizard, int extruderIndex) : base(setupWizard, "Success".Localize(), "Success!\n\nYour filament should now be unloaded".Localize()) diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizardPage.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPage.cs similarity index 87% rename from MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizardPage.cs rename to MatterControlLib/ConfigurationPage/PrintLeveling/WizardPage.cs index 08597ab2b..4bc5217e8 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/PrinterSetupWizardPage.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPage.cs @@ -35,22 +35,22 @@ using MatterHackers.MatterControl.CustomWidgets; namespace MatterHackers.MatterControl { - public class PrinterSetupWizardPage : DialogPage + public class WizardPage : DialogPage { public TextButton NextButton { get; } protected PrinterConfig printer; - public Action PageLoad { get; set; } + public Action PageLoad { get; set; } public Action PageClose { get; set; } - protected PrinterSetupWizard wizardContext; + protected PrinterSetupWizard wizardPage; - public PrinterSetupWizardPage(PrinterSetupWizard wizardContext, string headerText, string instructionsText) + public WizardPage(PrinterSetupWizard wizardPage, string headerText, string instructionsText) { - this.wizardContext = wizardContext; - this.printer = wizardContext.Printer; - this.WindowTitle = wizardContext.WindowTitle; + this.wizardPage = wizardPage; + this.printer = wizardPage.Printer; + this.WindowTitle = wizardPage.WindowTitle; this.HeaderText = headerText; if (!string.IsNullOrEmpty(instructionsText)) @@ -66,7 +66,7 @@ namespace MatterHackers.MatterControl }; NextButton.Click += (s, e) => { - wizardContext.ShowNextPage(this.DialogWindow); + wizardPage.ShowNextPage(this.DialogWindow); }; this.AddPageAction(NextButton); diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/AutoProbeFeedback.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/AutoProbeFeedback.cs index 38a3359f0..29081d926 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/AutoProbeFeedback.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/AutoProbeFeedback.cs @@ -31,16 +31,14 @@ using System; using System.Collections.Generic; using System.Linq; using MatterControl.Printing; -using MatterHackers.Agg; using MatterHackers.Agg.UI; using MatterHackers.MatterControl.PrinterCommunication; -using MatterHackers.MatterControl.PrinterCommunication.Io; using MatterHackers.MatterControl.SlicerConfiguration; using MatterHackers.VectorMath; namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling { - public class AutoProbeFeedback : PrinterSetupWizardPage + public class AutoProbeFeedback : WizardPage { private Vector3 lastReportedPosition; private List probePositions; diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPagelInstructions.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPagelInstructions.cs index 2554d9635..c2a16f08a 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPagelInstructions.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPagelInstructions.cs @@ -38,7 +38,7 @@ using MatterHackers.MatterControl.SlicerConfiguration; namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling { - public class CalibrateProbeLastPagelInstructions : PrinterSetupWizardPage + public class CalibrateProbeLastPagelInstructions : WizardPage { private bool pageWasActive = false; diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/FindBedHeight.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/FindBedHeight.cs index 9e7add7f6..a866c5f9d 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/FindBedHeight.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/FindBedHeight.cs @@ -34,12 +34,11 @@ using MatterHackers.Agg; using MatterHackers.Agg.UI; using MatterHackers.Localizations; using MatterHackers.MatterControl.PrinterCommunication; -using MatterHackers.MatterControl.PrinterCommunication.Io; using MatterHackers.VectorMath; namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling { - public class FindBedHeight : PrinterSetupWizardPage + public class FindBedHeight : WizardPage { private Vector3 lastReportedPosition; private List probePositions; diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GettingThirdPointFor2PointCalibration.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GettingThirdPointFor2PointCalibration.cs index 90cfc8c62..f26e147e6 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GettingThirdPointFor2PointCalibration.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/GettingThirdPointFor2PointCalibration.cs @@ -35,7 +35,7 @@ using MatterHackers.VectorMath; namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling { - public class GettingThirdPointFor2PointCalibration : PrinterSetupWizardPage + public class GettingThirdPointFor2PointCalibration : WizardPage { protected Vector3 probeStartPosition; private ProbePosition probePosition; diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/HomePrinterPage.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/HomePrinterPage.cs index 805e98287..4bfdd3f08 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/HomePrinterPage.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/HomePrinterPage.cs @@ -34,7 +34,7 @@ using MatterHackers.MatterControl.SlicerConfiguration; namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling { - public class HomePrinterPage : PrinterSetupWizardPage + public class HomePrinterPage : WizardPage { private bool autoAdvance; diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/LastPageInstructions.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/LastPageInstructions.cs index 77980a87d..4f453bfbf 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/LastPageInstructions.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/LastPageInstructions.cs @@ -34,12 +34,11 @@ using MatterHackers.Agg.Platform; using MatterHackers.Agg.UI; using MatterHackers.Localizations; using MatterHackers.MatterControl.PrinterCommunication; -using MatterHackers.MatterControl.PrinterCommunication.Io; using MatterHackers.MatterControl.SlicerConfiguration; namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling { - public class LastPageInstructions : PrinterSetupWizardPage + public class LastPageInstructions : WizardPage { private List probePositions; diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/SelectMaterialPage.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/SelectMaterialPage.cs index 1e4dc59c1..4677ab39e 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/SelectMaterialPage.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/SelectMaterialPage.cs @@ -34,7 +34,7 @@ using MatterHackers.MatterControl.SlicerConfiguration; namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling { - public class SelectMaterialPage : PrinterSetupWizardPage + public class SelectMaterialPage : WizardPage { public SelectMaterialPage(PrinterSetupWizard context, string headerText, string instructionsText, string nextButtonText, int extruderIndex, bool showLoadFilamentButton, bool showAlreadyLoadedButton) : base(context, headerText, instructionsText) @@ -59,7 +59,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling }; loadFilamentButton.Click += (s, e) => { - wizardContext.ShowNextPage(this.DialogWindow); + wizardPage.ShowNextPage(this.DialogWindow); }; this.AddPageAction(loadFilamentButton); diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/WaitForTempPage.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/WaitForTempPage.cs index f76f17746..4e674ef2a 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/WaitForTempPage.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/WaitForTempPage.cs @@ -38,7 +38,7 @@ using MatterHackers.MatterControl.SlicerConfiguration; namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling { - public class WaitForTempPage : PrinterSetupWizardPage + public class WaitForTempPage : WizardPage { private ProgressBar bedProgressBar; private TextWidget bedProgressBarText; From edba8b333f73695d2dd3a78ddb23febd3bc07dfd Mon Sep 17 00:00:00 2001 From: John Lewin Date: Fri, 15 Feb 2019 21:03:01 -0800 Subject: [PATCH 5/6] Fix naming error --- .../ConfigurationPage/PrintLeveling/WizardPage.cs | 12 ++++++------ .../PrintLeveling/WizardPages/SelectMaterialPage.cs | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPage.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPage.cs index 4bc5217e8..8af7b5004 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPage.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPage.cs @@ -44,13 +44,13 @@ namespace MatterHackers.MatterControl public Action PageClose { get; set; } - protected PrinterSetupWizard wizardPage; + protected PrinterSetupWizard setupWizard; - public WizardPage(PrinterSetupWizard wizardPage, string headerText, string instructionsText) + public WizardPage(PrinterSetupWizard setupWizard, string headerText, string instructionsText) { - this.wizardPage = wizardPage; - this.printer = wizardPage.Printer; - this.WindowTitle = wizardPage.WindowTitle; + this.setupWizard = setupWizard; + this.printer = setupWizard.Printer; + this.WindowTitle = setupWizard.WindowTitle; this.HeaderText = headerText; if (!string.IsNullOrEmpty(instructionsText)) @@ -66,7 +66,7 @@ namespace MatterHackers.MatterControl }; NextButton.Click += (s, e) => { - wizardPage.ShowNextPage(this.DialogWindow); + setupWizard.ShowNextPage(this.DialogWindow); }; this.AddPageAction(NextButton); diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/SelectMaterialPage.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/SelectMaterialPage.cs index 4677ab39e..3551b50fc 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/SelectMaterialPage.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/SelectMaterialPage.cs @@ -59,7 +59,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling }; loadFilamentButton.Click += (s, e) => { - wizardPage.ShowNextPage(this.DialogWindow); + setupWizard.ShowNextPage(this.DialogWindow); }; this.AddPageAction(loadFilamentButton); From b53e34d8f473f381cc9ff12f02782db9bf15fc54 Mon Sep 17 00:00:00 2001 From: John Lewin Date: Fri, 15 Feb 2019 21:04:45 -0800 Subject: [PATCH 6/6] Fix typo --- .../PrintLeveling/ProbeCalibrationWizard.cs | 2 +- ...Instructions.cs => CalibrateProbeLastPageInstructions.cs} | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) rename MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/{CalibrateProbeLastPagelInstructions.cs => CalibrateProbeLastPageInstructions.cs} (94%) diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/ProbeCalibrationWizard.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/ProbeCalibrationWizard.cs index 1f771ce34..805b9c75c 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/ProbeCalibrationWizard.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/ProbeCalibrationWizard.cs @@ -267,7 +267,7 @@ namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling printer.Connection.QueueLine($"T{extruderPriorToMeasure}"); } - yield return new CalibrateProbeLastPagelInstructions( + yield return new CalibrateProbeLastPageInstructions( this, "Done".Localize()); } diff --git a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPagelInstructions.cs b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPageInstructions.cs similarity index 94% rename from MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPagelInstructions.cs rename to MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPageInstructions.cs index c2a16f08a..9cb717173 100644 --- a/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPagelInstructions.cs +++ b/MatterControlLib/ConfigurationPage/PrintLeveling/WizardPages/CalibrateProbeLastPageInstructions.cs @@ -28,7 +28,6 @@ either expressed or implied, of the FreeBSD Project. */ using System; -using System.Collections.Generic; using System.IO; using MatterHackers.Agg.Platform; using MatterHackers.Agg.UI; @@ -38,11 +37,11 @@ using MatterHackers.MatterControl.SlicerConfiguration; namespace MatterHackers.MatterControl.ConfigurationPage.PrintLeveling { - public class CalibrateProbeLastPagelInstructions : WizardPage + public class CalibrateProbeLastPageInstructions : WizardPage { private bool pageWasActive = false; - public CalibrateProbeLastPagelInstructions(PrinterSetupWizard context, string headerText) + public CalibrateProbeLastPageInstructions(PrinterSetupWizard context, string headerText) : base(context, headerText, "") { var calibrated = "Your Probe is now calibrated.".Localize() + "\n"