From 2dfb8dea10d5952b2bb4f01d686328ddfda9a02a Mon Sep 17 00:00:00 2001 From: John Lewin Date: Sat, 30 Dec 2017 09:34:35 -0800 Subject: [PATCH] Add notes around concerns --- PrinterCommunication/PrinterConnection.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/PrinterCommunication/PrinterConnection.cs b/PrinterCommunication/PrinterConnection.cs index 64bb4f7b6..82e7a7d15 100644 --- a/PrinterCommunication/PrinterConnection.cs +++ b/PrinterCommunication/PrinterConnection.cs @@ -1023,6 +1023,7 @@ namespace MatterHackers.MatterControl.PrinterCommunication // Call instance event ConnectionSucceeded.CallEvents(this, null); + // TODO: Shouldn't we wait to start reading until after we create the stream pipeline? Console.WriteLine("ReadFromPrinter thread created."); ReadThread.Start(this); @@ -1030,10 +1031,13 @@ namespace MatterHackers.MatterControl.PrinterCommunication CommunicationState = CommunicationStates.Connected; + // TODO: Couldn't we send something simple like a few ms dwell or something having less effect? // We have to send a line because some printers (like old print-r-bots) do not send anything when connecting and there is no other way to know they are there. SendLineToPrinterNow("M110 N1"); + // TODO: Why clear after send? ClearQueuedGCode(); + // We do not need to wait for the M105 PrintingCanContinue(null, null); }