Commit graph

675 commits

Author SHA1 Message Date
Michael Gratton
b5f27dce79 Add UI and implement saving details and logs to file 2019-04-08 18:05:03 +10:00
Michael Gratton
0e4486bbf4 Make Copy button copy selected log rows, make it less prominent 2019-04-08 18:05:03 +10:00
Michael Gratton
1b121e0a8e Update the UI when the switcher pane changes 2019-04-08 18:05:03 +10:00
Michael Gratton
1f4ef0ab95 Display all known logs in inspector 2019-04-08 18:05:03 +10:00
Michael Gratton
ae4d7655b0 Add basic Geary Inspector, hook it up to Alt+Shift+I 2019-04-08 18:05:03 +10:00
Michael Gratton
433215570b Make generic account editor ListBoxRow style reusable elsewhere 2019-04-08 18:05:03 +10:00
Michael Gratton
ffaa43cbfe Tweak spoofed email warning UI 2019-04-08 10:26:04 +10:00
Michael Gratton
10051e0354 Implement spoofed email address UI for ContactsPopover 2019-04-08 10:26:04 +10:00
Michael Gratton
68b2da17c5 Separate and implement contact popover action from conversation message
This leads to a minor bit of UI string and code duplication, but
substantially reduces the complexity of implementing the popover's
actions. Hook up all remaining actions except open and save.
2019-04-08 10:26:04 +10:00
Michael Gratton
258b68b7e7 Update ContactPopover depending on if the contact is from the desktop
Show the appropriate menu and star/unstar buttons.
2019-04-08 10:26:04 +10:00
Michael Gratton
e144617b9a Update conversation message menus and actions for contact popover
Add new menu items per the design. Rename actions to match and to be
compliant with action name spec.
2019-04-08 10:22:58 +10:00
Michael Gratton
680f46c77a Add initial contact popover UI and implementation 2019-04-08 10:22:58 +10:00
Jiří Černý
1a6113efa4 Ignore style nodes while converting HTML to text 2019-04-05 09:45:14 +02:00
Michael Gratton
8f04e4cc36 Fix switches in the accounts editor looking squashed
Don't apply CSS padding to all image widget descendants of an editor row
since switches and other stock widgets also use them internally.

Fixes #299
2019-03-30 15:40:50 +11:00
Michael Gratton
59ef85ca4b Merge branch 'fix-lgtm-warnings' into 'master'
Fix LGTM warnings

See merge request GNOME/geary!176
2019-03-24 03:07:52 +00:00
Konstantin Kharlamov
585c7ba5bc conversation-web-view: de-globalize a variable
Implicitly declared variables in JS are global by default.

Fixes LGTM warning: "Variable header is used like a local variable, but
is missing a declaration."

Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
2019-03-23 13:42:36 +03:00
Konstantin Kharlamov
65af96a499 composer-web-view: add missing semicolon after field assignment
Fixes LGTM warning: "Avoid automated semicolon insertion (93% of all
statements in the enclosing script have an explicit semicolon)."

Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
2019-03-23 13:42:36 +03:00
Konstantin Kharlamov
0f773f9e21 composer-web-view: remove unused variable
Fixes LGTM warning "Unused variable state."

Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
2019-03-23 13:42:36 +03:00
Michael Gratton
ec14a0c98d Use a single timer to make sure relative email dates get updated
Move the timer from ConversationListStore to MainWindow, ensure that
both the list and the viewer get their dates updated, but only when
the main window is visible.
2019-03-23 15:26:03 +11:00
Michael Gratton
12c6bbca56 Fix signature not being updated when composer first opened without one
The ComposerPageState JS object assumed that if no signature was present
when first loaded, that none ever would be. This broke changing the
signature when the composer was opened for an account without one, and
the from account was changed to an account with a sig.

Instead of including the signature as part of the loaded body, always
include just a skeleton signature DIV and ensure the signature is loaded
dynamically after the body has been loaded. Update code and tests to
match this assumption, and add a unit test for updating the sig.

Fixes #309
2019-03-11 12:19:57 +11:00
Michael Gratton
f9ef6492ec Don't bother setting default icon for the ConversationMessage avatar
Since we are now using the GNOME 3.32 initals when there is no avatar
in Folks, it will never be displayed.
2019-03-09 20:17:01 +11:00
Michael Gratton
d93e5fe879 Update avatar size to be 48px, per recommendation
See #269
2019-03-09 20:17:01 +11:00
Michael Gratton
85fd1bbb0f Remove unused variable 2019-03-06 20:18:44 +11:00
Michael Gratton
9ed81ed759 Remove default instance of ClientWebView's PageState JS object
This default instance was causing double the number of preferred height
events, which was likely creating a race for ConversationWebView. This
might (should?) fix plain text email with quotes sometimes showing up
with a vastly incorrect height.

To ensure that a PageState is constructed properly, make ClientWebView
abstract and use replace the one direct use of the class in the accounts
editor for the signature with a new subclass.

See #283
2019-03-06 20:11:33 +11:00
Michael Gratton
9190c2c8e3 Remove single-key accel "n" for Compose action
Fixes #273
2019-02-26 09:21:01 +11:00
Michael Gratton
fb28fcf4e6 Chase action name change for Compose button in toolbar
Fixes #274
2019-02-26 09:20:20 +11:00
p3732
8f1c243a2d Remove separator in main menu
Put Accounts in the same section as Preferences.
2019-02-24 16:19:07 +11:00
p3732
04be9ae321 Merge empty menu into main menu
Remove empty menu and move entries to new main menu.
2019-02-24 16:19:07 +11:00
p3732
161aa2a818 Retire app menu
Removing the app menu, see https://gitlab.gnome.org/GNOME/Initiatives/issues/4
2019-02-24 16:19:07 +11:00
p3732
af615c2c7e Add main menu to sidebar
Add main menu to the folder header, as described on https://gitlab.gnome.org/GNOME/Initiatives/wikis/App-Menu-Retirement#3-applications-that-use-a-sidebar-for-navigation
The "About" string changed to "About Geary" and needs to be retranslated.
2019-02-24 16:19:07 +11:00
Michael Gratton
ba61ed3b8a Add translation context to Compose Message toolbar tooltip 2019-02-22 14:11:05 +11:00
Kristian Klausen
31919cb4ca Add missing tooltip for compose message button 2019-02-20 16:39:37 +01:00
Joel Duncan
ab555ed28d Add margin_bottom padding to composer_toolbar 2019-02-18 00:16:22 +00:00
Michael Gratton
e490905b21 Merge branch 'wip/composer-shortcuts' into 'master'
Refine composer shortcuts

See merge request GNOME/geary!106
2019-02-13 14:31:21 +00:00
Michael Gratton
e8dc1af45e Scope composer editor shortcuts to the toolbar and web view only
This prevents something like Ctrl+I being typed in the subject line
triggering italic in the editor.
2019-02-13 23:25:58 +11:00
Michael Gratton
9eead5d145 Replace composer keyboard shortcut with standard widget action scoping
Rather than adding and removing shortcuts when the composer's web view
gains and loses focus to avoid invoking main window shortcuts, just
rely on standard GTK action scoping rules.

This fixes editing shortcuts like Ctrl+I breaking when clicking on
toolbar buttons, a crasher because the composer left the undo button
enabled after it was closed, and allows Escape to close the composer
from anywherre.

Fixes https://bugzilla.gnome.org/show_bug.cgi?id=774651,
https://bugzilla.gnome.org/show_bug.cgi?id=785187, and
https://bugzilla.gnome.org/show_bug.cgi?id=741741
2019-02-13 23:25:58 +11:00
Michael Gratton
8098f42cb2 Merge branch 'master' into 'master'
Issue #45 Fix

See merge request GNOME/geary!103
2019-02-13 08:36:01 +00:00
john
7a37a4650b Fix serveral things for the MR 2019-02-12 14:49:44 +08:00
Michael Gratton
1807a187bd Unify three variants of "try reconnecting" strings
See #210
2019-02-11 08:19:43 +11:00
john
07d69956d2 Merge branch 'master' of gitlab.gnome.org:799433746/geary 2019-02-10 21:51:27 +08:00
john
e3f1c364f8 Merge remote-tracking branch 'upstream/master' 2019-02-10 21:49:15 +08:00
799433746
fca31abcd2 Update client-web-view.js minimal change 2019-02-10 04:50:51 +00:00
john
6c53e003bc A small typo... 2019-02-10 12:37:19 +08:00
john
46cd8baed1 Avoiding add signal into the EmailRow, but translate seems hard to do since the webview is in the inside of message. 2019-02-10 12:19:05 +08:00
Alex Henrie
67d819565e Don't add Geary-flavored markdown to plain text messages
Fixes #201
2019-02-08 23:16:01 -07:00
john
cb01fafe3f 成功定位坐标 2019-02-09 11:09:56 +08:00
Michael Gratton
0f554d2371 Fix select-quoting not preserving newlines in some cases
If the common ancestor of the quoted text is the plain-text-message DIV
itself, the isDescendant test fails and the style to preserve new lines
is not maintained. This adds a non-strict check to isDescendant and
enables that when checking the common ancestor node and a test case for
it.
2019-02-02 15:07:41 +11:00
Michael Gratton
c83f07a9f1 Minor tweaks for ConversationPageState.isDescendantOf
Use uppercase since that is what the DOM for HTML defaults to, use
nodeName rather than tagName for cases when there the check is false and
ancestor is the document element, add unit tests.
2019-02-02 15:07:41 +11:00
Michael Gratton
44d871f6f1 Merge branch 'is-descendant-of' into 'master'
Check class name in ConversationPageState.isDescendantOf

See merge request GNOME/geary!77
2019-02-02 04:00:56 +00:00
Michael Gratton
4b3c167689 Merge branch 'wip/conversation-polish' into 'master'
More conversation polish

Closes #80

See merge request GNOME/geary!92
2019-02-02 02:26:38 +00:00