Commit graph

9 commits

Author SHA1 Message Date
Eric Gregory
ddbd4c7213 Closes #5745 libgee 0.8 2013-04-24 12:22:32 -07:00
Charles Lindsay
910e1c3d0b Update copyright headers; fix #6195
Also removing the erroneous space that had crept in at the end of the
line in most of our header comments.
2013-04-12 12:32:39 -07:00
Jim Nelson
826e9d5f3a Memory leak and lost reference tracking: Refs #5306
This patch solves the following memory/resource leak problems:

(a) Gee.TreeSet doesn't drop references when destroyed.  Fixed by
using a subclass that clears the set when destroyed (exactly same
as patch made to Gee, however that won't be in distribution for
awhile.)

(b) Imap.ClientSession was holding refs to CommandResponses after
they'd been completed.  They're now dropped.

(c) Imap.ClientSessionManager now has an open/close_async() (called
by Imap.Account.open/close_async()) that drops all ClientSessions.

(d) All classes in Engine (and some in the client) use Geary.BaseObject,
which uses a static map to track outstanding held references to
it.  The table is dumped when Geary exits.  Must be enabled with a
./configure flag.

Two outstanding memory leaks persist (one for Imap.ResponseCodes and
another when messages are selected/deselected), so this doesn't close
the ticket, but testing and use has shown these changes to make a huge
improvement on memory usage and reducing crashes.
2013-03-07 18:08:50 -08:00
Jim Nelson
327d183b8f Message marked read while connecting go unread later: Closes #5571
Bug was due to current flag on server being updated in local database
after the local operation had made a different change and was waiting
for normalization to complete to make the change on the server.
ReplayQueue now has a notion of a writebehind operation, which means
an immediate local change that a ReplayOperation waiting to make on
the remote must now account for.
2012-09-13 16:17:58 -07:00
Nate Lillich
7fb7cefaee Fixes #3771. This adds the ability to star or unstar messages from various locations. 2012-04-13 11:03:26 -07:00
Jim Nelson
368e94be8e Fixes bug where changes to flags (i.e. Unread or Flagged) was not
reported to client when discovered at folder open.
2012-02-14 17:09:17 -08:00
Adam Dingle
281f29bc77 Updated copyrights to 2012. Closes #4564 2012-01-10 10:40:34 -08:00
Eric Gregory
049a718c34 Archive/delete and mark unread now use ReplayQueue. Closes #4526 2012-01-09 10:58:13 -08:00
Eric Gregory
e784d1b9b3 Signal for updating EmailFlags. Closes #4478 2011-12-13 16:13:20 -08:00