This has been a problem in the past, and it usually has to do with
shutting down the ClientSession or ClientConnection while connecting.
That is true here too. (In this case, it's due to the request being
cancelled while connecting.) This uses the ClientSession's FSM's to
better deal with the case and move the ClientSession to a BROKEN
state where it belongs. There's also some code in ClientConnection
to ensure that if connect_async() fails, no resource leaks occur.
Squashed commit of the following:
commit 6ea008fef96bc5d4b141c4735dc90e629d04675d
Author: Eric Gregory <eric@yorba.org>
Date: Mon Jan 28 12:00:55 2013 -0800
Add missing glade files to install
Squashed commit of the following:
commit e7af3b721314513fc6ea2eb57d10086e4f1e148b
Author: Eric Gregory <eric@yorba.org>
Date: Mon Jan 28 16:53:56 2013 -0800
Account dialog is back to being modal
commit cdd214070e67dc735c819df06c46a1d128ef20d2
Author: Eric Gregory <eric@yorba.org>
Date: Fri Jan 25 18:14:17 2013 -0800
Fix for password issue
commit 847da391373357bbca90ef6d8028ea8ff85458f1
Author: Eric Gregory <eric@yorba.org>
Date: Fri Jan 25 17:20:12 2013 -0800
Merging in changes
commit 7745ac1426fb8560624fed752de0ee162f97bd9e
Author: Eric Gregory <eric@yorba.org>
Date: Fri Jan 25 15:53:49 2013 -0800
Changes from code review
commit d7727544aaeacceb5c9b0ac3444a6db0311929db
Author: Eric Gregory <eric@yorba.org>
Date: Thu Jan 24 17:10:18 2013 -0800
Account editing, various account management bug fixes
Squashed commit of the following:
commit 9167aeb56be6789d49a3e7cdba2a21d2b015e40d
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 25 16:11:20 2013 -0800
Fix for code guidelines
commit 7612a7ddc3df14ef207b9e74ee32fa23710e1ce9
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 25 15:26:48 2013 -0800
Fix code review issues
commit 46635544c98df7a8b6c76f028715814907274389
Merge: 30b611e 6de36ae
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 25 12:54:03 2013 -0800
Merge branch 'master' into pluggable-auth
commit 30b611ed415fe7a2c1d62746f94620132ec86623
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 24 17:12:24 2013 -0800
Only prompt for IMAP password on startup
commit ca2953b4b33cb367c060164df9f2258217e94046
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 24 16:34:39 2013 -0800
Fix compile errors; cleanup
commit 545764a6a914ff36a1ca187444d0830a28502bab
Merge: 0460a68 e498354
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 24 16:31:43 2013 -0800
Merge branch 'master' into pluggable-auth
Conflicts:
src/client/geary-application.vala
commit 0460a68af4de3e762522fd641c16675cfc7d2241
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 24 16:20:31 2013 -0800
Use Engine's mediator implicitly
commit 22cbb8740e711ca3151b0389aef9cbb8c21928c7
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 24 16:19:55 2013 -0800
Use flags on things that are supposed to be flags
commit 4dc0eb15d2fe23c92d8cc6cff8a3138b6cb1baf4
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 24 15:49:50 2013 -0800
Fix prompting in certain cases
commit 56bb2265a6635a754b9a00b469ec457105390896
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 24 14:37:12 2013 -0800
Fix typo
commit 926f47024f1280271bc36cd8c60eb948bed4a432
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 24 11:43:05 2013 -0800
Cleanup, compile, smoke test
commit 9ff4257d125e67828f0c813e0806d3d34c114550
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 18 10:41:17 2013 -0800
First stab at new pluggable auth API
Although a duplicate of #4639, where we decided not to implement this
feature in lieu of implementing #5137 (compress collapsed read messages),
since we don't know when that will be ready, this is a good stop-gap,
as current behavior is annoying with long conversations. Andrea's
code is cleanly delineated from the other code, and should be easily
removed if/when the time comes.
Squashed commit of the following:
commit 42968d6060a0952525a8d6cc831e6d8b2968f414
Author: Jim Nelson <jim@yorba.org>
Date: Thu Jan 17 15:04:48 2013 -0800
Final piece of Robert's patch that I missed
These changes make it so the message can be marked as unread
by the user and then won't get marked read again if the user scrolls.
commit d4f35121ec7956da30655642dfb4db1b92fb2133
Author: Jim Nelson <jim@yorba.org>
Date: Wed Jan 16 17:09:53 2013 -0800
Removed CSS and animation code from patch.
There have been some questions about the animation and CSS changes
internally, so I'd like to break that change out into a separate
ticket. Additionally, there's enough change here to get this right
that I'd like to minimize the final merged code.
commit 838af3835c0eabee1d10587280f793a9f40a149b
Author: Jim Nelson <jim@yorba.org>
Date: Wed Jan 16 17:04:49 2013 -0800
Merge of Robert Schroll's last two patches in #5352.
Squashed commit of the following:
commit 3b133030800699c2106bfb30a104cd58710cf245
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 17 12:06:11 2013 -0800
Clean up state on close; ref #6208
commit a4637a49277740b64ac198fa057eb52556c80efa
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 17 11:58:22 2013 -0800
Simplify build_folder; ref #6208
commit e9afa248ce525f0496220cfbb0d8529e38cbceae
Author: Charles Lindsay <chaz@yorba.org>
Date: Wed Jan 16 18:10:00 2013 -0800
Cleanup; ref #6208
commit 95ee3a2c6fcfd4b9b7e10aae1100fe7a8697c25a
Author: Charles Lindsay <chaz@yorba.org>
Date: Wed Jan 16 18:02:02 2013 -0800
Aggregate building folders; ref #6208
commit 28ee5df718e08c0121b26b1934b619a409fb451a
Author: Charles Lindsay <chaz@yorba.org>
Date: Wed Jan 16 16:49:17 2013 -0800
Make local-only folders available; ref #6208
This also slightly cleans up the special-casing of local-only folders.
commit 19c48fe657fca989fe0b519d39833dd8e0d95cfe
Author: Charles Lindsay <chaz@yorba.org>
Date: Wed Jan 16 15:44:55 2013 -0800
Use new interface; ref #6208
commit f64f82f9362a0081a3e4f7a21dc401f3d4ca320f
Author: Charles Lindsay <chaz@yorba.org>
Date: Mon Jan 14 17:11:04 2013 -0800
Try new interface in Account; ref #6208
Squashed commit of the following:
commit 2e7b026f5865d84f369288a70d86c44e07e8c3b1
Merge: 08c6691 c476669
Author: Jim Nelson <jim@yorba.org>
Date: Wed Jan 16 15:24:35 2013 -0800
Merge branch 'master' into bug/6099-view-images
commit 08c6691c5c466448710a5b055676778348650b86
Author: Jim Nelson <jim@yorba.org>
Date: Wed Jan 16 15:06:00 2013 -0800
Updates in response to Eric's code review
commit 9694e0a4d678b3b0674e9970b8f3b840937955f3
Author: Jim Nelson <jim@yorba.org>
Date: Wed Jan 16 14:17:12 2013 -0800
Merge of Andrea Corbellini's patch for #6099
The merge had to be done by hand because of a recent refactoring of
the ConversationViewer and ConversationWebView.
Squashed commit of the following:
commit eea88280df6df7c2dbe8683e2593d283eaa04fa9
Author: Eric Gregory <eric@yorba.org>
Date: Tue Jan 15 17:05:52 2013 -0800
Ref #6226 Fixes left-clicks in composer window
Squashed commit of the following:
commit e4247cc1f1d6737c9a22a2e7a79de46b5da46970
Merge: a3ae5f0 3467c72
Author: Charles Lindsay <chaz@yorba.org>
Date: Tue Jan 15 13:26:20 2013 -0800
Merge branch 'master' into fix-startup
commit a3ae5f01c32f53983235f881fedb99154f5fa0b5
Author: Charles Lindsay <chaz@yorba.org>
Date: Tue Jan 15 13:25:51 2013 -0800
Mark vars as nullable for semantics
commit ad06fc6ba24d07abb4b2d8728f4a1d34ba0efbd8
Author: Charles Lindsay <chaz@yorba.org>
Date: Mon Jan 14 18:01:29 2013 -0800
Fix errors when cancelling acct. dialog; ref #6220
commit 0df1f33ea013ca370c4aa0416563700b92100f55
Author: Charles Lindsay <chaz@yorba.org>
Date: Mon Jan 14 17:28:06 2013 -0800
Create geary user directory on startup; ref #6220
Squashed commit of the following:
commit 6e066374da45dd602ee1ca3c9bc5f77b9411b6f4
Author: Eric Gregory <eric@yorba.org>
Date: Tue Jan 15 11:36:32 2013 -0800
Closes#6209 Precise support for GIR WebKitGTK binding. Rolls back to deprecated context menu in composer for compatibility with WebKitGTK 1.8
Squashed commit of the following:
commit 7e1f96baf981d15a5fe5bae0571a1c57f26f4bba
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 11 14:25:25 2013 -0800
Unset before remove account; ref #6197
This is the last code change requested.
commit 6e70c64e1b8ee51da5ab34ae7f17e77fc5fa929b
Author: Charles Lindsay <chaz@yorba.org>
Date: Fri Jan 11 11:22:37 2013 -0800
Clean up engine refactoring; ref #6197
commit ac76bb86cfbc54c1f21bb48de6cabd1f53171320
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 10 16:16:54 2013 -0800
Clean up Engine refactoring work; ref #6197
commit 3bc3587d4343e0fe456528275a2504fd1fb22ad6
Author: Charles Lindsay <chaz@yorba.org>
Date: Thu Jan 10 12:46:33 2013 -0800
Refactor Geary.Engine; ref #6197
This is workable, but probably needs some cleanup.
This handles the case where autocomplete provides an address but the
Send button doesn't go active. Still keeping the ticket open to handle
the case where the user manually enters such a string (or, more likely,
pastes it in from an external source).
Previously, when having some trouble with synchronization and unsolicited
notifications of appended messages, ImapEngine.GenericFolder would use
a broad FETCH range to ensure it received all messages. The problem
with this is that if several unsolicited appends come in back-to-back,
the same message(s) may be fetched before the dust settles.
This patch uses a more precise request for messages by a specific range.
This sets up more sophisticated TLS certificate error handling but
doesn't introduce the key component, allowing the user to accept
or deny a certificate (see #5209). Geary used to fail on UNKNOWN_CA
certificate errors, causing a lot of grief for a lot of people.
Now *all* TLS certificate errors are logged as messages, but none
cause an error.
This is not an ideal situation, but better than simply denying the
use of the app for self-signed servers.
A problem reported in #5998 appears to be that GSettings isn't
setting configuration values at exit, although it's doing it
here for us. This adds some debug for the user to test out.
The SMTP authentication method was being selected after initial
establishment of the session. For the user's server, it was
reporting no AUTH methods available, and so PLAIN was selected.
However, after STARTTLS, the user's server reported only LOGIN,
causing the problem.
Smtp.ClientConnection now offers an establish_connection_async()
method which goes through all the steps to ensure quality-of-service
and security is set up.
The ticket lists two problems, crashing and an inability to open
messages (due to Geary continuously reconnecting to the server,
which is due to a FETCH command timing out). IDLE cannot be used
with Dovecot servers as it creates the same situation ticket #5224
seeks to avoid. Essentially, if pipelining is turned off, so should
IDLE, as ClientConnection pipelines the IDLE command.
