nettika/geary
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Hack around double Content-Type header GMime bug

Browse source 
GMime has a bug where if you remove a header from a freshly parsed
message, it'll add a second Content-Type header.

See https://bugzilla.gnome.org/show_bug.cgi?id=724702.

Closes: bgo #724329
This commit is contained in:
Charles Lindsay 2014-02-18 16:35:59 -08:00
parent 641856983e
commit cb36fa5176
1 changed files with 13 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/engine/rfc822/rfc822-message.vala
View file

@ -211,8 +211,21 @@ public class Geary.RFC822.Message : BaseObject {
error("Error creating a memory buffer from a message: %s", e.message);
}
// GMime also drops the ball for the *new* message. When it comes out of the GMime
// Parser, its "mime part" somehow isn't realizing it has a Content-Type header
// already, so whenever you manipulate the headers, it adds a duplicate one. This
// odd looking hack ensures that any header manipulation is done while the "mime
// part" is an empty object, and when we re-set the "mime part", there's only the
// one Content-Type header. In other words, this hack prevents the duplicate
// header, somehow.
GMime.Object original_mime_part = message.get_mime_part();
GMime.Message empty = new GMime.Message(true);
message.set_mime_part(empty.get_mime_part());
message.remove_header(HEADER_BCC);
bcc = null;
message.set_mime_part(original_mime_part);
}
private GMime.Object? coalesce_parts(Gee.List<GMime.Object> parts, string subtype) {