From c1cbd6e1116d8dea423b91e802e5c8d5eebaa911 Mon Sep 17 00:00:00 2001 From: Michael Catanzaro Date: Wed, 25 Aug 2021 10:23:26 -0500 Subject: [PATCH] util-logging: fix fatal warnings logic If fatal criticals are enabled, we should not crash on a simple warning, because warnings are normal and less serious than criticals. If fatal warnings are enabled, we should definitely crash on criticals, because criticals indicate undefined behavior and are more serious than warnings. --- src/engine/util/util-logging.vala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/engine/util/util-logging.vala b/src/engine/util/util-logging.vala index 97f9ab6a..8f7895f9 100644 --- a/src/engine/util/util-logging.vala +++ b/src/engine/util/util-logging.vala @@ -78,9 +78,9 @@ namespace Geary.Logging { var parts = debug_var.split(","); if ("fatal-warnings" in parts) { Logging.set_breakpoint_on |= GLib.LogLevelFlags.LEVEL_WARNING; + Logging.set_breakpoint_on |= GLib.LogLevelFlags.LEVEL_CRITICAL; } if ("fatal-criticals" in parts) { - Logging.set_breakpoint_on |= GLib.LogLevelFlags.LEVEL_WARNING; Logging.set_breakpoint_on |= GLib.LogLevelFlags.LEVEL_CRITICAL; } }