nettika/geary
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove some reduncant method calls and related code.

Browse source
This commit is contained in:
Michael James Gratton 2016-12-01 12:12:31 +11:00
parent 9ae52342f5
commit a77a19c101
2 changed files with 1 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/client/conversation-viewer/conversation-message.vala
View file

@ -452,23 +452,7 @@ public class ConversationMessage : Gtk.Grid {
}
load_cancelled.cancelled.connect(() => { web_view.stop_loading(); });
// XXX Hook up unset_controllable_quotes() to size_allocate
// and check if loaded since we need to accurately know
// what the sizes of the quote and its container is to
// determine if it should be unhidden. However this means that
// when the user expands a hidden quote, this handler gets
// executed again and since the expanded quote will meet the
// criteria for being unset as controllable, that will
// happen. That's actually okay for now though, because if the
// user could collapse the quote again the space wouldn't be
// reclaimed, which is worse than this.
this.web_view.size_allocate.connect(() => {
if (this.web_view.is_loaded) {
this.web_view.unset_controllable_quotes();
}
});
this.web_view.clean_and_load(body_text ?? "");
this.web_view.load_html(body_text ?? "", null);
}
/**

12
src/client/conversation-viewer/conversation-web-view.vala
View file

@ -34,11 +34,6 @@ public class ConversationWebView : ClientWebView {
}
}
public void clean_and_load(string html) {
// XXX clean me
load_html(html, null);
}
/**
* Returns the current selection, for prefill as find text.
*/
@ -55,11 +50,4 @@ public class ConversationWebView : ClientWebView {
return get_string_result(result);
}
/**
* XXX
*/
public void unset_controllable_quotes() {
// XXX
}
}