engine: Do not stop delivering messages on error

- We are already showing an infobar for CONNECTION_FAILED with a 'Retry'
  button that will requeue all outbox messages
- For UNRECOVERABLE_ERROR, just ignore them until next engine restart

Fix #1258 #1482
This commit is contained in:
Cédric Bellegarde 2023-02-28 16:16:55 +01:00 committed by Niels De Graef
parent b10629b90d
commit 920343e575

View file

@ -193,7 +193,6 @@ public class Geary.Smtp.ClientService : Geary.ClientService {
err is SmtpError.NOT_SUPPORTED) {
notify_unrecoverable_error(new ErrorContext(err));
}
cancellable.cancel();
} catch (GLib.IOError.CANCELLED err) {
// Nothing to do here we're already cancelled.
} catch (EngineError.NOT_FOUND err) {
@ -202,12 +201,6 @@ public class Geary.Smtp.ClientService : Geary.ClientService {
id.to_string(), err.message);
} catch (GLib.Error err) {
notify_connection_failed(new ErrorContext(err));
cancellable.cancel();
}
if (!email_handled && id != null) {
// Send was bad, try sending again later
this.outbox_queue.send(id);
}
}