nettika/geary
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Reduce CPU use when idle.

Browse source 
It looks like Gtk.Spinner triggers repaints when running, even when the
widget is not visible. This ensures the conversation is stopped when not
visible.

Fix for Bug 783025.

* src/client/conversation-viewer/conversation-viewer.vala
  (ConversationViewer): Start the conversation spinner when showing it,
  stop the conversation spinner when it is hidden.
This commit is contained in:
Michael James Gratton 2018-04-09 12:31:39 +10:00
parent 2149f74c99
commit 71d05b6ce0
2 changed files with 14 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/client/conversation-viewer/conversation-viewer.vala
View file

@ -154,6 +154,7 @@ public class ConversationViewer : Gtk.Stack, Geary.BaseInterface {
* Shows the loading UI.
*/
public void show_loading() {
this.loading_page.start();
set_visible_child(this.loading_page);
}
@ -294,13 +295,19 @@ public class ConversationViewer : Gtk.Stack, Geary.BaseInterface {
*/
private new void set_visible_child(Gtk.Widget widget) {
debug("Showing: %s", widget.get_name());
if (widget != this.conversation_page &&
get_visible_child() == this.conversation_page) {
// By removing the current list, any load it is currently
// performing is also cancelled, which is important to
// avoid a possible crit warning when switching folders,
// etc.
remove_current_list();
Gtk.Widget current = get_visible_child();
if (current == this.conversation_page) {
if (widget != this.conversation_page) {
// By removing the current list, any load it is currently
// performing is also cancelled, which is important to
// avoid a possible crit warning when switching folders,
// etc.
remove_current_list();
}
} else if (current == this.loading_page) {
// Stop the spinner running so it doesn't trigger repaints
// and wake up Geary even when idle. See Bug 783025.
this.loading_page.stop();
}
base.set_visible_child(widget);
}

1
ui/conversation-viewer.ui
View file

@ -15,7 +15,6 @@
<property name="can_focus">False</property>
<property name="halign">center</property>
<property name="valign">center</property>
<property name="active">True</property>
</object>
<packing>
<property name="name">loading_page</property>