nettika/geary
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Unable to authenticate SMTP credentials: Closes bgo#721570

Browse source 
User's server was returning a status code that indicates an invalid
password, when in fact it was simply indicating that it didn't
support the AUTH type (even though it advertised it in its connect
capabilities).  This removes the error-checking by SMTP value and
simply attempts all chosed AUTH types.
This commit is contained in:
Jim Nelson 2014-01-20 11:23:16 -08:00
parent b4afcb76bb
commit 3ba75dac2a
1 changed files with 0 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/engine/smtp/smtp-client-session.vala
View file

@ -104,11 +104,6 @@ public class Geary.Smtp.ClientSession {
Response response = yield cx.authenticate_async(authenticator, cancellable);
if (response.code.is_success_completed())
return authenticator;
// syntax errors indicate the command was unknown or unimplemented, i.e. unavailable
// authentication type, so try again, otherwise treat as authentication failure
if (!response.code.is_syntax_error())
break;
} while (auth_order.size > 0);
throw new SmtpError.AUTHENTICATION_FAILED("Unable to authenticate with %s", to_string());