nettika/geary
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Geary.RFC822.MailboxAddresses: Update equality semantics

Browse source 
Although when processing mailbox addresses lists are effectively sets,
the ordering can be important for people. As such, make `equal_to`
comparisons require identical ordering, and add new `contains_all` for
order-independent comparisons.
This commit is contained in:
Michael Gratton 2020-08-12 15:45:31 +10:00 • committed by Michael James Gratton
parent 8608293367
commit 2957f15297
2 changed files with 52 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

36
test/engine/rfc822/rfc822-mailbox-addresses-test.vala
View file

@ -12,6 +12,7 @@ class Geary.RFC822.MailboxAddressesTest : TestCase {
add_test("from_rfc822_string_encoded", from_rfc822_string_encoded);
add_test("from_rfc822_string_quoted", from_rfc822_string_quoted);
add_test("to_rfc822_string", to_rfc822_string);
add_test("contains_all", contains_all);
add_test("equal_to", equal_to);
add_test("hash", hash);
}
@ -52,6 +53,38 @@ class Geary.RFC822.MailboxAddressesTest : TestCase {
.to_rfc822_string() == "test1@example.com, test2@example.com");
}
public void contains_all() throws GLib.Error {
var mailboxes_a = new_addreses({ "test1@example.com" });
var mailboxes_b = new_addreses({ "test1@example.com" });
var mailboxes_c = new_addreses({ "test2@example.com" });
assert_true(mailboxes_a.contains_all(mailboxes_a));
assert_true(mailboxes_a.contains_all(mailboxes_b));
assert_false(mailboxes_a.contains_all(mailboxes_c));
assert_true(
new_addreses({ "test1@example.com", "test2@example.com" }).contains_all(
new_addreses({ "test1@example.com", "test2@example.com" })
)
);
assert_true(
new_addreses({ "test1@example.com", "test2@example.com" }).contains_all(
new_addreses({ "test2@example.com", "test1@example.com" })
)
);
assert_false(
new_addreses({ "test1@example.com", "test2@example.com" }).contains_all(
new_addreses({ "test1@example.com" })
)
);
assert_false(
new_addreses({ "test1@example.com", "test2@example.com" }).contains_all(
new_addreses({ "test1@example.com", "test3@example.com" })
)
);
}
public void equal_to() throws GLib.Error {
var mailboxes_a = new_addreses({ "test1@example.com" });
var mailboxes_b = new_addreses({ "test1@example.com" });
@ -66,12 +99,11 @@ class Geary.RFC822.MailboxAddressesTest : TestCase {
new_addreses({ "test1@example.com", "test2@example.com" })
)
);
assert_true(
assert_false(
new_addreses({ "test1@example.com", "test2@example.com" }).equal_to(
new_addreses({ "test2@example.com", "test1@example.com" })
)
);
assert_false(
new_addreses({ "test1@example.com", "test2@example.com" }).equal_to(
new_addreses({ "test1@example.com" })