geary/src/engine/imap-engine/imap-engine-generic-account.vala

975 lines
41 KiB
Vala
Raw Normal View History

/* Copyright 2016 Software Freedom Conservancy Inc.
*
* This software is licensed under the GNU Lesser General Public License
* (version 2.1 or later). See the COPYING file in this distribution.
*/
private abstract class Geary.ImapEngine.GenericAccount : Geary.Account {
private const int REFRESH_FOLDER_LIST_SEC = 2 * 60;
private const int REFRESH_UNSEEN_SEC = 1;
private const Geary.SpecialFolderType[] SUPPORTED_SPECIAL_FOLDERS = {
Geary.SpecialFolderType.DRAFTS,
Geary.SpecialFolderType.SENT,
Geary.SpecialFolderType.SPAM,
Geary.SpecialFolderType.TRASH,
Geary.SpecialFolderType.ARCHIVE,
};
private static Geary.FolderPath? outbox_path = null;
2013-05-14 11:52:02 -07:00
private static Geary.FolderPath? search_path = null;
private Imap.Account remote;
Remove SQLHeavy: Closes #5034 It is done. Initial implementation of the new database subsystem These pieces represent the foundation for ticket #5034 Expanded transactions, added VersionedDatabase Further expansions of the async code. Moved async pool logic into Database, where it realistically belongs. Further improvements. Introduced geary-db-test. Added SQL create and update files for Geary.Db version-001 to version-003 are exact copies of the SQLHeavy scripts to ensure no slight changes when migrating. version-004 upgrades the database to remove the ImapFolderPropertiesTable and ImapMessagePropertiesTable, now that the database code is pure IMAP. When we support other messaging systems (such as POP3), those subsystems will need to code their own database layers OR rely on the IMAP schema and simply ignore the IMAP-specific fields. ImapDB.Account fleshed out ImapDB.Folder is commented out, however. Need to port next. ImapDB.Folder fleshed out MessageTable, MessageLocationTable, and AttachementTable are now handled inside ImapDB.Folder. chmod -x imap-db-database.vala OutboxEmailIdentifier/Properties -> SmtpOutboxEmailIdentifier/Properties Moved SmtpOutboxFolderRoot into its own source file SmtpOutboxFolder ported to new database code Move Engine implementations to ImapDB. Integration and cleanup of new database code with main source This commit performs the final integration steps to move Geary completely over to the new database model. This also cleans out the old SQLHeavy-based code and fixes a handful of small bugs that were detected during basic test runs. Moved Outbox to ImapDB As the Outbox is tied to the database that ImapDB runs, move the Outbox code into that folder. Outbox fixes and better parameter checking Bumped Database thread pool count and made them exclusive My reasoning is that there may be a need for a lot of threads at once (when a big batch of commands comes in, especially at startup). If performance looks ok, we might consider relaxing this later.
2012-06-14 14:47:53 -07:00
private ImapDB.Account local;
private bool open = false;
private Gee.HashMap<FolderPath, MinimalFolder> folder_map = new Gee.HashMap<
FolderPath, MinimalFolder>();
2013-04-24 12:22:32 -07:00
private Gee.HashMap<FolderPath, Folder> local_only = new Gee.HashMap<FolderPath, Folder>();
private Gee.HashMap<FolderPath, uint> refresh_unseen_timeout_ids
= new Gee.HashMap<FolderPath, uint>();
private Gee.HashSet<Geary.Folder> in_refresh_unseen = new Gee.HashSet<Geary.Folder>();
private uint refresh_folder_timeout_id = 0;
private bool in_refresh_enumerate = false;
private Cancellable refresh_cancellable = new Cancellable();
private bool awaiting_credentials = false;
private Gee.Map<Geary.SpecialFolderType, Gee.List<string>> special_search_names =
new Gee.HashMap<Geary.SpecialFolderType, Gee.List<string>>();
public GenericAccount(string name, Geary.AccountInformation information,
Imap.Account remote, ImapDB.Account local) {
base (name, information);
this.remote = remote;
this.local = local;
this.remote.login_failed.connect(on_login_failed);
this.local.email_sent.connect(on_email_sent);
Cache contact list store per account. Bug 771903 This implements new cache for ContactListStore. ContactListStore is created only once per account when account is opened with GearyController::open_account. It is destroyed in GearyController::close_account. ContactListStoreCache class is introduced to manage ContactListStore instances. ComposerWidget receives ContactListStoreCache instance instead of ContactListStore directly in constructor. To increase performance, backwards compatibility breaking changes are introduced to Engine API Geary.ContactStore. Signals: * Gee.ContactStore::contact_added(Contact) * Gee.ContactStore::contact_updated(Contact) are replaced with batch equivalents: * Gee::ContactStore::contacts_added(Gee.Collection<Contact>) * Gee::ContactStore::contacts_updated(Gee.Collection<Contact>) Geary.ComposerWidget::load_entry_completions is no longer async as it does not involve time consuming ContactListStore creation. CONTACT_MARKUP_NAME column is removed from ContactListStore as it used to keep state about highlighted areas of text. This is not possible anymore as ContactListStore is shared between multiple ComposerWidgets. Highlight implementation has been moved to Geary.ContactEntryCompletion instead. Additionally contacts_loaded signal is emitted from Geary.ImapEngine.GenericAccount and propagated to Geary.Account Geary.ContactListStore sort function is set upon receiving contacts_loaded signal instead of after initial contacts are loaded. This speeds up Geary startup for users with long contact lists.
2016-12-11 14:30:59 +01:00
this.local.contacts_loaded.connect(() => { contacts_loaded(); });
search_upgrade_monitor = local.search_index_monitor;
2013-07-08 14:22:23 -07:00
db_upgrade_monitor = local.upgrade_monitor;
db_vacuum_monitor = local.vacuum_monitor;
opening_monitor = new Geary.ReentrantProgressMonitor(Geary.ProgressType.ACTIVITY);
sending_monitor = local.sending_monitor;
if (outbox_path == null) {
outbox_path = new SmtpOutboxFolderRoot();
}
2013-05-14 11:52:02 -07:00
if (search_path == null) {
search_path = new ImapDB.SearchFolderRoot();
2013-05-14 11:52:02 -07:00
}
compile_special_search_names();
}
protected override void notify_folders_available_unavailable(Gee.List<Geary.Folder>? available,
Gee.List<Geary.Folder>? unavailable) {
base.notify_folders_available_unavailable(available, unavailable);
if (available != null) {
foreach (Geary.Folder folder in available) {
folder.email_appended.connect(notify_email_appended);
folder.email_inserted.connect(notify_email_inserted);
folder.email_removed.connect(notify_email_removed);
folder.email_locally_complete.connect(notify_email_locally_complete);
folder.email_flags_changed.connect(notify_email_flags_changed);
}
}
if (unavailable != null) {
foreach (Geary.Folder folder in unavailable) {
folder.email_appended.disconnect(notify_email_appended);
folder.email_inserted.disconnect(notify_email_inserted);
folder.email_removed.disconnect(notify_email_removed);
folder.email_locally_complete.disconnect(notify_email_locally_complete);
folder.email_flags_changed.disconnect(notify_email_flags_changed);
}
}
}
protected override void notify_email_appended(Geary.Folder folder, Gee.Collection<Geary.EmailIdentifier> ids) {
base.notify_email_appended(folder, ids);
reschedule_unseen_update(folder);
}
protected override void notify_email_inserted(Geary.Folder folder, Gee.Collection<Geary.EmailIdentifier> ids) {
base.notify_email_inserted(folder, ids);
reschedule_unseen_update(folder);
}
protected override void notify_email_removed(Geary.Folder folder, Gee.Collection<Geary.EmailIdentifier> ids) {
base.notify_email_removed(folder, ids);
reschedule_unseen_update(folder);
}
protected override void notify_email_flags_changed(Geary.Folder folder,
Gee.Map<Geary.EmailIdentifier, Geary.EmailFlags> flag_map) {
base.notify_email_flags_changed(folder, flag_map);
reschedule_unseen_update(folder);
}
Remove SQLHeavy: Closes #5034 It is done. Initial implementation of the new database subsystem These pieces represent the foundation for ticket #5034 Expanded transactions, added VersionedDatabase Further expansions of the async code. Moved async pool logic into Database, where it realistically belongs. Further improvements. Introduced geary-db-test. Added SQL create and update files for Geary.Db version-001 to version-003 are exact copies of the SQLHeavy scripts to ensure no slight changes when migrating. version-004 upgrades the database to remove the ImapFolderPropertiesTable and ImapMessagePropertiesTable, now that the database code is pure IMAP. When we support other messaging systems (such as POP3), those subsystems will need to code their own database layers OR rely on the IMAP schema and simply ignore the IMAP-specific fields. ImapDB.Account fleshed out ImapDB.Folder is commented out, however. Need to port next. ImapDB.Folder fleshed out MessageTable, MessageLocationTable, and AttachementTable are now handled inside ImapDB.Folder. chmod -x imap-db-database.vala OutboxEmailIdentifier/Properties -> SmtpOutboxEmailIdentifier/Properties Moved SmtpOutboxFolderRoot into its own source file SmtpOutboxFolder ported to new database code Move Engine implementations to ImapDB. Integration and cleanup of new database code with main source This commit performs the final integration steps to move Geary completely over to the new database model. This also cleans out the old SQLHeavy-based code and fixes a handful of small bugs that were detected during basic test runs. Moved Outbox to ImapDB As the Outbox is tied to the database that ImapDB runs, move the Outbox code into that folder. Outbox fixes and better parameter checking Bumped Database thread pool count and made them exclusive My reasoning is that there may be a need for a lot of threads at once (when a big batch of commands comes in, especially at startup). If performance looks ok, we might consider relaxing this later.
2012-06-14 14:47:53 -07:00
private void check_open() throws EngineError {
if (!open)
throw new EngineError.OPEN_REQUIRED("Account %s not opened", to_string());
}
public override async void open_async(Cancellable? cancellable = null) throws Error {
Remove SQLHeavy: Closes #5034 It is done. Initial implementation of the new database subsystem These pieces represent the foundation for ticket #5034 Expanded transactions, added VersionedDatabase Further expansions of the async code. Moved async pool logic into Database, where it realistically belongs. Further improvements. Introduced geary-db-test. Added SQL create and update files for Geary.Db version-001 to version-003 are exact copies of the SQLHeavy scripts to ensure no slight changes when migrating. version-004 upgrades the database to remove the ImapFolderPropertiesTable and ImapMessagePropertiesTable, now that the database code is pure IMAP. When we support other messaging systems (such as POP3), those subsystems will need to code their own database layers OR rely on the IMAP schema and simply ignore the IMAP-specific fields. ImapDB.Account fleshed out ImapDB.Folder is commented out, however. Need to port next. ImapDB.Folder fleshed out MessageTable, MessageLocationTable, and AttachementTable are now handled inside ImapDB.Folder. chmod -x imap-db-database.vala OutboxEmailIdentifier/Properties -> SmtpOutboxEmailIdentifier/Properties Moved SmtpOutboxFolderRoot into its own source file SmtpOutboxFolder ported to new database code Move Engine implementations to ImapDB. Integration and cleanup of new database code with main source This commit performs the final integration steps to move Geary completely over to the new database model. This also cleans out the old SQLHeavy-based code and fixes a handful of small bugs that were detected during basic test runs. Moved Outbox to ImapDB As the Outbox is tied to the database that ImapDB runs, move the Outbox code into that folder. Outbox fixes and better parameter checking Bumped Database thread pool count and made them exclusive My reasoning is that there may be a need for a lot of threads at once (when a big batch of commands comes in, especially at startup). If performance looks ok, we might consider relaxing this later.
2012-06-14 14:47:53 -07:00
if (open)
throw new EngineError.ALREADY_OPEN("Account %s already opened", to_string());
opening_monitor.notify_start();
Error? throw_err = null;
try {
yield internal_open_async(cancellable);
} catch (Error err) {
throw_err = err;
}
opening_monitor.notify_finish();
if (throw_err != null)
throw throw_err;
}
private async void internal_open_async(Cancellable? cancellable) throws Error {
try {
yield local.open_async(information.data_dir, Engine.instance.resource_dir.get_child("sql"),
cancellable);
} catch (Error err) {
// convert database-open errors
if (err is DatabaseError.CORRUPT)
throw new EngineError.CORRUPT("%s", err.message);
else if (err is DatabaseError.ACCESS)
throw new EngineError.PERMISSIONS("%s", err.message);
else if (err is DatabaseError.SCHEMA_VERSION)
throw new EngineError.VERSION("%s", err.message);
else
throw err;
}
// outbox is now available
local.outbox.report_problem.connect(notify_report_problem);
local_only.set(outbox_path, local.outbox);
2013-05-14 11:52:02 -07:00
// Search folder.
local_only.set(search_path, local.search_folder);
// To prevent spurious connection failures, we make sure we have the
// IMAP password before attempting a connection. This might have to be
// reworked when we allow passwordless logins.
if (!information.imap_credentials.is_complete())
yield information.fetch_passwords_async(ServiceFlag.IMAP);
// need to back out local.open_async() if remote fails
try {
yield remote.open_async(cancellable);
} catch (Error err) {
// back out
try {
yield local.close_async(cancellable);
} catch (Error close_err) {
// ignored
}
throw err;
}
Remove SQLHeavy: Closes #5034 It is done. Initial implementation of the new database subsystem These pieces represent the foundation for ticket #5034 Expanded transactions, added VersionedDatabase Further expansions of the async code. Moved async pool logic into Database, where it realistically belongs. Further improvements. Introduced geary-db-test. Added SQL create and update files for Geary.Db version-001 to version-003 are exact copies of the SQLHeavy scripts to ensure no slight changes when migrating. version-004 upgrades the database to remove the ImapFolderPropertiesTable and ImapMessagePropertiesTable, now that the database code is pure IMAP. When we support other messaging systems (such as POP3), those subsystems will need to code their own database layers OR rely on the IMAP schema and simply ignore the IMAP-specific fields. ImapDB.Account fleshed out ImapDB.Folder is commented out, however. Need to port next. ImapDB.Folder fleshed out MessageTable, MessageLocationTable, and AttachementTable are now handled inside ImapDB.Folder. chmod -x imap-db-database.vala OutboxEmailIdentifier/Properties -> SmtpOutboxEmailIdentifier/Properties Moved SmtpOutboxFolderRoot into its own source file SmtpOutboxFolder ported to new database code Move Engine implementations to ImapDB. Integration and cleanup of new database code with main source This commit performs the final integration steps to move Geary completely over to the new database model. This also cleans out the old SQLHeavy-based code and fixes a handful of small bugs that were detected during basic test runs. Moved Outbox to ImapDB As the Outbox is tied to the database that ImapDB runs, move the Outbox code into that folder. Outbox fixes and better parameter checking Bumped Database thread pool count and made them exclusive My reasoning is that there may be a need for a lot of threads at once (when a big batch of commands comes in, especially at startup). If performance looks ok, we might consider relaxing this later.
2012-06-14 14:47:53 -07:00
open = true;
notify_opened();
notify_folders_available_unavailable(sort_by_path(local_only.values), null);
// schedule an immediate sweep of the folders; once this is finished, folders will be
// regularly enumerated
reschedule_folder_refresh(true);
}
public override async void close_async(Cancellable? cancellable = null) throws Error {
Remove SQLHeavy: Closes #5034 It is done. Initial implementation of the new database subsystem These pieces represent the foundation for ticket #5034 Expanded transactions, added VersionedDatabase Further expansions of the async code. Moved async pool logic into Database, where it realistically belongs. Further improvements. Introduced geary-db-test. Added SQL create and update files for Geary.Db version-001 to version-003 are exact copies of the SQLHeavy scripts to ensure no slight changes when migrating. version-004 upgrades the database to remove the ImapFolderPropertiesTable and ImapMessagePropertiesTable, now that the database code is pure IMAP. When we support other messaging systems (such as POP3), those subsystems will need to code their own database layers OR rely on the IMAP schema and simply ignore the IMAP-specific fields. ImapDB.Account fleshed out ImapDB.Folder is commented out, however. Need to port next. ImapDB.Folder fleshed out MessageTable, MessageLocationTable, and AttachementTable are now handled inside ImapDB.Folder. chmod -x imap-db-database.vala OutboxEmailIdentifier/Properties -> SmtpOutboxEmailIdentifier/Properties Moved SmtpOutboxFolderRoot into its own source file SmtpOutboxFolder ported to new database code Move Engine implementations to ImapDB. Integration and cleanup of new database code with main source This commit performs the final integration steps to move Geary completely over to the new database model. This also cleans out the old SQLHeavy-based code and fixes a handful of small bugs that were detected during basic test runs. Moved Outbox to ImapDB As the Outbox is tied to the database that ImapDB runs, move the Outbox code into that folder. Outbox fixes and better parameter checking Bumped Database thread pool count and made them exclusive My reasoning is that there may be a need for a lot of threads at once (when a big batch of commands comes in, especially at startup). If performance looks ok, we might consider relaxing this later.
2012-06-14 14:47:53 -07:00
if (!open)
return;
notify_folders_available_unavailable(null, sort_by_path(local_only.values));
notify_folders_available_unavailable(null, sort_by_path(folder_map.values));
Remove SQLHeavy: Closes #5034 It is done. Initial implementation of the new database subsystem These pieces represent the foundation for ticket #5034 Expanded transactions, added VersionedDatabase Further expansions of the async code. Moved async pool logic into Database, where it realistically belongs. Further improvements. Introduced geary-db-test. Added SQL create and update files for Geary.Db version-001 to version-003 are exact copies of the SQLHeavy scripts to ensure no slight changes when migrating. version-004 upgrades the database to remove the ImapFolderPropertiesTable and ImapMessagePropertiesTable, now that the database code is pure IMAP. When we support other messaging systems (such as POP3), those subsystems will need to code their own database layers OR rely on the IMAP schema and simply ignore the IMAP-specific fields. ImapDB.Account fleshed out ImapDB.Folder is commented out, however. Need to port next. ImapDB.Folder fleshed out MessageTable, MessageLocationTable, and AttachementTable are now handled inside ImapDB.Folder. chmod -x imap-db-database.vala OutboxEmailIdentifier/Properties -> SmtpOutboxEmailIdentifier/Properties Moved SmtpOutboxFolderRoot into its own source file SmtpOutboxFolder ported to new database code Move Engine implementations to ImapDB. Integration and cleanup of new database code with main source This commit performs the final integration steps to move Geary completely over to the new database model. This also cleans out the old SQLHeavy-based code and fixes a handful of small bugs that were detected during basic test runs. Moved Outbox to ImapDB As the Outbox is tied to the database that ImapDB runs, move the Outbox code into that folder. Outbox fixes and better parameter checking Bumped Database thread pool count and made them exclusive My reasoning is that there may be a need for a lot of threads at once (when a big batch of commands comes in, especially at startup). If performance looks ok, we might consider relaxing this later.
2012-06-14 14:47:53 -07:00
local.outbox.report_problem.disconnect(notify_report_problem);
// attempt to close both regardless of errors
Error? local_err = null;
try {
yield local.close_async(cancellable);
} catch (Error lclose_err) {
local_err = lclose_err;
}
Error? remote_err = null;
try {
yield remote.close_async(cancellable);
} catch (Error rclose_err) {
remote_err = rclose_err;
}
folder_map.clear();
local_only.clear();
open = false;
if (local_err != null)
throw local_err;
if (remote_err != null)
throw remote_err;
}
public override bool is_open() {
return open;
}
public override async void rebuild_async(Cancellable? cancellable = null) throws Error {
if (open)
throw new EngineError.ALREADY_OPEN("Account cannot be open during rebuild");
message("%s: Rebuilding account local data", to_string());
// get all the storage locations associated with this Account
File db_file;
File attachments_dir;
ImapDB.Account.get_imap_db_storage_locations(information.data_dir, out db_file,
out attachments_dir);
if (yield Files.query_exists_async(db_file, cancellable)) {
message("%s: Deleting database file %s...", to_string(), db_file.get_path());
yield db_file.delete_async(Priority.DEFAULT, cancellable);
}
if (yield Files.query_exists_async(attachments_dir, cancellable)) {
message("%s: Deleting attachments directory %s...", to_string(), attachments_dir.get_path());
yield Files.recursive_delete_async(attachments_dir, cancellable);
}
message("%s: Rebuild complete", to_string());
}
// Subclasses should implement this to return their flavor of a MinimalFolder with the
// appropriate interfaces attached. The returned folder should have its SpecialFolderType
// set using either the properties from the local folder or its path.
//
2013-05-14 11:52:02 -07:00
// This won't be called to build the Outbox or search folder, but for all others (including Inbox) it will.
protected abstract MinimalFolder new_folder(Geary.FolderPath path, Imap.Account remote_account,
Remove SQLHeavy: Closes #5034 It is done. Initial implementation of the new database subsystem These pieces represent the foundation for ticket #5034 Expanded transactions, added VersionedDatabase Further expansions of the async code. Moved async pool logic into Database, where it realistically belongs. Further improvements. Introduced geary-db-test. Added SQL create and update files for Geary.Db version-001 to version-003 are exact copies of the SQLHeavy scripts to ensure no slight changes when migrating. version-004 upgrades the database to remove the ImapFolderPropertiesTable and ImapMessagePropertiesTable, now that the database code is pure IMAP. When we support other messaging systems (such as POP3), those subsystems will need to code their own database layers OR rely on the IMAP schema and simply ignore the IMAP-specific fields. ImapDB.Account fleshed out ImapDB.Folder is commented out, however. Need to port next. ImapDB.Folder fleshed out MessageTable, MessageLocationTable, and AttachementTable are now handled inside ImapDB.Folder. chmod -x imap-db-database.vala OutboxEmailIdentifier/Properties -> SmtpOutboxEmailIdentifier/Properties Moved SmtpOutboxFolderRoot into its own source file SmtpOutboxFolder ported to new database code Move Engine implementations to ImapDB. Integration and cleanup of new database code with main source This commit performs the final integration steps to move Geary completely over to the new database model. This also cleans out the old SQLHeavy-based code and fixes a handful of small bugs that were detected during basic test runs. Moved Outbox to ImapDB As the Outbox is tied to the database that ImapDB runs, move the Outbox code into that folder. Outbox fixes and better parameter checking Bumped Database thread pool count and made them exclusive My reasoning is that there may be a need for a lot of threads at once (when a big batch of commands comes in, especially at startup). If performance looks ok, we might consider relaxing this later.
2012-06-14 14:47:53 -07:00
ImapDB.Account local_account, ImapDB.Folder local_folder);
// Subclasses with specific SearchFolder implementations should override
// this to return the correct subclass.
internal virtual SearchFolder new_search_folder() {
return new ImapDB.SearchFolder(this);
}
private MinimalFolder build_folder(ImapDB.Folder local_folder) {
return Geary.Collection.get_first(build_folders(
Geary.iterate<ImapDB.Folder>(local_folder).to_array_list()));
}
private Gee.Collection<MinimalFolder> build_folders(Gee.Collection<ImapDB.Folder> local_folders) {
Gee.ArrayList<ImapDB.Folder> folders_to_build = new Gee.ArrayList<ImapDB.Folder>();
Gee.ArrayList<MinimalFolder> built_folders = new Gee.ArrayList<MinimalFolder>();
Gee.ArrayList<MinimalFolder> return_folders = new Gee.ArrayList<MinimalFolder>();
foreach(ImapDB.Folder local_folder in local_folders) {
if (folder_map.has_key(local_folder.get_path()))
return_folders.add(folder_map.get(local_folder.get_path()));
else
folders_to_build.add(local_folder);
}
foreach(ImapDB.Folder folder_to_build in folders_to_build) {
MinimalFolder folder = new_folder(folder_to_build.get_path(), remote, local, folder_to_build);
folder_map.set(folder.path, folder);
built_folders.add(folder);
return_folders.add(folder);
}
if (built_folders.size > 0)
notify_folders_available_unavailable(sort_by_path(built_folders), null);
return return_folders;
}
public override Gee.Collection<Geary.Folder> list_matching_folders(Geary.FolderPath? parent)
throws Error {
Load and display multiple accounts; fix #6230 Lots has been changed here. See the bug report <http://redmine.yorba.org/issues/6230> for some of the discussion about it. This also fixes #6274. I'll cut the list of revisions off after a while, because this branch has been outstanding for a couple weeks. Squashed commit of the following: commit ae505d89e87e63e0d8949bfd901913706a9d3b73 Merge: 81ef002 e18bef9 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 15:16:17 2013 -0800 Merge branch 'master' into multiple-accounts commit 81ef002f5ff486b9c28f5663a0ba1e7392b8489c Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 15:15:51 2013 -0800 Fix final round of code review commit 6935b1e7892b9b356bf5006b89e0b2a4e6a8ad16 Merge: c9ed434 a9dc52b Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:45:46 2013 -0800 Merge branch 'master' into multiple-accounts commit c9ed434fe936e6aed735baef222ae615364c2513 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:31:02 2013 -0800 Simplify folder comparator commit 28ac020cfd9135c6eb4ed05574c82b92f99c4a40 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:06:55 2013 -0800 Bump up declaration to conform to guidelines commit 0a8167bdaebd5fac1c3ca791de5f2cc233c13cb9 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 13:54:03 2013 -0800 Rename back to list_*folders commit 31457f60298052bdddba8e426db27f93d7c72529 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 12:36:15 2013 -0800 Fix spacing, brevity issues commit ecd30c203d80c21c1ca1234b8911b57efcb68294 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:56:29 2013 -0800 Fix nits before review commit 85b51d71e83115991cd9a54d491b4d45b71f2f9b Merge: b29abce d538bf0 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:46:19 2013 -0800 Merge branch 'master' into multiple-accounts commit b29abceeaea84f226ab9bcd22266a511691d8005 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:22:28 2013 -0800 Fix notifications commit c26d975fb0859d807ddb7f7c10632605c3b6fb1c Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 13:01:03 2013 -0800 Only show current acct. folders in copy/move menus commit 9a5b57db1229a079f11f518c53f5762a3670b83f Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:48:05 2013 -0800 Fix issue where wrong mail would show in folders commit 3b05d18843584c2aff7472708eea30ce24068043 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:18:38 2013 -0800 Fix ordering of folders in side bar commit b228967b6a74c16698d593e53e65d66c69ffb974 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:07:32 2013 -0800 Add icon to accounts in sidebar commit dd05d2c987a46f0b6699d743c339297e06829e4f Author: Charles Lindsay <chaz@yorba.org> Date: Tue Jan 29 19:04:52 2013 -0800 Fix Labels icon commit b5254fe8f6ef37df48d41167d0f52f3cd88d1966 Author: Charles Lindsay <chaz@yorba.org> Date: Tue Jan 29 18:43:45 2013 -0800 Initial stab at new FolderList; fix compile errors commit ff591810ee4312acce208dfa36d993069bc4c7d2 Merge: 2b9dbb9 ff5f9fa Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 17:42:34 2013 -0800 Merge branch 'master' into multiple-accounts commit 2b9dbb9b6963b1d52b2b90300bcea277b01d2094 Merge: 7583241 fcfb460 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 17:21:49 2013 -0800 Merge branch 'master' into multiple-accounts Conflicts: src/client/geary-controller.vala commit 75832412cc806c956848e32ef20052af36d4f64d Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 16:37:15 2013 -0800 Fix IMAP sess. mgr. to recover from bad passwords commit 8868b4be5c3f5c97246d35c6170531c6f543abe1 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 12:06:21 2013 -0800 Typo commit 3f909054502d31ca48e11f7948fd22118afe7514 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 10:54:51 2013 -0800 Clean up interface a little commit 3bfb526fe8801f8234127944be8594a960ccf7e7 Merge: 5e84e93 e971275 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:23:52 2013 -0800 Merge branch 'master' into multiple-accounts Conflicts: src/client/geary-application.vala src/engine/api/geary-engine.vala commit 5e84e9375a655567a3bc4eb7ebaacab2d218be40 Merge: 35cc46b 9167aeb Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:17:00 2013 -0800 Merge branch 'pluggable-auth' into multiple-accounts Conflicts: src/engine/api/geary-engine.vala commit 9167aeb56be6789d49a3e7cdba2a21d2b015e40d Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:11:20 2013 -0800 Fix for code guidelines commit 35cc46bc99f44f1597c609bfeaa72dd503333a17 Merge: 9675f47 7612a7d Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 15:44:18 2013 -0800 Merge branch 'pluggable-auth' into multiple-accounts Conflicts: src/client/geary-application.vala commit 7612a7ddc3df14ef207b9e74ee32fa23710e1ce9 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 15:26:48 2013 -0800 Fix code review issues commit 46635544c98df7a8b6c76f028715814907274389 Merge: 30b611e 6de36ae Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:54:03 2013 -0800 Merge branch 'master' into pluggable-auth commit 9675f473e77d0d581cf73a33012981e6a4f44943 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:53:18 2013 -0800 Try to make Folder know about its Account commit 5d9af43e53199a616490cf6ff98bd3c613b4e5f2 Merge: 335480e 6de36ae Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:12:21 2013 -0800 Merge branch 'master' into multiple-accounts commit 335480e2dd0261c8fb82f1c6296f5b8c76f3ac02 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:11:18 2013 -0800 Work on multiple accounts; fix compilation errors commit 808e65d55798e3f08b4c70992718cc11befbb45c Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 24 19:28:12 2013 -0800 Fix application logic for multiple accounts You get the idea.
2013-01-31 15:17:44 -08:00
check_open();
return Geary.traverse<FolderPath>(folder_map.keys)
.filter(p => {
FolderPath? path_parent = p.get_parent();
return ((parent == null && path_parent == null) ||
(parent != null && path_parent != null && path_parent.equal_to(parent)));
})
.map<Geary.Folder>(p => folder_map.get(p))
.to_array_list();
}
Load and display multiple accounts; fix #6230 Lots has been changed here. See the bug report <http://redmine.yorba.org/issues/6230> for some of the discussion about it. This also fixes #6274. I'll cut the list of revisions off after a while, because this branch has been outstanding for a couple weeks. Squashed commit of the following: commit ae505d89e87e63e0d8949bfd901913706a9d3b73 Merge: 81ef002 e18bef9 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 15:16:17 2013 -0800 Merge branch 'master' into multiple-accounts commit 81ef002f5ff486b9c28f5663a0ba1e7392b8489c Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 15:15:51 2013 -0800 Fix final round of code review commit 6935b1e7892b9b356bf5006b89e0b2a4e6a8ad16 Merge: c9ed434 a9dc52b Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:45:46 2013 -0800 Merge branch 'master' into multiple-accounts commit c9ed434fe936e6aed735baef222ae615364c2513 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:31:02 2013 -0800 Simplify folder comparator commit 28ac020cfd9135c6eb4ed05574c82b92f99c4a40 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:06:55 2013 -0800 Bump up declaration to conform to guidelines commit 0a8167bdaebd5fac1c3ca791de5f2cc233c13cb9 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 13:54:03 2013 -0800 Rename back to list_*folders commit 31457f60298052bdddba8e426db27f93d7c72529 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 12:36:15 2013 -0800 Fix spacing, brevity issues commit ecd30c203d80c21c1ca1234b8911b57efcb68294 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:56:29 2013 -0800 Fix nits before review commit 85b51d71e83115991cd9a54d491b4d45b71f2f9b Merge: b29abce d538bf0 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:46:19 2013 -0800 Merge branch 'master' into multiple-accounts commit b29abceeaea84f226ab9bcd22266a511691d8005 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:22:28 2013 -0800 Fix notifications commit c26d975fb0859d807ddb7f7c10632605c3b6fb1c Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 13:01:03 2013 -0800 Only show current acct. folders in copy/move menus commit 9a5b57db1229a079f11f518c53f5762a3670b83f Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:48:05 2013 -0800 Fix issue where wrong mail would show in folders commit 3b05d18843584c2aff7472708eea30ce24068043 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:18:38 2013 -0800 Fix ordering of folders in side bar commit b228967b6a74c16698d593e53e65d66c69ffb974 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:07:32 2013 -0800 Add icon to accounts in sidebar commit dd05d2c987a46f0b6699d743c339297e06829e4f Author: Charles Lindsay <chaz@yorba.org> Date: Tue Jan 29 19:04:52 2013 -0800 Fix Labels icon commit b5254fe8f6ef37df48d41167d0f52f3cd88d1966 Author: Charles Lindsay <chaz@yorba.org> Date: Tue Jan 29 18:43:45 2013 -0800 Initial stab at new FolderList; fix compile errors commit ff591810ee4312acce208dfa36d993069bc4c7d2 Merge: 2b9dbb9 ff5f9fa Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 17:42:34 2013 -0800 Merge branch 'master' into multiple-accounts commit 2b9dbb9b6963b1d52b2b90300bcea277b01d2094 Merge: 7583241 fcfb460 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 17:21:49 2013 -0800 Merge branch 'master' into multiple-accounts Conflicts: src/client/geary-controller.vala commit 75832412cc806c956848e32ef20052af36d4f64d Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 16:37:15 2013 -0800 Fix IMAP sess. mgr. to recover from bad passwords commit 8868b4be5c3f5c97246d35c6170531c6f543abe1 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 12:06:21 2013 -0800 Typo commit 3f909054502d31ca48e11f7948fd22118afe7514 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 10:54:51 2013 -0800 Clean up interface a little commit 3bfb526fe8801f8234127944be8594a960ccf7e7 Merge: 5e84e93 e971275 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:23:52 2013 -0800 Merge branch 'master' into multiple-accounts Conflicts: src/client/geary-application.vala src/engine/api/geary-engine.vala commit 5e84e9375a655567a3bc4eb7ebaacab2d218be40 Merge: 35cc46b 9167aeb Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:17:00 2013 -0800 Merge branch 'pluggable-auth' into multiple-accounts Conflicts: src/engine/api/geary-engine.vala commit 9167aeb56be6789d49a3e7cdba2a21d2b015e40d Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:11:20 2013 -0800 Fix for code guidelines commit 35cc46bc99f44f1597c609bfeaa72dd503333a17 Merge: 9675f47 7612a7d Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 15:44:18 2013 -0800 Merge branch 'pluggable-auth' into multiple-accounts Conflicts: src/client/geary-application.vala commit 7612a7ddc3df14ef207b9e74ee32fa23710e1ce9 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 15:26:48 2013 -0800 Fix code review issues commit 46635544c98df7a8b6c76f028715814907274389 Merge: 30b611e 6de36ae Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:54:03 2013 -0800 Merge branch 'master' into pluggable-auth commit 9675f473e77d0d581cf73a33012981e6a4f44943 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:53:18 2013 -0800 Try to make Folder know about its Account commit 5d9af43e53199a616490cf6ff98bd3c613b4e5f2 Merge: 335480e 6de36ae Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:12:21 2013 -0800 Merge branch 'master' into multiple-accounts commit 335480e2dd0261c8fb82f1c6296f5b8c76f3ac02 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:11:18 2013 -0800 Work on multiple accounts; fix compilation errors commit 808e65d55798e3f08b4c70992718cc11befbb45c Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 24 19:28:12 2013 -0800 Fix application logic for multiple accounts You get the idea.
2013-01-31 15:17:44 -08:00
public override Gee.Collection<Geary.Folder> list_folders() throws Error {
check_open();
2013-05-14 11:52:02 -07:00
Gee.HashSet<Geary.Folder> all_folders = new Gee.HashSet<Geary.Folder>();
2013-06-14 16:34:06 -07:00
all_folders.add_all(folder_map.values);
2013-05-14 11:52:02 -07:00
all_folders.add_all(local_only.values);
2013-05-14 11:52:02 -07:00
return all_folders;
Load and display multiple accounts; fix #6230 Lots has been changed here. See the bug report <http://redmine.yorba.org/issues/6230> for some of the discussion about it. This also fixes #6274. I'll cut the list of revisions off after a while, because this branch has been outstanding for a couple weeks. Squashed commit of the following: commit ae505d89e87e63e0d8949bfd901913706a9d3b73 Merge: 81ef002 e18bef9 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 15:16:17 2013 -0800 Merge branch 'master' into multiple-accounts commit 81ef002f5ff486b9c28f5663a0ba1e7392b8489c Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 15:15:51 2013 -0800 Fix final round of code review commit 6935b1e7892b9b356bf5006b89e0b2a4e6a8ad16 Merge: c9ed434 a9dc52b Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:45:46 2013 -0800 Merge branch 'master' into multiple-accounts commit c9ed434fe936e6aed735baef222ae615364c2513 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:31:02 2013 -0800 Simplify folder comparator commit 28ac020cfd9135c6eb4ed05574c82b92f99c4a40 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:06:55 2013 -0800 Bump up declaration to conform to guidelines commit 0a8167bdaebd5fac1c3ca791de5f2cc233c13cb9 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 13:54:03 2013 -0800 Rename back to list_*folders commit 31457f60298052bdddba8e426db27f93d7c72529 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 12:36:15 2013 -0800 Fix spacing, brevity issues commit ecd30c203d80c21c1ca1234b8911b57efcb68294 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:56:29 2013 -0800 Fix nits before review commit 85b51d71e83115991cd9a54d491b4d45b71f2f9b Merge: b29abce d538bf0 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:46:19 2013 -0800 Merge branch 'master' into multiple-accounts commit b29abceeaea84f226ab9bcd22266a511691d8005 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:22:28 2013 -0800 Fix notifications commit c26d975fb0859d807ddb7f7c10632605c3b6fb1c Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 13:01:03 2013 -0800 Only show current acct. folders in copy/move menus commit 9a5b57db1229a079f11f518c53f5762a3670b83f Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:48:05 2013 -0800 Fix issue where wrong mail would show in folders commit 3b05d18843584c2aff7472708eea30ce24068043 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:18:38 2013 -0800 Fix ordering of folders in side bar commit b228967b6a74c16698d593e53e65d66c69ffb974 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:07:32 2013 -0800 Add icon to accounts in sidebar commit dd05d2c987a46f0b6699d743c339297e06829e4f Author: Charles Lindsay <chaz@yorba.org> Date: Tue Jan 29 19:04:52 2013 -0800 Fix Labels icon commit b5254fe8f6ef37df48d41167d0f52f3cd88d1966 Author: Charles Lindsay <chaz@yorba.org> Date: Tue Jan 29 18:43:45 2013 -0800 Initial stab at new FolderList; fix compile errors commit ff591810ee4312acce208dfa36d993069bc4c7d2 Merge: 2b9dbb9 ff5f9fa Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 17:42:34 2013 -0800 Merge branch 'master' into multiple-accounts commit 2b9dbb9b6963b1d52b2b90300bcea277b01d2094 Merge: 7583241 fcfb460 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 17:21:49 2013 -0800 Merge branch 'master' into multiple-accounts Conflicts: src/client/geary-controller.vala commit 75832412cc806c956848e32ef20052af36d4f64d Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 16:37:15 2013 -0800 Fix IMAP sess. mgr. to recover from bad passwords commit 8868b4be5c3f5c97246d35c6170531c6f543abe1 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 12:06:21 2013 -0800 Typo commit 3f909054502d31ca48e11f7948fd22118afe7514 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 10:54:51 2013 -0800 Clean up interface a little commit 3bfb526fe8801f8234127944be8594a960ccf7e7 Merge: 5e84e93 e971275 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:23:52 2013 -0800 Merge branch 'master' into multiple-accounts Conflicts: src/client/geary-application.vala src/engine/api/geary-engine.vala commit 5e84e9375a655567a3bc4eb7ebaacab2d218be40 Merge: 35cc46b 9167aeb Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:17:00 2013 -0800 Merge branch 'pluggable-auth' into multiple-accounts Conflicts: src/engine/api/geary-engine.vala commit 9167aeb56be6789d49a3e7cdba2a21d2b015e40d Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:11:20 2013 -0800 Fix for code guidelines commit 35cc46bc99f44f1597c609bfeaa72dd503333a17 Merge: 9675f47 7612a7d Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 15:44:18 2013 -0800 Merge branch 'pluggable-auth' into multiple-accounts Conflicts: src/client/geary-application.vala commit 7612a7ddc3df14ef207b9e74ee32fa23710e1ce9 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 15:26:48 2013 -0800 Fix code review issues commit 46635544c98df7a8b6c76f028715814907274389 Merge: 30b611e 6de36ae Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:54:03 2013 -0800 Merge branch 'master' into pluggable-auth commit 9675f473e77d0d581cf73a33012981e6a4f44943 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:53:18 2013 -0800 Try to make Folder know about its Account commit 5d9af43e53199a616490cf6ff98bd3c613b4e5f2 Merge: 335480e 6de36ae Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:12:21 2013 -0800 Merge branch 'master' into multiple-accounts commit 335480e2dd0261c8fb82f1c6296f5b8c76f3ac02 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:11:18 2013 -0800 Work on multiple accounts; fix compilation errors commit 808e65d55798e3f08b4c70992718cc11befbb45c Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 24 19:28:12 2013 -0800 Fix application logic for multiple accounts You get the idea.
2013-01-31 15:17:44 -08:00
}
private void reschedule_unseen_update(Geary.Folder folder) {
if (!folder_map.has_key(folder.path))
return;
if (refresh_unseen_timeout_ids.get(folder.path) != 0)
Source.remove(refresh_unseen_timeout_ids.get(folder.path));
refresh_unseen_timeout_ids.set(folder.path,
Timeout.add_seconds(REFRESH_UNSEEN_SEC, () => on_refresh_unseen(folder)));
}
private bool on_refresh_unseen(Geary.Folder folder) {
// If we're in the process already, reschedule for later.
if (in_refresh_unseen.contains(folder))
return true;
// add here, remove in completed callback
in_refresh_unseen.add(folder);
refresh_unseen_async.begin(folder, null, on_refresh_unseen_completed);
refresh_unseen_timeout_ids.unset(folder.path);
return false;
}
private void on_refresh_unseen_completed(Object? source, AsyncResult result) {
try {
refresh_unseen_async.end(result);
} catch (Error e) {
debug("Error refreshing unseen counts: %s", e.message);
}
}
Use Imap.ClientSession for mapping between folder and mailbox names. Now that ClientSession is storing per-connection inbox and namespace data, we want to always consult with the account or folder's session to determine the correct Imap.MailboxSpecifier name for a high-level Geary.FolderPath, and vice versa. This is enforced by removing all inbox and delim information from Imap.Accout and Imap.Folder, and providing methods to translate between MailboxSpecifier and FolderPath, then fixing up the fallout. * src/engine/imap/transport/imap-client-session.vala (ClientSession): Add methods for obtaining the delimiter and converting between foler paths and mailbox names, based on information obtainined from the IMAP server for this connection. * src/engine/imap/api/imap-account.vala (Account): Remove path_to_mailbox, inbox_specifier, and hierarchy_delimiter object attributes since these are connection specific. Convert from caching all mailbox specifiers retreived from the server and some Imap.Folder instances to simply cache all Folder instances. Substantially rework the public API implementation as below to support this and update all call sites. (Account::folder_exists_async): Actually hit the server rather than justing looking at the cache to determine if the folder exists, remove a folder from the cache if not. (Account::fetch_folder_async): Renamed from "fetch_unrecycled_folder_async" so as to be a bit less obtuse, updated call sites. (Account::fetch_folder_cached_async): Renamed from fetch_folder_async to be a bit more obvious. Substantially simplified, deleates to fetch_folder_async() rather than list_children_async() method, so we don't need list all children of its parent and hence to do a status for each. Rather than passing a "created" flag out and forcing call sites to then do a second call to update message counts, just simply take a boolean param indicating if we should do it here. (Account::list_child_folders_async): Simplified a bit, updated to create and cache an Imap.Folder for each child. (Account::fetch_counts_async): Removed and merged into fetch_folder_cached_async() since the only call site was replaced by the new refresh_counts param on that method. (Account::send_list_async, send_status_async): renamed from list_children_async and fetch_status_async, to make it obvious about what they are actually doing. Added an instance of ClientSession as first param so they don't have to re-claim the same session. (Account::send_command_async, send_multiple_async): Also add an instance of ClientSession as first param so they don't have to re-claim a session after the public methods calling them have already done so. * src/engine/imap/api/imap-folder.vala (Folder): As for Imap.Account, remove mailbox info delim (these were redundant anyway) and replace uses on the folder's client session for converting between folder paths and mailbox names. * src/engine/api/geary-folder-path.vala (FolderPath): Remove get_fullpath(), since having it would only encourage API users to do the wrong thing. * src/engine/imap/message/imap-mailbox-specifier.vala (MailboxSpecifier::from_folder_path): Ensure the inbox name is also passed in and manually construct a mailbox name from a FolderPath so the connection's actual inbox name ca be substituted in.
2017-11-02 18:05:54 +11:00
private async void refresh_unseen_async(Geary.Folder folder, Cancellable? cancellable)
throws Error {
debug("Refreshing unseen counts for %s", folder.to_string());
Use Imap.ClientSession for mapping between folder and mailbox names. Now that ClientSession is storing per-connection inbox and namespace data, we want to always consult with the account or folder's session to determine the correct Imap.MailboxSpecifier name for a high-level Geary.FolderPath, and vice versa. This is enforced by removing all inbox and delim information from Imap.Accout and Imap.Folder, and providing methods to translate between MailboxSpecifier and FolderPath, then fixing up the fallout. * src/engine/imap/transport/imap-client-session.vala (ClientSession): Add methods for obtaining the delimiter and converting between foler paths and mailbox names, based on information obtainined from the IMAP server for this connection. * src/engine/imap/api/imap-account.vala (Account): Remove path_to_mailbox, inbox_specifier, and hierarchy_delimiter object attributes since these are connection specific. Convert from caching all mailbox specifiers retreived from the server and some Imap.Folder instances to simply cache all Folder instances. Substantially rework the public API implementation as below to support this and update all call sites. (Account::folder_exists_async): Actually hit the server rather than justing looking at the cache to determine if the folder exists, remove a folder from the cache if not. (Account::fetch_folder_async): Renamed from "fetch_unrecycled_folder_async" so as to be a bit less obtuse, updated call sites. (Account::fetch_folder_cached_async): Renamed from fetch_folder_async to be a bit more obvious. Substantially simplified, deleates to fetch_folder_async() rather than list_children_async() method, so we don't need list all children of its parent and hence to do a status for each. Rather than passing a "created" flag out and forcing call sites to then do a second call to update message counts, just simply take a boolean param indicating if we should do it here. (Account::list_child_folders_async): Simplified a bit, updated to create and cache an Imap.Folder for each child. (Account::fetch_counts_async): Removed and merged into fetch_folder_cached_async() since the only call site was replaced by the new refresh_counts param on that method. (Account::send_list_async, send_status_async): renamed from list_children_async and fetch_status_async, to make it obvious about what they are actually doing. Added an instance of ClientSession as first param so they don't have to re-claim the same session. (Account::send_command_async, send_multiple_async): Also add an instance of ClientSession as first param so they don't have to re-claim a session after the public methods calling them have already done so. * src/engine/imap/api/imap-folder.vala (Folder): As for Imap.Account, remove mailbox info delim (these were redundant anyway) and replace uses on the folder's client session for converting between folder paths and mailbox names. * src/engine/api/geary-folder-path.vala (FolderPath): Remove get_fullpath(), since having it would only encourage API users to do the wrong thing. * src/engine/imap/message/imap-mailbox-specifier.vala (MailboxSpecifier::from_folder_path): Ensure the inbox name is also passed in and manually construct a mailbox name from a FolderPath so the connection's actual inbox name ca be substituted in.
2017-11-02 18:05:54 +11:00
try {
Use Imap.ClientSession for mapping between folder and mailbox names. Now that ClientSession is storing per-connection inbox and namespace data, we want to always consult with the account or folder's session to determine the correct Imap.MailboxSpecifier name for a high-level Geary.FolderPath, and vice versa. This is enforced by removing all inbox and delim information from Imap.Accout and Imap.Folder, and providing methods to translate between MailboxSpecifier and FolderPath, then fixing up the fallout. * src/engine/imap/transport/imap-client-session.vala (ClientSession): Add methods for obtaining the delimiter and converting between foler paths and mailbox names, based on information obtainined from the IMAP server for this connection. * src/engine/imap/api/imap-account.vala (Account): Remove path_to_mailbox, inbox_specifier, and hierarchy_delimiter object attributes since these are connection specific. Convert from caching all mailbox specifiers retreived from the server and some Imap.Folder instances to simply cache all Folder instances. Substantially rework the public API implementation as below to support this and update all call sites. (Account::folder_exists_async): Actually hit the server rather than justing looking at the cache to determine if the folder exists, remove a folder from the cache if not. (Account::fetch_folder_async): Renamed from "fetch_unrecycled_folder_async" so as to be a bit less obtuse, updated call sites. (Account::fetch_folder_cached_async): Renamed from fetch_folder_async to be a bit more obvious. Substantially simplified, deleates to fetch_folder_async() rather than list_children_async() method, so we don't need list all children of its parent and hence to do a status for each. Rather than passing a "created" flag out and forcing call sites to then do a second call to update message counts, just simply take a boolean param indicating if we should do it here. (Account::list_child_folders_async): Simplified a bit, updated to create and cache an Imap.Folder for each child. (Account::fetch_counts_async): Removed and merged into fetch_folder_cached_async() since the only call site was replaced by the new refresh_counts param on that method. (Account::send_list_async, send_status_async): renamed from list_children_async and fetch_status_async, to make it obvious about what they are actually doing. Added an instance of ClientSession as first param so they don't have to re-claim the same session. (Account::send_command_async, send_multiple_async): Also add an instance of ClientSession as first param so they don't have to re-claim a session after the public methods calling them have already done so. * src/engine/imap/api/imap-folder.vala (Folder): As for Imap.Account, remove mailbox info delim (these were redundant anyway) and replace uses on the folder's client session for converting between folder paths and mailbox names. * src/engine/api/geary-folder-path.vala (FolderPath): Remove get_fullpath(), since having it would only encourage API users to do the wrong thing. * src/engine/imap/message/imap-mailbox-specifier.vala (MailboxSpecifier::from_folder_path): Ensure the inbox name is also passed in and manually construct a mailbox name from a FolderPath so the connection's actual inbox name ca be substituted in.
2017-11-02 18:05:54 +11:00
Imap.Folder remote_folder = yield remote.fetch_folder_cached_async(
folder.path,
true,
cancellable
);
yield local.update_folder_status_async(remote_folder, false, true, cancellable);
} finally {
// added when call scheduled (above)
in_refresh_unseen.remove(folder);
}
}
Use Imap.ClientSession for mapping between folder and mailbox names. Now that ClientSession is storing per-connection inbox and namespace data, we want to always consult with the account or folder's session to determine the correct Imap.MailboxSpecifier name for a high-level Geary.FolderPath, and vice versa. This is enforced by removing all inbox and delim information from Imap.Accout and Imap.Folder, and providing methods to translate between MailboxSpecifier and FolderPath, then fixing up the fallout. * src/engine/imap/transport/imap-client-session.vala (ClientSession): Add methods for obtaining the delimiter and converting between foler paths and mailbox names, based on information obtainined from the IMAP server for this connection. * src/engine/imap/api/imap-account.vala (Account): Remove path_to_mailbox, inbox_specifier, and hierarchy_delimiter object attributes since these are connection specific. Convert from caching all mailbox specifiers retreived from the server and some Imap.Folder instances to simply cache all Folder instances. Substantially rework the public API implementation as below to support this and update all call sites. (Account::folder_exists_async): Actually hit the server rather than justing looking at the cache to determine if the folder exists, remove a folder from the cache if not. (Account::fetch_folder_async): Renamed from "fetch_unrecycled_folder_async" so as to be a bit less obtuse, updated call sites. (Account::fetch_folder_cached_async): Renamed from fetch_folder_async to be a bit more obvious. Substantially simplified, deleates to fetch_folder_async() rather than list_children_async() method, so we don't need list all children of its parent and hence to do a status for each. Rather than passing a "created" flag out and forcing call sites to then do a second call to update message counts, just simply take a boolean param indicating if we should do it here. (Account::list_child_folders_async): Simplified a bit, updated to create and cache an Imap.Folder for each child. (Account::fetch_counts_async): Removed and merged into fetch_folder_cached_async() since the only call site was replaced by the new refresh_counts param on that method. (Account::send_list_async, send_status_async): renamed from list_children_async and fetch_status_async, to make it obvious about what they are actually doing. Added an instance of ClientSession as first param so they don't have to re-claim the same session. (Account::send_command_async, send_multiple_async): Also add an instance of ClientSession as first param so they don't have to re-claim a session after the public methods calling them have already done so. * src/engine/imap/api/imap-folder.vala (Folder): As for Imap.Account, remove mailbox info delim (these were redundant anyway) and replace uses on the folder's client session for converting between folder paths and mailbox names. * src/engine/api/geary-folder-path.vala (FolderPath): Remove get_fullpath(), since having it would only encourage API users to do the wrong thing. * src/engine/imap/message/imap-mailbox-specifier.vala (MailboxSpecifier::from_folder_path): Ensure the inbox name is also passed in and manually construct a mailbox name from a FolderPath so the connection's actual inbox name ca be substituted in.
2017-11-02 18:05:54 +11:00
private void reschedule_folder_refresh(bool immediate) {
if (in_refresh_enumerate)
return;
cancel_folder_refresh();
refresh_folder_timeout_id = immediate
? Idle.add(on_refresh_folders)
: Timeout.add_seconds(REFRESH_FOLDER_LIST_SEC, on_refresh_folders);
}
private void cancel_folder_refresh() {
if (refresh_folder_timeout_id != 0) {
Source.remove(refresh_folder_timeout_id);
refresh_folder_timeout_id = 0;
}
}
private bool on_refresh_folders() {
in_refresh_enumerate = true;
enumerate_folders_async.begin(refresh_cancellable, on_refresh_completed);
refresh_folder_timeout_id = 0;
return false;
}
private void on_refresh_completed(Object? source, AsyncResult result) {
try {
enumerate_folders_async.end(result);
} catch (Error err) {
if (!(err is IOError.CANCELLED))
debug("Refresh of account %s folders did not complete: %s", to_string(), err.message);
}
in_refresh_enumerate = false;
reschedule_folder_refresh(false);
}
private async void enumerate_folders_async(Cancellable? cancellable) throws Error {
Remove SQLHeavy: Closes #5034 It is done. Initial implementation of the new database subsystem These pieces represent the foundation for ticket #5034 Expanded transactions, added VersionedDatabase Further expansions of the async code. Moved async pool logic into Database, where it realistically belongs. Further improvements. Introduced geary-db-test. Added SQL create and update files for Geary.Db version-001 to version-003 are exact copies of the SQLHeavy scripts to ensure no slight changes when migrating. version-004 upgrades the database to remove the ImapFolderPropertiesTable and ImapMessagePropertiesTable, now that the database code is pure IMAP. When we support other messaging systems (such as POP3), those subsystems will need to code their own database layers OR rely on the IMAP schema and simply ignore the IMAP-specific fields. ImapDB.Account fleshed out ImapDB.Folder is commented out, however. Need to port next. ImapDB.Folder fleshed out MessageTable, MessageLocationTable, and AttachementTable are now handled inside ImapDB.Folder. chmod -x imap-db-database.vala OutboxEmailIdentifier/Properties -> SmtpOutboxEmailIdentifier/Properties Moved SmtpOutboxFolderRoot into its own source file SmtpOutboxFolder ported to new database code Move Engine implementations to ImapDB. Integration and cleanup of new database code with main source This commit performs the final integration steps to move Geary completely over to the new database model. This also cleans out the old SQLHeavy-based code and fixes a handful of small bugs that were detected during basic test runs. Moved Outbox to ImapDB As the Outbox is tied to the database that ImapDB runs, move the Outbox code into that folder. Outbox fixes and better parameter checking Bumped Database thread pool count and made them exclusive My reasoning is that there may be a need for a lot of threads at once (when a big batch of commands comes in, especially at startup). If performance looks ok, we might consider relaxing this later.
2012-06-14 14:47:53 -07:00
check_open();
// enumerate local folders first
Gee.HashMap<FolderPath, ImapDB.Folder> local_folders = yield enumerate_local_folders_async(
null, cancellable);
// convert to a list of Geary.Folder ... build_folder() also reports new folders, so this
// gets the word out quickly (local_only folders have already been reported)
Gee.Collection<Geary.Folder> existing_list = new Gee.ArrayList<Geary.Folder>();
existing_list.add_all(build_folders(local_folders.values));
existing_list.add_all(local_only.values);
// build a map of all existing folders
Gee.HashMap<FolderPath, Geary.Folder> existing_folders
= Geary.traverse<Geary.Folder>(existing_list).to_hash_map<FolderPath>(f => f.path);
// now that all local have been enumerated and reported (this is important to assist
// startup of the UI), enumerate the remote folders
bool remote_folders_suspect;
Gee.HashMap<FolderPath, Imap.Folder>? remote_folders = yield enumerate_remote_folders_async(
null, out remote_folders_suspect, cancellable);
// pair the local and remote folders and make sure everything is up-to-date
yield update_folders_async(existing_folders, remote_folders, remote_folders_suspect, cancellable);
}
private async Gee.HashMap<FolderPath, ImapDB.Folder> enumerate_local_folders_async(
Geary.FolderPath? parent, Cancellable? cancellable) throws Error {
check_open();
Gee.Collection<ImapDB.Folder>? local_children = null;
try {
local_children = yield local.list_folders_async(parent, cancellable);
} catch (EngineError err) {
// don't pass on NOT_FOUND's, that means we need to go to the server for more info
if (!(err is EngineError.NOT_FOUND))
throw err;
}
Gee.HashMap<FolderPath, ImapDB.Folder> result = new Gee.HashMap<FolderPath, ImapDB.Folder>();
if (local_children != null) {
foreach (ImapDB.Folder local_child in local_children) {
result.set(local_child.get_path(), local_child);
Collection.map_set_all<FolderPath, ImapDB.Folder>(result,
yield enumerate_local_folders_async(local_child.get_path(), cancellable));
}
}
return result;
}
private async Gee.HashMap<FolderPath, Imap.Folder> enumerate_remote_folders_async(
Geary.FolderPath? parent, out bool results_suspect, Cancellable? cancellable) throws Error {
results_suspect = false;
check_open();
Gee.List<Imap.Folder> remote_children = null;
try {
remote_children = yield remote.fetch_child_folders_async(parent, cancellable);
} catch (Error err) {
// ignore everything but I/O and IMAP errors (cancellation is an IOError)
if (err is IOError || err is ImapError)
throw err;
debug("Ignoring error listing child folders of %s: %s",
(parent != null ? parent.to_string() : "root"), err.message);
results_suspect = true;
}
Gee.HashMap<FolderPath, Imap.Folder> result = new Gee.HashMap<FolderPath, Imap.Folder>();
foreach (Imap.Folder remote_child in remote_children) {
result.set(remote_child.path, remote_child);
if (remote_child.properties.has_children.is_possible()) {
bool recursive_results_suspect;
Collection.map_set_all<FolderPath, Imap.Folder>(
result, yield enumerate_remote_folders_async(
remote_child.path, out recursive_results_suspect, cancellable
)
);
if (recursive_results_suspect)
results_suspect = true;
}
}
return result;
}
public override Geary.ContactStore get_contact_store() {
return local.contact_store;
}
protected virtual Geary.SpecialFolderType[] get_supported_special_folders() {
return SUPPORTED_SPECIAL_FOLDERS;
}
public override async bool folder_exists_async(Geary.FolderPath path,
Cancellable? cancellable = null) throws Error {
Remove SQLHeavy: Closes #5034 It is done. Initial implementation of the new database subsystem These pieces represent the foundation for ticket #5034 Expanded transactions, added VersionedDatabase Further expansions of the async code. Moved async pool logic into Database, where it realistically belongs. Further improvements. Introduced geary-db-test. Added SQL create and update files for Geary.Db version-001 to version-003 are exact copies of the SQLHeavy scripts to ensure no slight changes when migrating. version-004 upgrades the database to remove the ImapFolderPropertiesTable and ImapMessagePropertiesTable, now that the database code is pure IMAP. When we support other messaging systems (such as POP3), those subsystems will need to code their own database layers OR rely on the IMAP schema and simply ignore the IMAP-specific fields. ImapDB.Account fleshed out ImapDB.Folder is commented out, however. Need to port next. ImapDB.Folder fleshed out MessageTable, MessageLocationTable, and AttachementTable are now handled inside ImapDB.Folder. chmod -x imap-db-database.vala OutboxEmailIdentifier/Properties -> SmtpOutboxEmailIdentifier/Properties Moved SmtpOutboxFolderRoot into its own source file SmtpOutboxFolder ported to new database code Move Engine implementations to ImapDB. Integration and cleanup of new database code with main source This commit performs the final integration steps to move Geary completely over to the new database model. This also cleans out the old SQLHeavy-based code and fixes a handful of small bugs that were detected during basic test runs. Moved Outbox to ImapDB As the Outbox is tied to the database that ImapDB runs, move the Outbox code into that folder. Outbox fixes and better parameter checking Bumped Database thread pool count and made them exclusive My reasoning is that there may be a need for a lot of threads at once (when a big batch of commands comes in, especially at startup). If performance looks ok, we might consider relaxing this later.
2012-06-14 14:47:53 -07:00
check_open();
if (yield local.folder_exists_async(path, cancellable))
return true;
return yield remote.folder_exists_async(path, cancellable);
}
// TODO: This needs to be made into a single transaction
public override async Geary.Folder fetch_folder_async(Geary.FolderPath path,
Cancellable? cancellable = null) throws Error {
Remove SQLHeavy: Closes #5034 It is done. Initial implementation of the new database subsystem These pieces represent the foundation for ticket #5034 Expanded transactions, added VersionedDatabase Further expansions of the async code. Moved async pool logic into Database, where it realistically belongs. Further improvements. Introduced geary-db-test. Added SQL create and update files for Geary.Db version-001 to version-003 are exact copies of the SQLHeavy scripts to ensure no slight changes when migrating. version-004 upgrades the database to remove the ImapFolderPropertiesTable and ImapMessagePropertiesTable, now that the database code is pure IMAP. When we support other messaging systems (such as POP3), those subsystems will need to code their own database layers OR rely on the IMAP schema and simply ignore the IMAP-specific fields. ImapDB.Account fleshed out ImapDB.Folder is commented out, however. Need to port next. ImapDB.Folder fleshed out MessageTable, MessageLocationTable, and AttachementTable are now handled inside ImapDB.Folder. chmod -x imap-db-database.vala OutboxEmailIdentifier/Properties -> SmtpOutboxEmailIdentifier/Properties Moved SmtpOutboxFolderRoot into its own source file SmtpOutboxFolder ported to new database code Move Engine implementations to ImapDB. Integration and cleanup of new database code with main source This commit performs the final integration steps to move Geary completely over to the new database model. This also cleans out the old SQLHeavy-based code and fixes a handful of small bugs that were detected during basic test runs. Moved Outbox to ImapDB As the Outbox is tied to the database that ImapDB runs, move the Outbox code into that folder. Outbox fixes and better parameter checking Bumped Database thread pool count and made them exclusive My reasoning is that there may be a need for a lot of threads at once (when a big batch of commands comes in, especially at startup). If performance looks ok, we might consider relaxing this later.
2012-06-14 14:47:53 -07:00
check_open();
if (local_only.has_key(path))
return local_only.get(path);
try {
Remove SQLHeavy: Closes #5034 It is done. Initial implementation of the new database subsystem These pieces represent the foundation for ticket #5034 Expanded transactions, added VersionedDatabase Further expansions of the async code. Moved async pool logic into Database, where it realistically belongs. Further improvements. Introduced geary-db-test. Added SQL create and update files for Geary.Db version-001 to version-003 are exact copies of the SQLHeavy scripts to ensure no slight changes when migrating. version-004 upgrades the database to remove the ImapFolderPropertiesTable and ImapMessagePropertiesTable, now that the database code is pure IMAP. When we support other messaging systems (such as POP3), those subsystems will need to code their own database layers OR rely on the IMAP schema and simply ignore the IMAP-specific fields. ImapDB.Account fleshed out ImapDB.Folder is commented out, however. Need to port next. ImapDB.Folder fleshed out MessageTable, MessageLocationTable, and AttachementTable are now handled inside ImapDB.Folder. chmod -x imap-db-database.vala OutboxEmailIdentifier/Properties -> SmtpOutboxEmailIdentifier/Properties Moved SmtpOutboxFolderRoot into its own source file SmtpOutboxFolder ported to new database code Move Engine implementations to ImapDB. Integration and cleanup of new database code with main source This commit performs the final integration steps to move Geary completely over to the new database model. This also cleans out the old SQLHeavy-based code and fixes a handful of small bugs that were detected during basic test runs. Moved Outbox to ImapDB As the Outbox is tied to the database that ImapDB runs, move the Outbox code into that folder. Outbox fixes and better parameter checking Bumped Database thread pool count and made them exclusive My reasoning is that there may be a need for a lot of threads at once (when a big batch of commands comes in, especially at startup). If performance looks ok, we might consider relaxing this later.
2012-06-14 14:47:53 -07:00
return build_folder((ImapDB.Folder) yield local.fetch_folder_async(path, cancellable));
} catch (EngineError err) {
// don't thrown NOT_FOUND's, that means we need to fall through and clone from the
// server
if (!(err is EngineError.NOT_FOUND))
throw err;
}
// clone the entire path
int length = path.get_path_length();
for (int ctr = 0; ctr < length; ctr++) {
Geary.FolderPath folder = path.get_folder_at(ctr);
Use Imap.ClientSession for mapping between folder and mailbox names. Now that ClientSession is storing per-connection inbox and namespace data, we want to always consult with the account or folder's session to determine the correct Imap.MailboxSpecifier name for a high-level Geary.FolderPath, and vice versa. This is enforced by removing all inbox and delim information from Imap.Accout and Imap.Folder, and providing methods to translate between MailboxSpecifier and FolderPath, then fixing up the fallout. * src/engine/imap/transport/imap-client-session.vala (ClientSession): Add methods for obtaining the delimiter and converting between foler paths and mailbox names, based on information obtainined from the IMAP server for this connection. * src/engine/imap/api/imap-account.vala (Account): Remove path_to_mailbox, inbox_specifier, and hierarchy_delimiter object attributes since these are connection specific. Convert from caching all mailbox specifiers retreived from the server and some Imap.Folder instances to simply cache all Folder instances. Substantially rework the public API implementation as below to support this and update all call sites. (Account::folder_exists_async): Actually hit the server rather than justing looking at the cache to determine if the folder exists, remove a folder from the cache if not. (Account::fetch_folder_async): Renamed from "fetch_unrecycled_folder_async" so as to be a bit less obtuse, updated call sites. (Account::fetch_folder_cached_async): Renamed from fetch_folder_async to be a bit more obvious. Substantially simplified, deleates to fetch_folder_async() rather than list_children_async() method, so we don't need list all children of its parent and hence to do a status for each. Rather than passing a "created" flag out and forcing call sites to then do a second call to update message counts, just simply take a boolean param indicating if we should do it here. (Account::list_child_folders_async): Simplified a bit, updated to create and cache an Imap.Folder for each child. (Account::fetch_counts_async): Removed and merged into fetch_folder_cached_async() since the only call site was replaced by the new refresh_counts param on that method. (Account::send_list_async, send_status_async): renamed from list_children_async and fetch_status_async, to make it obvious about what they are actually doing. Added an instance of ClientSession as first param so they don't have to re-claim the same session. (Account::send_command_async, send_multiple_async): Also add an instance of ClientSession as first param so they don't have to re-claim a session after the public methods calling them have already done so. * src/engine/imap/api/imap-folder.vala (Folder): As for Imap.Account, remove mailbox info delim (these were redundant anyway) and replace uses on the folder's client session for converting between folder paths and mailbox names. * src/engine/api/geary-folder-path.vala (FolderPath): Remove get_fullpath(), since having it would only encourage API users to do the wrong thing. * src/engine/imap/message/imap-mailbox-specifier.vala (MailboxSpecifier::from_folder_path): Ensure the inbox name is also passed in and manually construct a mailbox name from a FolderPath so the connection's actual inbox name ca be substituted in.
2017-11-02 18:05:54 +11:00
if (yield local.folder_exists_async(folder))
continue;
Use Imap.ClientSession for mapping between folder and mailbox names. Now that ClientSession is storing per-connection inbox and namespace data, we want to always consult with the account or folder's session to determine the correct Imap.MailboxSpecifier name for a high-level Geary.FolderPath, and vice versa. This is enforced by removing all inbox and delim information from Imap.Accout and Imap.Folder, and providing methods to translate between MailboxSpecifier and FolderPath, then fixing up the fallout. * src/engine/imap/transport/imap-client-session.vala (ClientSession): Add methods for obtaining the delimiter and converting between foler paths and mailbox names, based on information obtainined from the IMAP server for this connection. * src/engine/imap/api/imap-account.vala (Account): Remove path_to_mailbox, inbox_specifier, and hierarchy_delimiter object attributes since these are connection specific. Convert from caching all mailbox specifiers retreived from the server and some Imap.Folder instances to simply cache all Folder instances. Substantially rework the public API implementation as below to support this and update all call sites. (Account::folder_exists_async): Actually hit the server rather than justing looking at the cache to determine if the folder exists, remove a folder from the cache if not. (Account::fetch_folder_async): Renamed from "fetch_unrecycled_folder_async" so as to be a bit less obtuse, updated call sites. (Account::fetch_folder_cached_async): Renamed from fetch_folder_async to be a bit more obvious. Substantially simplified, deleates to fetch_folder_async() rather than list_children_async() method, so we don't need list all children of its parent and hence to do a status for each. Rather than passing a "created" flag out and forcing call sites to then do a second call to update message counts, just simply take a boolean param indicating if we should do it here. (Account::list_child_folders_async): Simplified a bit, updated to create and cache an Imap.Folder for each child. (Account::fetch_counts_async): Removed and merged into fetch_folder_cached_async() since the only call site was replaced by the new refresh_counts param on that method. (Account::send_list_async, send_status_async): renamed from list_children_async and fetch_status_async, to make it obvious about what they are actually doing. Added an instance of ClientSession as first param so they don't have to re-claim the same session. (Account::send_command_async, send_multiple_async): Also add an instance of ClientSession as first param so they don't have to re-claim a session after the public methods calling them have already done so. * src/engine/imap/api/imap-folder.vala (Folder): As for Imap.Account, remove mailbox info delim (these were redundant anyway) and replace uses on the folder's client session for converting between folder paths and mailbox names. * src/engine/api/geary-folder-path.vala (FolderPath): Remove get_fullpath(), since having it would only encourage API users to do the wrong thing. * src/engine/imap/message/imap-mailbox-specifier.vala (MailboxSpecifier::from_folder_path): Ensure the inbox name is also passed in and manually construct a mailbox name from a FolderPath so the connection's actual inbox name ca be substituted in.
2017-11-02 18:05:54 +11:00
Imap.Folder remote_folder = yield remote.fetch_folder_cached_async(
folder, false, cancellable
);
yield local.clone_folder_async(remote_folder, cancellable);
}
// Fetch the local account's version of the folder for the MinimalFolder
Remove SQLHeavy: Closes #5034 It is done. Initial implementation of the new database subsystem These pieces represent the foundation for ticket #5034 Expanded transactions, added VersionedDatabase Further expansions of the async code. Moved async pool logic into Database, where it realistically belongs. Further improvements. Introduced geary-db-test. Added SQL create and update files for Geary.Db version-001 to version-003 are exact copies of the SQLHeavy scripts to ensure no slight changes when migrating. version-004 upgrades the database to remove the ImapFolderPropertiesTable and ImapMessagePropertiesTable, now that the database code is pure IMAP. When we support other messaging systems (such as POP3), those subsystems will need to code their own database layers OR rely on the IMAP schema and simply ignore the IMAP-specific fields. ImapDB.Account fleshed out ImapDB.Folder is commented out, however. Need to port next. ImapDB.Folder fleshed out MessageTable, MessageLocationTable, and AttachementTable are now handled inside ImapDB.Folder. chmod -x imap-db-database.vala OutboxEmailIdentifier/Properties -> SmtpOutboxEmailIdentifier/Properties Moved SmtpOutboxFolderRoot into its own source file SmtpOutboxFolder ported to new database code Move Engine implementations to ImapDB. Integration and cleanup of new database code with main source This commit performs the final integration steps to move Geary completely over to the new database model. This also cleans out the old SQLHeavy-based code and fixes a handful of small bugs that were detected during basic test runs. Moved Outbox to ImapDB As the Outbox is tied to the database that ImapDB runs, move the Outbox code into that folder. Outbox fixes and better parameter checking Bumped Database thread pool count and made them exclusive My reasoning is that there may be a need for a lot of threads at once (when a big batch of commands comes in, especially at startup). If performance looks ok, we might consider relaxing this later.
2012-06-14 14:47:53 -07:00
return build_folder((ImapDB.Folder) yield local.fetch_folder_async(path, cancellable));
}
/**
* Returns an Imap.Folder that is not connected (is detached) to a MinimalFolder or any other
* ImapEngine container.
*
* This is useful for one-shot operations that need to bypass the heavyweight synchronization
* routines inside MinimalFolder. This also means that operations performed on this Folder will
* not be reflected in the local database unless there's a separate connection to the server
* that is notified or detects these changes.
*
* The returned Folder must be opened prior to use and closed once completed. ''Leaving a
* Folder open will cause a connection leak.''
*
* It is not recommended this object be held open long-term, or that its status or notifications
* be directly written to the database unless you know exactly what you're doing. ''Caveat
* implementor.''
*/
public async Imap.Folder fetch_detached_folder_async(Geary.FolderPath path, Cancellable? cancellable)
throws Error {
check_open();
Use Imap.ClientSession for mapping between folder and mailbox names. Now that ClientSession is storing per-connection inbox and namespace data, we want to always consult with the account or folder's session to determine the correct Imap.MailboxSpecifier name for a high-level Geary.FolderPath, and vice versa. This is enforced by removing all inbox and delim information from Imap.Accout and Imap.Folder, and providing methods to translate between MailboxSpecifier and FolderPath, then fixing up the fallout. * src/engine/imap/transport/imap-client-session.vala (ClientSession): Add methods for obtaining the delimiter and converting between foler paths and mailbox names, based on information obtainined from the IMAP server for this connection. * src/engine/imap/api/imap-account.vala (Account): Remove path_to_mailbox, inbox_specifier, and hierarchy_delimiter object attributes since these are connection specific. Convert from caching all mailbox specifiers retreived from the server and some Imap.Folder instances to simply cache all Folder instances. Substantially rework the public API implementation as below to support this and update all call sites. (Account::folder_exists_async): Actually hit the server rather than justing looking at the cache to determine if the folder exists, remove a folder from the cache if not. (Account::fetch_folder_async): Renamed from "fetch_unrecycled_folder_async" so as to be a bit less obtuse, updated call sites. (Account::fetch_folder_cached_async): Renamed from fetch_folder_async to be a bit more obvious. Substantially simplified, deleates to fetch_folder_async() rather than list_children_async() method, so we don't need list all children of its parent and hence to do a status for each. Rather than passing a "created" flag out and forcing call sites to then do a second call to update message counts, just simply take a boolean param indicating if we should do it here. (Account::list_child_folders_async): Simplified a bit, updated to create and cache an Imap.Folder for each child. (Account::fetch_counts_async): Removed and merged into fetch_folder_cached_async() since the only call site was replaced by the new refresh_counts param on that method. (Account::send_list_async, send_status_async): renamed from list_children_async and fetch_status_async, to make it obvious about what they are actually doing. Added an instance of ClientSession as first param so they don't have to re-claim the same session. (Account::send_command_async, send_multiple_async): Also add an instance of ClientSession as first param so they don't have to re-claim a session after the public methods calling them have already done so. * src/engine/imap/api/imap-folder.vala (Folder): As for Imap.Account, remove mailbox info delim (these were redundant anyway) and replace uses on the folder's client session for converting between folder paths and mailbox names. * src/engine/api/geary-folder-path.vala (FolderPath): Remove get_fullpath(), since having it would only encourage API users to do the wrong thing. * src/engine/imap/message/imap-mailbox-specifier.vala (MailboxSpecifier::from_folder_path): Ensure the inbox name is also passed in and manually construct a mailbox name from a FolderPath so the connection's actual inbox name ca be substituted in.
2017-11-02 18:05:54 +11:00
if (local_only.has_key(path)) {
throw new EngineError.NOT_FOUND("%s: path %s points to local-only folder, not IMAP",
to_string(), path.to_string());
}
Use Imap.ClientSession for mapping between folder and mailbox names. Now that ClientSession is storing per-connection inbox and namespace data, we want to always consult with the account or folder's session to determine the correct Imap.MailboxSpecifier name for a high-level Geary.FolderPath, and vice versa. This is enforced by removing all inbox and delim information from Imap.Accout and Imap.Folder, and providing methods to translate between MailboxSpecifier and FolderPath, then fixing up the fallout. * src/engine/imap/transport/imap-client-session.vala (ClientSession): Add methods for obtaining the delimiter and converting between foler paths and mailbox names, based on information obtainined from the IMAP server for this connection. * src/engine/imap/api/imap-account.vala (Account): Remove path_to_mailbox, inbox_specifier, and hierarchy_delimiter object attributes since these are connection specific. Convert from caching all mailbox specifiers retreived from the server and some Imap.Folder instances to simply cache all Folder instances. Substantially rework the public API implementation as below to support this and update all call sites. (Account::folder_exists_async): Actually hit the server rather than justing looking at the cache to determine if the folder exists, remove a folder from the cache if not. (Account::fetch_folder_async): Renamed from "fetch_unrecycled_folder_async" so as to be a bit less obtuse, updated call sites. (Account::fetch_folder_cached_async): Renamed from fetch_folder_async to be a bit more obvious. Substantially simplified, deleates to fetch_folder_async() rather than list_children_async() method, so we don't need list all children of its parent and hence to do a status for each. Rather than passing a "created" flag out and forcing call sites to then do a second call to update message counts, just simply take a boolean param indicating if we should do it here. (Account::list_child_folders_async): Simplified a bit, updated to create and cache an Imap.Folder for each child. (Account::fetch_counts_async): Removed and merged into fetch_folder_cached_async() since the only call site was replaced by the new refresh_counts param on that method. (Account::send_list_async, send_status_async): renamed from list_children_async and fetch_status_async, to make it obvious about what they are actually doing. Added an instance of ClientSession as first param so they don't have to re-claim the same session. (Account::send_command_async, send_multiple_async): Also add an instance of ClientSession as first param so they don't have to re-claim a session after the public methods calling them have already done so. * src/engine/imap/api/imap-folder.vala (Folder): As for Imap.Account, remove mailbox info delim (these were redundant anyway) and replace uses on the folder's client session for converting between folder paths and mailbox names. * src/engine/api/geary-folder-path.vala (FolderPath): Remove get_fullpath(), since having it would only encourage API users to do the wrong thing. * src/engine/imap/message/imap-mailbox-specifier.vala (MailboxSpecifier::from_folder_path): Ensure the inbox name is also passed in and manually construct a mailbox name from a FolderPath so the connection's actual inbox name ca be substituted in.
2017-11-02 18:05:54 +11:00
return yield remote.fetch_folder_async(path, cancellable);
}
private void compile_special_search_names() {
/*
* Compiles the list of names used to search for special
* folders when they aren't known in advance and the server
* supports neither SPECIAL-USE not XLIST.
*
* Uses both translated and untranslated names in case the
* server has not localised the folders that match the login
* session's language. Also checks for lower-case versions of
* each.
*/
foreach (Geary.SpecialFolderType type in get_supported_special_folders()) {
Gee.List<string> compiled = new Gee.ArrayList<string>();
foreach (string names in get_special_search_names(type)) {
foreach (string name in names.split("|")) {
name = name.strip();
if (name.length != 0) {
if (!(name in compiled)) {
compiled.add(name);
}
name = name.down();
if (!(name in compiled)) {
compiled.add(name);
}
}
}
}
special_search_names.set(type, compiled);
}
}
private Gee.List<string> get_special_search_names(Geary.SpecialFolderType type) {
Gee.List<string> loc_names = new Gee.ArrayList<string>();
Gee.List<string> unloc_names = new Gee.ArrayList<string>();
switch (type) {
case Geary.SpecialFolderType.DRAFTS:
// List of general possible folder names to match for the
// Draft mailbox. Separate names using a vertical bar and
// put the most common localized name to the front for the
// default. English names do not need to be included.
loc_names.add(_("Drafts | Draft"));
unloc_names.add("Drafts | Draft");
break;
case Geary.SpecialFolderType.SENT:
// List of general possible folder names to match for the
// Sent mailbox. Separate names using a vertical bar and
// put the most common localized name to the front for the
// default. English names do not need to be included.
loc_names.add(_("Sent | Sent Mail | Sent Email | Sent E-Mail"));
unloc_names.add("Sent | Sent Mail | Sent Email | Sent E-Mail");
// The localised name(s) of the Sent folder name as used
// by MS Outlook/Exchange.
loc_names.add(NC_("Outlook localised name", "Sent Items"));
unloc_names.add("Sent Items");
break;
case Geary.SpecialFolderType.SPAM:
// List of general possible folder names to match for the
// Spam mailbox. Separate names using a vertical bar and
// put the most common localized name to the front for the
// default. English names do not need to be included.
loc_names.add(_("Junk | Spam | Junk Mail | Junk Email | Junk E-Mail | Bulk Mail | Bulk Email | Bulk E-Mail"));
unloc_names.add("Junk | Spam | Junk Mail | Junk Email | Junk E-Mail | Bulk Mail | Bulk Email | Bulk E-Mail");
break;
case Geary.SpecialFolderType.TRASH:
// List of general possible folder names to match for the
// Trash mailbox. Separate names using a vertical bar and
// put the most common localized name to the front for the
// default. English names do not need to be included.
loc_names.add(_("Trash | Rubbish | Rubbish Bin"));
unloc_names.add("Trash | Rubbish | Rubbish Bin");
// The localised name(s) of the Trash folder name as used
// by MS Outlook/Exchange.
loc_names.add(NC_("Outlook localised name", "Deleted Items"));
unloc_names.add("Deleted Items");
break;
case Geary.SpecialFolderType.ARCHIVE:
// List of general possible folder names to match for the
// Archive mailbox. Separate names using a vertical bar
// and put the most common localized name to the front for
// the default. English names do not need to be included.
loc_names.add(_("Archive | Archives"));
unloc_names.add("Archive | Archives");
break;
}
loc_names.add_all(unloc_names);
return loc_names;
}
private async Geary.Folder ensure_special_folder_async(Geary.SpecialFolderType special,
Cancellable? cancellable) throws Error {
Geary.Folder? folder = get_special_folder(special);
if (folder != null)
return folder;
MinimalFolder? minimal_folder = null;
Geary.FolderPath? path = information.get_special_folder_path(special);
if (path != null) {
debug("Previously used %s for special folder %s", path.to_string(), special.to_string());
} else {
// This is the first time we're turning a non-special folder into a special one.
// After we do this, we'll record which one we picked in the account info.
Geary.FolderPath root = yield remote.get_default_personal_namespace(cancellable);
Gee.List<string> search_names = special_search_names.get(special);
foreach (string search_name in search_names) {
Geary.FolderPath search_path = root.get_child(search_name);
foreach (Geary.FolderPath test_path in folder_map.keys) {
if (test_path.compare_normalized_ci(search_path) == 0) {
path = search_path;
break;
}
}
if (path != null)
break;
}
if (path == null)
path = root.get_child(search_names[0]);
information.set_special_folder_path(special, path);
yield information.store_async(cancellable);
}
if (path in folder_map.keys) {
debug("Promoting %s to special folder %s", path.to_string(), special.to_string());
minimal_folder = folder_map.get(path);
} else {
debug("Creating %s to use as special folder %s", path.to_string(), special.to_string());
// TODO: ignore error due to already existing.
yield remote.create_folder_async(path, cancellable);
minimal_folder = (MinimalFolder) yield fetch_folder_async(path, cancellable);
}
minimal_folder.set_special_folder_type(special);
return minimal_folder;
}
public override async Geary.Folder get_required_special_folder_async(Geary.SpecialFolderType special,
Cancellable? cancellable) throws Error {
if (!(special in get_supported_special_folders())) {
throw new EngineError.BAD_PARAMETERS(
"Invalid special folder type %s passed to get_required_special_folder_async",
special.to_string());
}
check_open();
return yield ensure_special_folder_async(special, cancellable);
}
private async void ensure_special_folders_async(Cancellable? cancellable) throws Error {
foreach (Geary.SpecialFolderType special in get_supported_special_folders())
yield ensure_special_folder_async(special, cancellable);
}
private async void update_folders_async(Gee.Map<FolderPath, Geary.Folder> existing_folders,
Gee.Map<FolderPath, Imap.Folder> remote_folders, bool remote_folders_suspect, Cancellable? cancellable) {
// update all remote folders properties in the local store and active in the system
2013-04-24 12:22:32 -07:00
Gee.HashSet<Geary.FolderPath> altered_paths = new Gee.HashSet<Geary.FolderPath>();
foreach (Imap.Folder remote_folder in remote_folders.values) {
MinimalFolder? minimal_folder = existing_folders.get(remote_folder.path)
as MinimalFolder;
if (minimal_folder == null)
continue;
// only worry about alterations if the remote is openable
2013-04-25 14:47:20 -07:00
if (remote_folder.properties.is_openable.is_possible()) {
ImapDB.Folder local_folder = minimal_folder.local_folder;
if (remote_folder.properties.have_contents_changed(local_folder.get_properties(),
minimal_folder.to_string())) {
altered_paths.add(remote_folder.path);
}
}
// always update, openable or not; have the folder update the UID info the next time
// it's opened
try {
yield local.update_folder_status_async(remote_folder, false, false, cancellable);
} catch (Error update_error) {
debug("Unable to update local folder %s with remote properties: %s",
remote_folder.to_string(), update_error.message);
}
// set the engine folder's special type
// (but only promote, not demote, since getting the special folder type via its
// properties relies on the optional XLIST extension)
// use this iteration to add discovered properties to map
if (minimal_folder.special_folder_type == SpecialFolderType.NONE)
minimal_folder.set_special_folder_type(remote_folder.properties.attrs.get_special_folder_type());
}
// If path in remote but not local, need to add it
Gee.ArrayList<Imap.Folder> to_add = Geary.traverse<Imap.Folder>(remote_folders.values)
.filter(f => !existing_folders.has_key(f.path))
.to_array_list();
// If path in local but not remote (and isn't local-only, i.e. the Outbox), need to remove it
Gee.ArrayList<Geary.Folder> to_remove
2016-10-04 00:06:54 +11:00
= Geary.traverse<Gee.Map.Entry<FolderPath,Geary.Folder>>(existing_folders)
.filter(e => !remote_folders.has_key(e.key) && !local_only.has_key(e.key))
.map<Geary.Folder>(e => (Geary.Folder) e.value)
.to_array_list();
// For folders to add, clone them and their properties locally
foreach (Geary.Imap.Folder remote_folder in to_add) {
try {
yield local.clone_folder_async(remote_folder, cancellable);
} catch (Error err) {
debug("Unable to add/remove folder %s to local store: %s", remote_folder.path.to_string(),
err.message);
}
}
// Create Geary.Folder objects for all added folders
Gee.ArrayList<ImapDB.Folder> folders_to_build = new Gee.ArrayList<ImapDB.Folder>();
foreach (Geary.Imap.Folder remote_folder in to_add) {
try {
folders_to_build.add(yield local.fetch_folder_async(remote_folder.path, cancellable));
} catch (Error convert_err) {
// This isn't fatal, but irksome ... in the future, when local folders are
// removed, it's possible for one to disappear between cloning it and fetching
// it
debug("Unable to fetch local folder after cloning: %s", convert_err.message);
}
}
2016-10-04 00:06:54 +11:00
Gee.Collection<MinimalFolder> engine_added = new Gee.ArrayList<MinimalFolder>();
engine_added.add_all(build_folders(folders_to_build));
Gee.ArrayList<Geary.Folder> engine_removed = new Gee.ArrayList<Geary.Folder>();
if (remote_folders_suspect) {
debug("Skipping removing folders due to prior errors");
} else {
notify_folders_available_unavailable(null, to_remove);
// Sort by path length descending, so we always remove children first.
to_remove.sort((a, b) => b.path.get_path_length() - a.path.get_path_length());
foreach (Geary.Folder folder in to_remove) {
try {
debug("Locally deleting removed folder %s", folder.to_string());
yield local.delete_folder_async(folder, cancellable);
engine_removed.add(folder);
} catch (Error e) {
debug("Unable to locally delete removed folder %s: %s", folder.to_string(), e.message);
}
}
}
if (engine_added.size > 0 || engine_removed.size > 0)
notify_folders_added_removed(sort_by_path(engine_added), sort_by_path(engine_removed));
remote.folders_removed(Geary.traverse<Geary.Folder>(engine_removed)
.map<FolderPath>(f => f.path).to_array_list());
// report all altered folders
if (altered_paths.size > 0) {
Gee.ArrayList<Geary.Folder> altered = new Gee.ArrayList<Geary.Folder>();
foreach (Geary.FolderPath altered_path in altered_paths) {
if (existing_folders.has_key(altered_path))
altered.add(existing_folders.get(altered_path));
else
debug("Unable to report %s altered: no local representation", altered_path.to_string());
}
if (altered.size > 0)
notify_folders_contents_altered(altered);
}
try {
yield ensure_special_folders_async(cancellable);
} catch (Error e) {
warning("Unable to ensure special folders: %s", e.message);
}
}
public override async void send_email_async(Geary.ComposedEmail composed,
Cancellable? cancellable = null) throws Error {
Remove SQLHeavy: Closes #5034 It is done. Initial implementation of the new database subsystem These pieces represent the foundation for ticket #5034 Expanded transactions, added VersionedDatabase Further expansions of the async code. Moved async pool logic into Database, where it realistically belongs. Further improvements. Introduced geary-db-test. Added SQL create and update files for Geary.Db version-001 to version-003 are exact copies of the SQLHeavy scripts to ensure no slight changes when migrating. version-004 upgrades the database to remove the ImapFolderPropertiesTable and ImapMessagePropertiesTable, now that the database code is pure IMAP. When we support other messaging systems (such as POP3), those subsystems will need to code their own database layers OR rely on the IMAP schema and simply ignore the IMAP-specific fields. ImapDB.Account fleshed out ImapDB.Folder is commented out, however. Need to port next. ImapDB.Folder fleshed out MessageTable, MessageLocationTable, and AttachementTable are now handled inside ImapDB.Folder. chmod -x imap-db-database.vala OutboxEmailIdentifier/Properties -> SmtpOutboxEmailIdentifier/Properties Moved SmtpOutboxFolderRoot into its own source file SmtpOutboxFolder ported to new database code Move Engine implementations to ImapDB. Integration and cleanup of new database code with main source This commit performs the final integration steps to move Geary completely over to the new database model. This also cleans out the old SQLHeavy-based code and fixes a handful of small bugs that were detected during basic test runs. Moved Outbox to ImapDB As the Outbox is tied to the database that ImapDB runs, move the Outbox code into that folder. Outbox fixes and better parameter checking Bumped Database thread pool count and made them exclusive My reasoning is that there may be a need for a lot of threads at once (when a big batch of commands comes in, especially at startup). If performance looks ok, we might consider relaxing this later.
2012-06-14 14:47:53 -07:00
check_open();
// TODO: we should probably not use someone else's FQDN in something
// that's supposed to be globally unique...
Geary.RFC822.Message rfc822 = new Geary.RFC822.Message.from_composed_email(
composed, GMime.utils_generate_message_id(information.get_smtp_endpoint().remote_address.hostname));
Remove SQLHeavy: Closes #5034 It is done. Initial implementation of the new database subsystem These pieces represent the foundation for ticket #5034 Expanded transactions, added VersionedDatabase Further expansions of the async code. Moved async pool logic into Database, where it realistically belongs. Further improvements. Introduced geary-db-test. Added SQL create and update files for Geary.Db version-001 to version-003 are exact copies of the SQLHeavy scripts to ensure no slight changes when migrating. version-004 upgrades the database to remove the ImapFolderPropertiesTable and ImapMessagePropertiesTable, now that the database code is pure IMAP. When we support other messaging systems (such as POP3), those subsystems will need to code their own database layers OR rely on the IMAP schema and simply ignore the IMAP-specific fields. ImapDB.Account fleshed out ImapDB.Folder is commented out, however. Need to port next. ImapDB.Folder fleshed out MessageTable, MessageLocationTable, and AttachementTable are now handled inside ImapDB.Folder. chmod -x imap-db-database.vala OutboxEmailIdentifier/Properties -> SmtpOutboxEmailIdentifier/Properties Moved SmtpOutboxFolderRoot into its own source file SmtpOutboxFolder ported to new database code Move Engine implementations to ImapDB. Integration and cleanup of new database code with main source This commit performs the final integration steps to move Geary completely over to the new database model. This also cleans out the old SQLHeavy-based code and fixes a handful of small bugs that were detected during basic test runs. Moved Outbox to ImapDB As the Outbox is tied to the database that ImapDB runs, move the Outbox code into that folder. Outbox fixes and better parameter checking Bumped Database thread pool count and made them exclusive My reasoning is that there may be a need for a lot of threads at once (when a big batch of commands comes in, especially at startup). If performance looks ok, we might consider relaxing this later.
2012-06-14 14:47:53 -07:00
// don't use create_email_async() as that requires the folder be open to use
yield local.outbox.enqueue_email_async(rfc822, cancellable);
}
private void on_email_sent(Geary.RFC822.Message rfc822) {
notify_email_sent(rfc822);
}
private ImapDB.EmailIdentifier check_id(Geary.EmailIdentifier id) throws EngineError {
ImapDB.EmailIdentifier? imapdb_id = id as ImapDB.EmailIdentifier;
if (imapdb_id == null)
throw new EngineError.BAD_PARAMETERS("EmailIdentifier %s not from ImapDB folder", id.to_string());
return imapdb_id;
}
private Gee.Collection<ImapDB.EmailIdentifier> check_ids(Gee.Collection<Geary.EmailIdentifier> ids)
throws EngineError {
foreach (Geary.EmailIdentifier id in ids) {
if (!(id is ImapDB.EmailIdentifier))
throw new EngineError.BAD_PARAMETERS("EmailIdentifier %s not from ImapDB folder", id.to_string());
}
return (Gee.Collection<ImapDB.EmailIdentifier>) ids;
}
public override async Gee.MultiMap<Geary.Email, Geary.FolderPath?>? local_search_message_id_async(
Geary.RFC822.MessageID message_id, Geary.Email.Field requested_fields, bool partial_ok,
Gee.Collection<Geary.FolderPath?>? folder_blacklist, Geary.EmailFlags? flag_blacklist,
Cancellable? cancellable = null) throws Error {
return yield local.search_message_id_async(
message_id, requested_fields, partial_ok, folder_blacklist, flag_blacklist, cancellable);
}
public override async Geary.Email local_fetch_email_async(Geary.EmailIdentifier email_id,
Geary.Email.Field required_fields, Cancellable? cancellable = null) throws Error {
return yield local.fetch_email_async(check_id(email_id), required_fields, cancellable);
}
public override Geary.SearchQuery open_search(string query, SearchQuery.Strategy strategy) {
return new ImapDB.SearchQuery(local, query, strategy);
}
public override async Gee.Collection<Geary.EmailIdentifier>? local_search_async(Geary.SearchQuery query,
int limit = 100, int offset = 0, Gee.Collection<Geary.FolderPath?>? folder_blacklist = null,
2013-05-14 11:52:02 -07:00
Gee.Collection<Geary.EmailIdentifier>? search_ids = null, Cancellable? cancellable = null) throws Error {
if (offset < 0)
throw new EngineError.BAD_PARAMETERS("Offset must not be negative");
return yield local.search_async(query, limit, offset, folder_blacklist, search_ids, cancellable);
2013-05-14 11:52:02 -07:00
}
public override async Gee.Set<string>? get_search_matches_async(Geary.SearchQuery query,
Gee.Collection<Geary.EmailIdentifier> ids, Cancellable? cancellable = null) throws Error {
return yield local.get_search_matches_async(query, check_ids(ids), cancellable);
}
public override async Gee.MultiMap<Geary.EmailIdentifier, Geary.FolderPath>? get_containing_folders_async(
Gee.Collection<Geary.EmailIdentifier> ids, Cancellable? cancellable) throws Error {
return yield local.get_containing_folders_async(ids, cancellable);
}
private void on_login_failed(Geary.Credentials? credentials, Geary.Imap.StatusResponse? response) {
if (awaiting_credentials)
return; // We're already asking for the password.
awaiting_credentials = true;
do_login_failed_async.begin(credentials, response, () => { awaiting_credentials = false; });
Load and display multiple accounts; fix #6230 Lots has been changed here. See the bug report <http://redmine.yorba.org/issues/6230> for some of the discussion about it. This also fixes #6274. I'll cut the list of revisions off after a while, because this branch has been outstanding for a couple weeks. Squashed commit of the following: commit ae505d89e87e63e0d8949bfd901913706a9d3b73 Merge: 81ef002 e18bef9 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 15:16:17 2013 -0800 Merge branch 'master' into multiple-accounts commit 81ef002f5ff486b9c28f5663a0ba1e7392b8489c Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 15:15:51 2013 -0800 Fix final round of code review commit 6935b1e7892b9b356bf5006b89e0b2a4e6a8ad16 Merge: c9ed434 a9dc52b Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:45:46 2013 -0800 Merge branch 'master' into multiple-accounts commit c9ed434fe936e6aed735baef222ae615364c2513 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:31:02 2013 -0800 Simplify folder comparator commit 28ac020cfd9135c6eb4ed05574c82b92f99c4a40 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:06:55 2013 -0800 Bump up declaration to conform to guidelines commit 0a8167bdaebd5fac1c3ca791de5f2cc233c13cb9 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 13:54:03 2013 -0800 Rename back to list_*folders commit 31457f60298052bdddba8e426db27f93d7c72529 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 12:36:15 2013 -0800 Fix spacing, brevity issues commit ecd30c203d80c21c1ca1234b8911b57efcb68294 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:56:29 2013 -0800 Fix nits before review commit 85b51d71e83115991cd9a54d491b4d45b71f2f9b Merge: b29abce d538bf0 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:46:19 2013 -0800 Merge branch 'master' into multiple-accounts commit b29abceeaea84f226ab9bcd22266a511691d8005 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:22:28 2013 -0800 Fix notifications commit c26d975fb0859d807ddb7f7c10632605c3b6fb1c Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 13:01:03 2013 -0800 Only show current acct. folders in copy/move menus commit 9a5b57db1229a079f11f518c53f5762a3670b83f Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:48:05 2013 -0800 Fix issue where wrong mail would show in folders commit 3b05d18843584c2aff7472708eea30ce24068043 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:18:38 2013 -0800 Fix ordering of folders in side bar commit b228967b6a74c16698d593e53e65d66c69ffb974 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:07:32 2013 -0800 Add icon to accounts in sidebar commit dd05d2c987a46f0b6699d743c339297e06829e4f Author: Charles Lindsay <chaz@yorba.org> Date: Tue Jan 29 19:04:52 2013 -0800 Fix Labels icon commit b5254fe8f6ef37df48d41167d0f52f3cd88d1966 Author: Charles Lindsay <chaz@yorba.org> Date: Tue Jan 29 18:43:45 2013 -0800 Initial stab at new FolderList; fix compile errors commit ff591810ee4312acce208dfa36d993069bc4c7d2 Merge: 2b9dbb9 ff5f9fa Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 17:42:34 2013 -0800 Merge branch 'master' into multiple-accounts commit 2b9dbb9b6963b1d52b2b90300bcea277b01d2094 Merge: 7583241 fcfb460 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 17:21:49 2013 -0800 Merge branch 'master' into multiple-accounts Conflicts: src/client/geary-controller.vala commit 75832412cc806c956848e32ef20052af36d4f64d Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 16:37:15 2013 -0800 Fix IMAP sess. mgr. to recover from bad passwords commit 8868b4be5c3f5c97246d35c6170531c6f543abe1 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 12:06:21 2013 -0800 Typo commit 3f909054502d31ca48e11f7948fd22118afe7514 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 10:54:51 2013 -0800 Clean up interface a little commit 3bfb526fe8801f8234127944be8594a960ccf7e7 Merge: 5e84e93 e971275 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:23:52 2013 -0800 Merge branch 'master' into multiple-accounts Conflicts: src/client/geary-application.vala src/engine/api/geary-engine.vala commit 5e84e9375a655567a3bc4eb7ebaacab2d218be40 Merge: 35cc46b 9167aeb Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:17:00 2013 -0800 Merge branch 'pluggable-auth' into multiple-accounts Conflicts: src/engine/api/geary-engine.vala commit 9167aeb56be6789d49a3e7cdba2a21d2b015e40d Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:11:20 2013 -0800 Fix for code guidelines commit 35cc46bc99f44f1597c609bfeaa72dd503333a17 Merge: 9675f47 7612a7d Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 15:44:18 2013 -0800 Merge branch 'pluggable-auth' into multiple-accounts Conflicts: src/client/geary-application.vala commit 7612a7ddc3df14ef207b9e74ee32fa23710e1ce9 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 15:26:48 2013 -0800 Fix code review issues commit 46635544c98df7a8b6c76f028715814907274389 Merge: 30b611e 6de36ae Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:54:03 2013 -0800 Merge branch 'master' into pluggable-auth commit 9675f473e77d0d581cf73a33012981e6a4f44943 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:53:18 2013 -0800 Try to make Folder know about its Account commit 5d9af43e53199a616490cf6ff98bd3c613b4e5f2 Merge: 335480e 6de36ae Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:12:21 2013 -0800 Merge branch 'master' into multiple-accounts commit 335480e2dd0261c8fb82f1c6296f5b8c76f3ac02 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:11:18 2013 -0800 Work on multiple accounts; fix compilation errors commit 808e65d55798e3f08b4c70992718cc11befbb45c Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 24 19:28:12 2013 -0800 Fix application logic for multiple accounts You get the idea.
2013-01-31 15:17:44 -08:00
}
private async void do_login_failed_async(Geary.Credentials? credentials, Geary.Imap.StatusResponse? response) {
bool reask_password = true;
Load and display multiple accounts; fix #6230 Lots has been changed here. See the bug report <http://redmine.yorba.org/issues/6230> for some of the discussion about it. This also fixes #6274. I'll cut the list of revisions off after a while, because this branch has been outstanding for a couple weeks. Squashed commit of the following: commit ae505d89e87e63e0d8949bfd901913706a9d3b73 Merge: 81ef002 e18bef9 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 15:16:17 2013 -0800 Merge branch 'master' into multiple-accounts commit 81ef002f5ff486b9c28f5663a0ba1e7392b8489c Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 15:15:51 2013 -0800 Fix final round of code review commit 6935b1e7892b9b356bf5006b89e0b2a4e6a8ad16 Merge: c9ed434 a9dc52b Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:45:46 2013 -0800 Merge branch 'master' into multiple-accounts commit c9ed434fe936e6aed735baef222ae615364c2513 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:31:02 2013 -0800 Simplify folder comparator commit 28ac020cfd9135c6eb4ed05574c82b92f99c4a40 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:06:55 2013 -0800 Bump up declaration to conform to guidelines commit 0a8167bdaebd5fac1c3ca791de5f2cc233c13cb9 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 13:54:03 2013 -0800 Rename back to list_*folders commit 31457f60298052bdddba8e426db27f93d7c72529 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 12:36:15 2013 -0800 Fix spacing, brevity issues commit ecd30c203d80c21c1ca1234b8911b57efcb68294 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:56:29 2013 -0800 Fix nits before review commit 85b51d71e83115991cd9a54d491b4d45b71f2f9b Merge: b29abce d538bf0 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:46:19 2013 -0800 Merge branch 'master' into multiple-accounts commit b29abceeaea84f226ab9bcd22266a511691d8005 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:22:28 2013 -0800 Fix notifications commit c26d975fb0859d807ddb7f7c10632605c3b6fb1c Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 13:01:03 2013 -0800 Only show current acct. folders in copy/move menus commit 9a5b57db1229a079f11f518c53f5762a3670b83f Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:48:05 2013 -0800 Fix issue where wrong mail would show in folders commit 3b05d18843584c2aff7472708eea30ce24068043 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:18:38 2013 -0800 Fix ordering of folders in side bar commit b228967b6a74c16698d593e53e65d66c69ffb974 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:07:32 2013 -0800 Add icon to accounts in sidebar commit dd05d2c987a46f0b6699d743c339297e06829e4f Author: Charles Lindsay <chaz@yorba.org> Date: Tue Jan 29 19:04:52 2013 -0800 Fix Labels icon commit b5254fe8f6ef37df48d41167d0f52f3cd88d1966 Author: Charles Lindsay <chaz@yorba.org> Date: Tue Jan 29 18:43:45 2013 -0800 Initial stab at new FolderList; fix compile errors commit ff591810ee4312acce208dfa36d993069bc4c7d2 Merge: 2b9dbb9 ff5f9fa Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 17:42:34 2013 -0800 Merge branch 'master' into multiple-accounts commit 2b9dbb9b6963b1d52b2b90300bcea277b01d2094 Merge: 7583241 fcfb460 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 17:21:49 2013 -0800 Merge branch 'master' into multiple-accounts Conflicts: src/client/geary-controller.vala commit 75832412cc806c956848e32ef20052af36d4f64d Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 16:37:15 2013 -0800 Fix IMAP sess. mgr. to recover from bad passwords commit 8868b4be5c3f5c97246d35c6170531c6f543abe1 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 12:06:21 2013 -0800 Typo commit 3f909054502d31ca48e11f7948fd22118afe7514 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 10:54:51 2013 -0800 Clean up interface a little commit 3bfb526fe8801f8234127944be8594a960ccf7e7 Merge: 5e84e93 e971275 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:23:52 2013 -0800 Merge branch 'master' into multiple-accounts Conflicts: src/client/geary-application.vala src/engine/api/geary-engine.vala commit 5e84e9375a655567a3bc4eb7ebaacab2d218be40 Merge: 35cc46b 9167aeb Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:17:00 2013 -0800 Merge branch 'pluggable-auth' into multiple-accounts Conflicts: src/engine/api/geary-engine.vala commit 9167aeb56be6789d49a3e7cdba2a21d2b015e40d Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:11:20 2013 -0800 Fix for code guidelines commit 35cc46bc99f44f1597c609bfeaa72dd503333a17 Merge: 9675f47 7612a7d Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 15:44:18 2013 -0800 Merge branch 'pluggable-auth' into multiple-accounts Conflicts: src/client/geary-application.vala commit 7612a7ddc3df14ef207b9e74ee32fa23710e1ce9 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 15:26:48 2013 -0800 Fix code review issues commit 46635544c98df7a8b6c76f028715814907274389 Merge: 30b611e 6de36ae Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:54:03 2013 -0800 Merge branch 'master' into pluggable-auth commit 9675f473e77d0d581cf73a33012981e6a4f44943 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:53:18 2013 -0800 Try to make Folder know about its Account commit 5d9af43e53199a616490cf6ff98bd3c613b4e5f2 Merge: 335480e 6de36ae Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:12:21 2013 -0800 Merge branch 'master' into multiple-accounts commit 335480e2dd0261c8fb82f1c6296f5b8c76f3ac02 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:11:18 2013 -0800 Work on multiple accounts; fix compilation errors commit 808e65d55798e3f08b4c70992718cc11befbb45c Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 24 19:28:12 2013 -0800 Fix application logic for multiple accounts You get the idea.
2013-01-31 15:17:44 -08:00
try {
reask_password = (
response == null ||
response.response_code == null ||
response.response_code.get_response_code_type().value != Geary.Imap.ResponseCodeType.UNAVAILABLE
);
} catch (ImapError ierr) {
debug("Unable to parse ResponseCode %s: %s", response.response_code.to_string(),
ierr.message);
}
// login can fail due to an invalid password hence we should re-ask it
// but it can also fail due to server inaccessibility, for instance "[UNAVAILABLE] /
// Maximum number of connections from user+IP exceeded". In that case, resetting password seems unneeded.
if (reask_password) {
try {
if (yield information.fetch_passwords_async(ServiceFlag.IMAP, true))
return;
} catch (Error e) {
debug("Error prompting for IMAP password: %s", e.message);
}
notify_report_problem(Geary.Account.Problem.RECV_EMAIL_LOGIN_FAILED, null);
} else {
notify_report_problem(Geary.Account.Problem.CONNECTION_FAILURE, null);
Load and display multiple accounts; fix #6230 Lots has been changed here. See the bug report <http://redmine.yorba.org/issues/6230> for some of the discussion about it. This also fixes #6274. I'll cut the list of revisions off after a while, because this branch has been outstanding for a couple weeks. Squashed commit of the following: commit ae505d89e87e63e0d8949bfd901913706a9d3b73 Merge: 81ef002 e18bef9 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 15:16:17 2013 -0800 Merge branch 'master' into multiple-accounts commit 81ef002f5ff486b9c28f5663a0ba1e7392b8489c Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 15:15:51 2013 -0800 Fix final round of code review commit 6935b1e7892b9b356bf5006b89e0b2a4e6a8ad16 Merge: c9ed434 a9dc52b Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:45:46 2013 -0800 Merge branch 'master' into multiple-accounts commit c9ed434fe936e6aed735baef222ae615364c2513 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:31:02 2013 -0800 Simplify folder comparator commit 28ac020cfd9135c6eb4ed05574c82b92f99c4a40 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 14:06:55 2013 -0800 Bump up declaration to conform to guidelines commit 0a8167bdaebd5fac1c3ca791de5f2cc233c13cb9 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 13:54:03 2013 -0800 Rename back to list_*folders commit 31457f60298052bdddba8e426db27f93d7c72529 Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 31 12:36:15 2013 -0800 Fix spacing, brevity issues commit ecd30c203d80c21c1ca1234b8911b57efcb68294 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:56:29 2013 -0800 Fix nits before review commit 85b51d71e83115991cd9a54d491b4d45b71f2f9b Merge: b29abce d538bf0 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:46:19 2013 -0800 Merge branch 'master' into multiple-accounts commit b29abceeaea84f226ab9bcd22266a511691d8005 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 17:22:28 2013 -0800 Fix notifications commit c26d975fb0859d807ddb7f7c10632605c3b6fb1c Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 13:01:03 2013 -0800 Only show current acct. folders in copy/move menus commit 9a5b57db1229a079f11f518c53f5762a3670b83f Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:48:05 2013 -0800 Fix issue where wrong mail would show in folders commit 3b05d18843584c2aff7472708eea30ce24068043 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:18:38 2013 -0800 Fix ordering of folders in side bar commit b228967b6a74c16698d593e53e65d66c69ffb974 Author: Charles Lindsay <chaz@yorba.org> Date: Wed Jan 30 11:07:32 2013 -0800 Add icon to accounts in sidebar commit dd05d2c987a46f0b6699d743c339297e06829e4f Author: Charles Lindsay <chaz@yorba.org> Date: Tue Jan 29 19:04:52 2013 -0800 Fix Labels icon commit b5254fe8f6ef37df48d41167d0f52f3cd88d1966 Author: Charles Lindsay <chaz@yorba.org> Date: Tue Jan 29 18:43:45 2013 -0800 Initial stab at new FolderList; fix compile errors commit ff591810ee4312acce208dfa36d993069bc4c7d2 Merge: 2b9dbb9 ff5f9fa Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 17:42:34 2013 -0800 Merge branch 'master' into multiple-accounts commit 2b9dbb9b6963b1d52b2b90300bcea277b01d2094 Merge: 7583241 fcfb460 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 17:21:49 2013 -0800 Merge branch 'master' into multiple-accounts Conflicts: src/client/geary-controller.vala commit 75832412cc806c956848e32ef20052af36d4f64d Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 16:37:15 2013 -0800 Fix IMAP sess. mgr. to recover from bad passwords commit 8868b4be5c3f5c97246d35c6170531c6f543abe1 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 12:06:21 2013 -0800 Typo commit 3f909054502d31ca48e11f7948fd22118afe7514 Author: Charles Lindsay <chaz@yorba.org> Date: Mon Jan 28 10:54:51 2013 -0800 Clean up interface a little commit 3bfb526fe8801f8234127944be8594a960ccf7e7 Merge: 5e84e93 e971275 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:23:52 2013 -0800 Merge branch 'master' into multiple-accounts Conflicts: src/client/geary-application.vala src/engine/api/geary-engine.vala commit 5e84e9375a655567a3bc4eb7ebaacab2d218be40 Merge: 35cc46b 9167aeb Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:17:00 2013 -0800 Merge branch 'pluggable-auth' into multiple-accounts Conflicts: src/engine/api/geary-engine.vala commit 9167aeb56be6789d49a3e7cdba2a21d2b015e40d Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 16:11:20 2013 -0800 Fix for code guidelines commit 35cc46bc99f44f1597c609bfeaa72dd503333a17 Merge: 9675f47 7612a7d Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 15:44:18 2013 -0800 Merge branch 'pluggable-auth' into multiple-accounts Conflicts: src/client/geary-application.vala commit 7612a7ddc3df14ef207b9e74ee32fa23710e1ce9 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 15:26:48 2013 -0800 Fix code review issues commit 46635544c98df7a8b6c76f028715814907274389 Merge: 30b611e 6de36ae Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:54:03 2013 -0800 Merge branch 'master' into pluggable-auth commit 9675f473e77d0d581cf73a33012981e6a4f44943 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:53:18 2013 -0800 Try to make Folder know about its Account commit 5d9af43e53199a616490cf6ff98bd3c613b4e5f2 Merge: 335480e 6de36ae Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:12:21 2013 -0800 Merge branch 'master' into multiple-accounts commit 335480e2dd0261c8fb82f1c6296f5b8c76f3ac02 Author: Charles Lindsay <chaz@yorba.org> Date: Fri Jan 25 12:11:18 2013 -0800 Work on multiple accounts; fix compilation errors commit 808e65d55798e3f08b4c70992718cc11befbb45c Author: Charles Lindsay <chaz@yorba.org> Date: Thu Jan 24 19:28:12 2013 -0800 Fix application logic for multiple accounts You get the idea.
2013-01-31 15:17:44 -08:00
}
}
}