nettika/geary
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
geary/test/test-engine.vala

79 lines
3.1 KiB
Vala
Raw Normal View History

Basic unit test build configuration.
2016-12-12 22:47:53 +11:00
/*
Add unit test for IMAP FETCH command constructor.
2018-07-26 11:25:35 +10:00
* Copyright 2016-2018 Michael Gratton <mike@vee.net>
Basic unit test build configuration.
2016-12-12 22:47:53 +11:00
*
* This software is licensed under the GNU Lesser General Public License
* (version 2.1 or later). See the COPYING file in this distribution.
*/
Add an initial/example unit test.
2016-12-12 23:39:46 +11:00
int main(string[] args) {
Add client lib to the test build. * test/CMakeLists.txt: Add client lib and dependent packages to the build. * test/main.vala (main): Add test suites for both client and engine tests to allow some more fine-grained control when running them. Also add some sectioning doc comments.
2016-12-26 13:18:51 +10:30
/*
* Initialise all the things.
*/
Basic unit test build configuration.
2016-12-12 22:47:53 +11:00
Test.init(ref args);
Fix HTML, CSS and JS leaking into conversation list preview. Bug 714317 When generating the preview, only the first 128 bytes of the first MIME part is fetched and used. If this part is text/html with a significant amount of embedded CSS, then there is a good chance the string passed to Geary.HTML::remove_html_tags() will be invalid, or be missing closing elements. Since that function uses regexes that require balanced tags to remove script and style blocks, then it was very possible that in these cases this method will miss removing these blocks. To solve this, remove_html_tags() is removed and its call sites are replaced by calls to Geary.HTML::html_to_text(), which has been tidyied up to produce more human-readable result. Add unit tests to cover new html_to_text functionality and its call sites. * src/engine/util/util-html.vala: Remove remove_html_tags(). Update html_to_text() to not just insert line breaks, but also insert spaces and alt text, and ignore tags like HEAD, SCRIPT and STYLE, as appropriate. Add an optional param to also allow skipping BLOCKQUOTE elements, which we don't want in the preview.
2016-12-18 23:28:53 +11:00
Geary.RFC822.init();
Geary.HTML.init();
Fix JS error getting F=F text from ComposerWebView. Add JS unit tests. * ui/composer-web-view.js (ComposerPageState::resolveNesting): Apply JS RegExp globally, to match default GLib RegEx behaviour. * test/js/composer-page-state-test.vala: New tests covering generation of HTML and F=F text from JS ComposerPageState object. * test/CMakeLists.txt: Add the new test. * test/main.vala (main): Add a test suite for JS tests, add the new test to it. * src/client/components/client-web-view.vala (ClientWebView): Add a reason to the JSError domain for when a JS exception is thrown. * bindings/vapi/javascriptcore-4.0.vapi (JS::Context): Add JS.Type and some additional methods needed for the unit tests. Move most GlobalContext methods to Context so we can pass the lowest common demominator around.
2017-01-01 12:37:08 +11:00
Geary.Logging.init();
Fix HTML, CSS and JS leaking into conversation list preview. Bug 714317 When generating the preview, only the first 128 bytes of the first MIME part is fetched and used. If this part is text/html with a significant amount of embedded CSS, then there is a good chance the string passed to Geary.HTML::remove_html_tags() will be invalid, or be missing closing elements. Since that function uses regexes that require balanced tags to remove script and style blocks, then it was very possible that in these cases this method will miss removing these blocks. To solve this, remove_html_tags() is removed and its call sites are replaced by calls to Geary.HTML::html_to_text(), which has been tidyied up to produce more human-readable result. Add unit tests to cover new html_to_text functionality and its call sites. * src/engine/util/util-html.vala: Remove remove_html_tags(). Update html_to_text() to not just insert line breaks, but also insert spaces and alt text, and ignore tags like HEAD, SCRIPT and STYLE, as appropriate. Add an optional param to also allow skipping BLOCKQUOTE elements, which we don't want in the preview.
2016-12-18 23:28:53 +11:00
Add client lib to the test build. * test/CMakeLists.txt: Add client lib and dependent packages to the build. * test/main.vala (main): Add test suites for both client and engine tests to allow some more fine-grained control when running them. Also add some sectioning doc comments.
2016-12-26 13:18:51 +10:30
/*
* Hook up all tests into appropriate suites
*/
TestSuite engine = new TestSuite("engine");
Add an initial/example unit test.
2016-12-12 23:39:46 +11:00
Fix AccountInformation.has_email_address, add tests.
2018-07-02 19:03:42 +10:00
engine.add_suite(new Geary.AccountInformationTest().get_suite());
Clean up default filename when saving attachments. This ensures both inline images are saved using the specified content filename, if any, and that an extension is attempted to be guessed when no filename is specified. Fixes Bug 713999, Bug 712923, Bug 778026. * src/client/application/geary-controller.vala: Major rework of how attachments are saved. Rework how save dialogs are constructed, combining common code paths into one constrcutor method. Split up code for saving one attachment vs many into two different methods. Ensure all code baths ultimately use the same method to do the actual saving. Lookup a attachment when saving an inline image and use that by default. Get filenames from new Attachment::get_useful_filename method that guesses if needed. * src/client/conversation-viewer/conversation-message.vala (ConversationMessage::save_image): Fix name of first param to reflect what it actually is. * src/engine/api/geary-attachment.vala (Attachment): Add ::get_safe_filename method that checks the type of both the attachment's content and its file name, if any. Will construct an appropriate file name if non is given. Add unit tests. * src/engine/api/geary-email.vala (Email): Add new ::get_attachment_by_content_id to lookup attachments by MIME content-id. Rename old ::get_attachment method to disambiguate.
2017-02-11 11:34:30 +11:00
engine.add_suite(new Geary.AttachmentTest().get_suite());
Add unit tests for adding accounts. * src/engine/api/geary-engine.vala (Engine::create_orphan_account): Fix sense of test when determining the next account id to use. Add unit tests. (Engine::add_account): Made public so it can be used in public test.
2017-02-17 17:41:16 +11:00
engine.add_suite(new Geary.EngineTest().get_suite());
Add IdleManager class for sane main loop idle scheduling.
2017-02-09 10:54:45 +11:00
engine.add_suite(new Geary.IdleManagerTest().get_suite());
Add some useful Engine API mock objects.
2017-12-06 16:23:31 +11:00
engine.add_suite(new Geary.TimeoutManagerTest().get_suite());
Make Geary.App.Conversation unit testable, add some tests. * src/engine/app/app-conversation.vala (Conversation): We currently can't easily unit test Conversation instances since the ctor requires a ConversationMonitor argument, which is complicated. Replace the monitor arg with a base folder (which is what it actually needs the monitor for anyway) and remove the signals in favour of adding and modifying the API to allow folder paths to be explicitly updated. Remove clear_owner() method and dtor now it's useless. Update call sites. Add unit tests to make sure the add/remove and multi-path related code still works at least.
2017-12-06 17:02:20 +11:00
engine.add_suite(new Geary.App.ConversationTest().get_suite());
Make Geary.App.ConversationSet unit testable, add unit tests. * src/engine/app/conversation-monitor/app-conversation-set.vala (ConversationSet.add_all_emails_async): Replace monitor arg with a multiset of email paths, update call site to do the path lookup on the caller's side instead. Add unit tests. (ConversationSet.merge_conversations_async): Remove monitor arg with a multiset of email paths, get paths for emails to be merged from the conversations themselves, since they should be up to date. (Conversation.remove_all_emails_by_identifier): Add unit tests.
2017-12-07 10:25:14 +11:00
engine.add_suite(new Geary.App.ConversationSetTest().get_suite());
Add unit tests for ConversationMonitor, fix a few issues. * src/engine/app/app-conversation-monitor.vala (ConversationMonitor): Don't check the folder blacklist for external folder signals when the signal is received, do it when the operation is executed so it's fresh. * src/engine/app/conversation-monitor/app-fill-window-operation.vala (FillWindowOperation): Only re-fill the conversation if we get a full load, anything else means we hit the end of the folder. * test/engine/app/app-conversation-monitor-test.vala: New unit tests for ConversationMonitor. * test/engine/api/geary-account-mock.vala, test/engine/api/geary-folder-mock.vala: Mix in MockObject mock up all method calls. * test/engine/api/geary-email-identifier-mock.vala: Fix the comparator method when the other instance is null.
2018-04-04 15:58:44 +10:00
// Depends on ConversationTest and ConversationSetTest passing
engine.add_suite(new Geary.App.ConversationMonitorTest().get_suite());
Fix failing RFC822.Mailbox test. Reverting commit 1d8c4aea broke the mailbox class a bit. This fixes the issue, introduces Ascii.last_index_of which is needed by Mailbox anyway, and adds some test for it. Also 'optimises' Ascii.index_of bit as well.
2018-05-17 15:41:01 +10:00
engine.add_suite(new Geary.Ascii.Test().get_suite());
Introduce a ConfigFile class to improve config management. ConfigFile is a GLib.KeyFile-like class (and is backed by a KeyFile) that nonetheless provides convenient a high-level API for getting and setting grouped config values and asynchronous loading and saving. * src/engine/util/util-config-file.vala: New ConfigFile class. * src/engine/api/geary-service-information.vala (ServiceInformation): Require ConfigFile groups rather than KeyFile instances for loading and saving. Update subclasses and unit tests. * src/client/accounts/account-manager.vala (AccountManager): Move generic account key consts here from Config. Instead of using KeyFile directly, use ConfigFile groups for loading and saving settings. Rename load and save methods to be a bit more consistent with the class's role, and make save_account() throw its errors so they can be reported to the user. Update call sites. * src/client/accounts/local-service-information.vala (LocalServiceInformation): Move service-specific config key consts here, use new ConfigFile groups for loading and saving. * src/engine/api/geary-config.vala: Removed, all config consts have been moved to the classes using them and KeyFile convenience methods subsumed by ConfigFile.
2018-05-25 00:32:17 +10:00
engine.add_suite(new Geary.ConfigFileTest().get_suite());
Make database classes more amenable to asynchronous use. This makes both the open() and open_connection() methods on Geary.DB.Database asynchronous, which allows the VersionedDatabase open_background() and its hackery to be removed, and upgrades to be performed asynchronously as well. It also adds a exec_transaction_async() method to Connection, allowing an existing object to also be used to establish an async transaction. * src/engine/db/db-connection.vala (Connection): Add exec_transaction_async method, update doc comments. * src/engine/db/db-database.vala (Database): Make open and open_connection async by executing SQLite code in a background thread, update call sites. Move job management code out of exec_transaction_async into a new internal add_async_job() method so it can be used by Connection. Add unit tests. * src/engine/db/db-transaction-async-job.vala (TransactionAsyncJob): Add an optional internal connection method and make the job's cancellable an internal property so a Connection instance can specify itself for the transaction. * src/engine/db/db-versioned-database.vala (VersionedDatabase): Remove open_background() hack since open() is now async. Make version upgrade hooks for derived classes async and update call sites. Use a Nonblocking.Mutex rather than GLib mutex so upgrade exclusion works asynchronously. Add unit tests. * src/engine/imap-db/imap-db-database.vala (Database): Make database upgrade methods async and execute SQL in async instructions now that the bases classes support it. Add unit tests.
2018-05-08 09:18:06 +09:30
engine.add_suite(new Geary.Db.DatabaseTest().get_suite());
engine.add_suite(new Geary.Db.VersionedDatabaseTest().get_suite());
Add some useful Engine API mock objects.
2017-12-06 16:23:31 +11:00
engine.add_suite(new Geary.HTML.UtilTest().get_suite());
Fix Imap.DataFormat.is_atom_special not flagging \, [, or DEL as special Add unit tests.
2018-07-20 13:29:09 +10:00
// Other IMAP tests rely on DataFormat working, so test that first
engine.add_suite(new Geary.Imap.DataFormatTest().get_suite());
Add unit tests for NAMESPACE parsing, CREATE serialisation, fix an error.
2017-11-03 16:52:21 +11:00
engine.add_suite(new Geary.Imap.CreateCommandTest().get_suite());
Fix Imap.DataFormat.is_atom_special not flagging \, [, or DEL as special Add unit tests.
2018-07-20 13:29:09 +10:00
engine.add_suite(new Geary.Imap.DeserializerTest().get_suite());
Add unit test for IMAP FETCH command constructor.
2018-07-26 11:25:35 +10:00
engine.add_suite(new Geary.Imap.FetchCommandTest().get_suite());
engine.add_suite(new Geary.Imap.ListParameterTest().get_suite());
Fix mailbox names not being sent to the server quoted if needed. Since MailboxParameter inherited from StringParameter directly, it meant that we could never send mailbox names as quoted strings. Also, the modified-UTF-7 encoding used for mailbox names does not encode atom-specials such as "\", so if a mailbox name contained one or more of these, it would be sent to the mail server unquoted. This removes the MailboxParameter class altogether, and does the parameter conversion to/from appropriate StringParameter subclasses as needed. Also adds unit tests for param conversion for ASCII, atom-specials, and non-ASCII mailbox names. Fixes issue #40
2018-07-20 13:35:26 +10:00
engine.add_suite(new Geary.Imap.MailboxSpecifierTest().get_suite());
Add unit tests for NAMESPACE parsing, CREATE serialisation, fix an error.
2017-11-03 16:52:21 +11:00
engine.add_suite(new Geary.Imap.NamespaceResponseTest().get_suite());
Move attachment related code from ImapDB.Folder to Attachment.
2018-04-28 20:56:09 +10:00
engine.add_suite(new Geary.ImapDB.AttachmentTest().get_suite());
Improve how attachments are saved to the db and disk. This mostly aims to make the Geary.Attachment and ImapDB.Attachment objects usable more generally for managing attachments, allowing these to be instantiated once, persisted, and then reused, rather than going through a number of representations (GMime, SQlite, Geary) and having to be saved and re-loaded. * src/engine/api/geary-attachment.vala (Attachment): Remove id property and allow both file and filesize properties to be set after instances are constructed. Update call sites. * src/engine/api/geary-email.vala (Email): Remove get_attachment_by_id since it unused. * src/engine/imap-db/imap-db-attachment.vala (Attachment): Chase Geary.Attachment API changes, move object-specific persistence code into methods on the actual object class itself and modernise a bit. Rename static methods to be a bit more terse. Update call sites and add unit tests. * src/engine/imap-db/imap-db-folder.vala (Folder): Rather than saving attachments to the db then reloading them to add them to their email objects, just instantiate Attachment instances once, save and then add them. * src/engine/imap-db/imap-db-gc.vala (GC): Replace custom SQL with existing accessor for listing attachments. * src/engine/util/util-stream.vala (MimeOutputStream): New adaptor class for GMime streams to GIO output streams.
2018-05-05 12:18:22 +10:00
engine.add_suite(new Geary.ImapDB.AttachmentIoTest().get_suite());
Make database classes more amenable to asynchronous use. This makes both the open() and open_connection() methods on Geary.DB.Database asynchronous, which allows the VersionedDatabase open_background() and its hackery to be removed, and upgrades to be performed asynchronously as well. It also adds a exec_transaction_async() method to Connection, allowing an existing object to also be used to establish an async transaction. * src/engine/db/db-connection.vala (Connection): Add exec_transaction_async method, update doc comments. * src/engine/db/db-database.vala (Database): Make open and open_connection async by executing SQLite code in a background thread, update call sites. Move job management code out of exec_transaction_async into a new internal add_async_job() method so it can be used by Connection. Add unit tests. * src/engine/db/db-transaction-async-job.vala (TransactionAsyncJob): Add an optional internal connection method and make the job's cancellable an internal property so a Connection instance can specify itself for the transaction. * src/engine/db/db-versioned-database.vala (VersionedDatabase): Remove open_background() hack since open() is now async. Make version upgrade hooks for derived classes async and update call sites. Use a Nonblocking.Mutex rather than GLib mutex so upgrade exclusion works asynchronously. Add unit tests. * src/engine/imap-db/imap-db-database.vala (Database): Make database upgrade methods async and execute SQL in async instructions now that the bases classes support it. Add unit tests.
2018-05-08 09:18:06 +09:30
engine.add_suite(new Geary.ImapDB.DatabaseTest().get_suite());
Add an operations queue to GenericAccount for server operations. This generalises the approach used to execute the flag watcher and background sync, provides a high-level means of managing local and remote operations, and provides a means of compartmentalising operation-specific code. * src/engine/imap-engine/imap-engine-account-operation.vala (AccountProcessor): Interface for denoting classes that implements some account-specific operation. * src/engine/imap-engine/imap-engine-account-processor.vala (AccountProcessor): Class to manage the operation queue and execute operations. * src/engine/imap-engine/imap-engine-generic-account.vala (GenericAccount): Create and manage an instance of AccountProcessor, add queue_operation method to allow operations to be queued.
2017-11-23 10:11:30 +11:00
engine.add_suite(new Geary.ImapEngine.AccountProcessorTest().get_suite());
Add Geary.Inet::is_valid_display_host and tests.
2017-01-19 01:23:33 +11:00
engine.add_suite(new Geary.Inet.Test().get_suite());
Add IdleManager class for sane main loop idle scheduling.
2017-02-09 10:54:45 +11:00
engine.add_suite(new Geary.JS.Test().get_suite());
Add ContentType methods for determining file name extenions and type sniffing. * src/engine/mime/mime-content-type.vala (ContentType): Add ::guess_type and ::get_file_name_extension methods, unit tests.
2017-02-14 22:26:14 +11:00
engine.add_suite(new Geary.Mime.ContentTypeTest().get_suite());
Add client lib to the test build. * test/CMakeLists.txt: Add client lib and dependent packages to the build. * test/main.vala (main): Add test suites for both client and engine tests to allow some more fine-grained control when running them. Also add some sectioning doc comments.
2016-12-26 13:18:51 +10:30
engine.add_suite(new Geary.RFC822.MailboxAddressTest().get_suite());
Fix MailboxAddresses.to_rfc822_string formatting, add unit tests.
2018-01-31 11:09:09 +10:30
engine.add_suite(new Geary.RFC822.MailboxAddressesTest().get_suite());
Add client lib to the test build. * test/CMakeLists.txt: Add client lib and dependent packages to the build. * test/main.vala (main): Add test suites for both client and engine tests to allow some more fine-grained control when running them. Also add some sectioning doc comments.
2016-12-26 13:18:51 +10:30
engine.add_suite(new Geary.RFC822.MessageTest().get_suite());
engine.add_suite(new Geary.RFC822.MessageDataTest().get_suite());
engine.add_suite(new Geary.RFC822.Utils.Test().get_suite());
Check for spoofed sender addresses, only display the address if so. This adds a check for malware spoofing of RFC 822 mailbox addresses such as those found in Mailsploit, and if found only displays the email address part and not the mailbox name part. Part 1 of Mailsploit mitigation. * src/engine/rfc822/rfc822-mailbox-address.vala (MailboxAddress): Add new is_spoofed method to check if the mailbox address looks like it has been spoofed. Add is_distinct method to determine if the name and the label is the same. Do whitespace and non-printing character stripping when generating display versions of the mailbox address, rename methods to make it more obvious what they do and update call sites. Add unit tests to cover all this. * src/client/conversation-viewer/conversation-message.vala (ConversationMessage): Check name is distinct and is not valid before displaying it. Use new MailboxAddress methods for getting display versions of the address, to ensure we get the stripped versions of the addresses. * src/client/conversation-list/formatted-conversation-data.vala (ParticipantDisplay): Ensure full addresses are always HTML-markup escaped before displaying them as markup, to avoid dropping "<address>" values as invalid HTML. Always show the full address if an address is invalid. * src/engine/util/util-string.vala (reduce_whitespace): Strip not only whitespace but also non-printing characters. Add unit tests.
2018-01-29 09:57:24 +10:30
engine.add_suite(new Geary.String.Test().get_suite());
Add client lib to the test build. * test/CMakeLists.txt: Add client lib and dependent packages to the build. * test/main.vala (main): Add test suites for both client and engine tests to allow some more fine-grained control when running them. Also add some sectioning doc comments.
2016-12-26 13:18:51 +10:30
/*
* Run the tests
*/
TestSuite root = TestSuite.get_root();
root.add_suite(engine);
Split test running up into test-engine and test-client. This allows us to compile the engine tests against the internal VAPI, so we can unit test internal classes. * CMakeLists.txt: Add top-level targets test-engine-run and test-client-run that execute the respective test binaries. Make the tests target depend on them and make them depend on their binaries. * Makefile.in: Add test-client and test-engin targets for convenience. * src/CMakeLists.txt: Make the right invocation of valac to generate a correct geary-engine-internal.vapi. Make gsettings schema generation depend on geary-client so it exists for test-client if the main binary hasn't been built. * test/CMakeLists.txt: Split everything up into to builds, one for test-engine and the other for test-client. Use geary-engine-internal when building test-engine for access to internal classes and members. * test/engine/util-idle-manager-test.vala, test/engine/util-timeout-manager-test.vala: Use Glib MainContext rather than the GTK main loop for pumping events so the test cases compile without GTK. * test/test-engine.vala, test/test-client.vala: New main source file for test binaries based on old main.vala.
2017-11-23 09:35:51 +11:00
MainLoop loop = new MainLoop ();
Add an initial/example unit test.
2016-12-12 23:39:46 +11:00
Make GTK & async unit tests work by running them in a GTK+ main loop. Include GResources in the build so they can be loaded. Bug 776421. * test/main.vala (main): Init GTK, start a main loop and run the tests in that. * test/CMakeLists.txt: Include GResources in unit test binary so they can be loaded by tests, and since we can't compile them into the client static lib.
2016-12-31 14:49:38 +11:00
int ret = -1;
Idle.add(() => {
ret = Test.run();
Split test running up into test-engine and test-client. This allows us to compile the engine tests against the internal VAPI, so we can unit test internal classes. * CMakeLists.txt: Add top-level targets test-engine-run and test-client-run that execute the respective test binaries. Make the tests target depend on them and make them depend on their binaries. * Makefile.in: Add test-client and test-engin targets for convenience. * src/CMakeLists.txt: Make the right invocation of valac to generate a correct geary-engine-internal.vapi. Make gsettings schema generation depend on geary-client so it exists for test-client if the main binary hasn't been built. * test/CMakeLists.txt: Split everything up into to builds, one for test-engine and the other for test-client. Use geary-engine-internal when building test-engine for access to internal classes and members. * test/engine/util-idle-manager-test.vala, test/engine/util-timeout-manager-test.vala: Use Glib MainContext rather than the GTK main loop for pumping events so the test cases compile without GTK. * test/test-engine.vala, test/test-client.vala: New main source file for test binaries based on old main.vala.
2017-11-23 09:35:51 +11:00
loop.quit();
Make GTK & async unit tests work by running them in a GTK+ main loop. Include GResources in the build so they can be loaded. Bug 776421. * test/main.vala (main): Init GTK, start a main loop and run the tests in that. * test/CMakeLists.txt: Include GResources in unit test binary so they can be loaded by tests, and since we can't compile them into the client static lib.
2016-12-31 14:49:38 +11:00
return false;
});
Split test running up into test-engine and test-client. This allows us to compile the engine tests against the internal VAPI, so we can unit test internal classes. * CMakeLists.txt: Add top-level targets test-engine-run and test-client-run that execute the respective test binaries. Make the tests target depend on them and make them depend on their binaries. * Makefile.in: Add test-client and test-engin targets for convenience. * src/CMakeLists.txt: Make the right invocation of valac to generate a correct geary-engine-internal.vapi. Make gsettings schema generation depend on geary-client so it exists for test-client if the main binary hasn't been built. * test/CMakeLists.txt: Split everything up into to builds, one for test-engine and the other for test-client. Use geary-engine-internal when building test-engine for access to internal classes and members. * test/engine/util-idle-manager-test.vala, test/engine/util-timeout-manager-test.vala: Use Glib MainContext rather than the GTK main loop for pumping events so the test cases compile without GTK. * test/test-engine.vala, test/test-client.vala: New main source file for test binaries based on old main.vala.
2017-11-23 09:35:51 +11:00
loop.run();
Make GTK & async unit tests work by running them in a GTK+ main loop. Include GResources in the build so they can be loaded. Bug 776421. * test/main.vala (main): Init GTK, start a main loop and run the tests in that. * test/CMakeLists.txt: Include GResources in unit test binary so they can be loaded by tests, and since we can't compile them into the client static lib.
2016-12-31 14:49:38 +11:00
return ret;
Basic unit test build configuration.
2016-12-12 22:47:53 +11:00
}
Reference in a new issue Copy permalink